From d674158a16ab45f3b2cab2486daf0c6357b2ae34 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Tue, 22 Feb 2011 22:47:30 +0100 Subject: [PATCH] persistent: reduce indentation for the finishing moves in ctdb_persistent_callback --- server/ctdb_persistent.c | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/server/ctdb_persistent.c b/server/ctdb_persistent.c index 57332908..e49eac49 100644 --- a/server/ctdb_persistent.c +++ b/server/ctdb_persistent.c @@ -52,6 +52,7 @@ static void ctdb_persistent_callback(struct ctdb_context *ctdb, { struct ctdb_persistent_state *state = talloc_get_type(private_data, struct ctdb_persistent_state); + enum ctdb_trans2_commit_error etype; if (ctdb->recovery_mode != CTDB_RECOVERY_NORMAL) { DEBUG(DEBUG_INFO, ("ctdb_persistent_callback: ignoring reply " @@ -78,18 +79,21 @@ static void ctdb_persistent_callback(struct ctdb_context *ctdb, } state->num_pending--; - if (state->num_pending == 0) { - enum ctdb_trans2_commit_error etype; - if (state->num_failed == state->num_sent) { - etype = CTDB_TRANS2_COMMIT_ALLFAIL; - } else if (state->num_failed != 0) { - etype = CTDB_TRANS2_COMMIT_SOMEFAIL; - } else { - etype = CTDB_TRANS2_COMMIT_SUCCESS; - } - ctdb_request_control_reply(state->ctdb, state->c, NULL, etype, state->errormsg); - talloc_free(state); + + if (state->num_pending != 0) { + return; } + + if (state->num_failed == state->num_sent) { + etype = CTDB_TRANS2_COMMIT_ALLFAIL; + } else if (state->num_failed != 0) { + etype = CTDB_TRANS2_COMMIT_SOMEFAIL; + } else { + etype = CTDB_TRANS2_COMMIT_SUCCESS; + } + + ctdb_request_control_reply(state->ctdb, state->c, NULL, etype, state->errormsg); + talloc_free(state); } /* -- 2.34.1