[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.
[samba.git] / source / libsmb / clitrans.c
index 75afe5195ed8e7f842ffb4dc3f4e43adcd6d257b..e859dce95674f6f96d68aab33b599e907b03892b 100644 (file)
@@ -5,7 +5,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-#define NO_SYSLOG
-
 #include "includes.h"
 
 
@@ -97,9 +94,14 @@ BOOL cli_send_trans(struct cli_state *cli, int trans,
                return False;
        }
 
+       /* Note we're in a trans state. Save the sequence
+        * numbers for replies. */
+       client_set_trans_sign_state_on(cli, mid);
+
        if (this_ldata < ldata || this_lparam < lparam) {
                /* receive interim response */
                if (!cli_receive_smb(cli) || cli_is_error(cli)) {
+                       client_set_trans_sign_state_off(cli, mid);
                        return(False);
                }
 
@@ -141,6 +143,7 @@ BOOL cli_send_trans(struct cli_state *cli, int trans,
 
                        show_msg(cli->outbuf);
                        if (!cli_send_smb(cli)) {
+                               client_set_trans_sign_state_off(cli, mid);
                                return False;
                        }
 
@@ -152,10 +155,6 @@ BOOL cli_send_trans(struct cli_state *cli, int trans,
                }
        }
 
-       /* Note we're in a trans state. Save the sequence
-        * numbers for replies. */
-
-       cli_signing_trans_start(cli, mid);
        return(True);
 }
 
@@ -171,13 +170,11 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
        unsigned int total_param=0;
        unsigned int this_data,this_param;
        NTSTATUS status;
-       char *tdata;
-       char *tparam;
+       BOOL ret = False;
 
        *data_len = *param_len = 0;
 
        if (!cli_receive_smb(cli)) {
-               cli_signing_trans_stop(cli);
                return False;
        }
 
@@ -188,8 +185,7 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                DEBUG(0,("Expected %s response, got command 0x%02x\n",
                         trans==SMBtrans?"SMBtrans":"SMBtrans2", 
                         CVAL(cli->inbuf,smb_com)));
-               cli_signing_trans_stop(cli);
-               return(False);
+               return False;
        }
 
        /*
@@ -197,12 +193,22 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
         * to a trans call. This is not an error and should not
         * be treated as such. Note that STATUS_NO_MORE_FILES is
         * returned when a trans2 findfirst/next finishes.
+        * When setting up an encrypted transport we can also
+        * see NT_STATUS_MORE_PROCESSING_REQUIRED here.
+         *
+         * Vista returns NT_STATUS_INACCESSIBLE_SYSTEM_SHORTCUT if the folder
+         * "<share>/Users/All Users" is enumerated.  This is a special pseudo
+         * folder, and the response does not have parameters (nor a parameter
+         * length).
         */
        status = cli_nt_error(cli);
        
-       if (NT_STATUS_IS_ERR(status) || NT_STATUS_EQUAL(status,STATUS_NO_MORE_FILES)) {
-               cli_signing_trans_stop(cli);
-               return False;
+       if (!NT_STATUS_EQUAL(status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
+               if (NT_STATUS_IS_ERR(status) ||
+                    NT_STATUS_EQUAL(status,STATUS_NO_MORE_FILES) ||
+                    NT_STATUS_EQUAL(status,NT_STATUS_INACCESSIBLE_SYSTEM_SHORTCUT)) {
+                       goto out;
+               }
        }
 
        /* parse out the lengths */
@@ -211,25 +217,19 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
 
        /* allocate it */
        if (total_data!=0) {
-               tdata = SMB_REALLOC(*data,total_data);
-               if (!tdata) {
+               *data = (char *)SMB_REALLOC(*data,total_data);
+               if (!(*data)) {
                        DEBUG(0,("cli_receive_trans: failed to enlarge data buffer\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
-               else
-                       *data = tdata;
        }
 
        if (total_param!=0) {
-               tparam = SMB_REALLOC(*param,total_param);
-               if (!tparam) {
+               *param = (char *)SMB_REALLOC(*param,total_param);
+               if (!(*param)) {
                        DEBUG(0,("cli_receive_trans: failed to enlarge param buffer\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
-               else
-                       *param = tparam;
        }
 
        for (;;)  {
@@ -239,8 +239,7 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                if (this_data + *data_len > total_data ||
                    this_param + *param_len > total_param) {
                        DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                if (this_data + *data_len < this_data ||
@@ -248,8 +247,7 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                                this_param + *param_len < this_param ||
                                this_param + *param_len < *param_len) {
                        DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                if (this_data) {
@@ -261,16 +259,14 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                                        data_offset_out + this_data < data_offset_out ||
                                        data_offset_out + this_data < this_data) {
                                DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
                        if (data_offset_in > cli->bufsize ||
                                        data_offset_in + this_data >  cli->bufsize ||
                                        data_offset_in + this_data < data_offset_in ||
                                        data_offset_in + this_data < this_data) {
                                DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
 
                        memcpy(*data + data_offset_out, smb_base(cli->inbuf) + data_offset_in, this_data);
@@ -284,16 +280,14 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                                        param_offset_out + this_param < param_offset_out ||
                                        param_offset_out + this_param < this_param) {
                                DEBUG(1,("Param overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
                        if (param_offset_in > cli->bufsize ||
                                        param_offset_in + this_param >  cli->bufsize ||
                                        param_offset_in + this_param < param_offset_in ||
                                        param_offset_in + this_param < this_param) {
                                DEBUG(1,("Param overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
 
                        memcpy(*param + param_offset_out, smb_base(cli->inbuf) + param_offset_in, this_param);
@@ -301,12 +295,13 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                *data_len += this_data;
                *param_len += this_param;
 
-               if (total_data <= *data_len && total_param <= *param_len)
+               if (total_data <= *data_len && total_param <= *param_len) {
+                       ret = True;
                        break;
+               }
                
                if (!cli_receive_smb(cli)) {
-                       cli_signing_trans_stop(cli);
-                       return False;   
+                       goto out;
                }
 
                show_msg(cli->inbuf);
@@ -316,12 +311,12 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                        DEBUG(0,("Expected %s response, got command 0x%02x\n",
                                 trans==SMBtrans?"SMBtrans":"SMBtrans2", 
                                 CVAL(cli->inbuf,smb_com)));
-                       cli_signing_trans_stop(cli);
-                       return(False);
+                       goto out;
                }
-               if (NT_STATUS_IS_ERR(cli_nt_error(cli))) {
-                       cli_signing_trans_stop(cli);
-                       return(False);
+               if (!NT_STATUS_EQUAL(status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
+                       if (NT_STATUS_IS_ERR(cli_nt_error(cli))) {
+                               goto out;
+                       }
                }
 
                /* parse out the total lengths again - they can shrink! */
@@ -330,13 +325,16 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                if (SVAL(cli->inbuf,smb_tprcnt) < total_param)
                        total_param = SVAL(cli->inbuf,smb_tprcnt);
                
-               if (total_data <= *data_len && total_param <= *param_len)
+               if (total_data <= *data_len && total_param <= *param_len) {
+                       ret = True;
                        break;
-               
+               }
        }
-       
-       cli_signing_trans_stop(cli);
-       return(True);
+
+  out:
+
+       client_set_trans_sign_state_off(cli, SVAL(cli->inbuf,smb_mid));
+       return ret;
 }
 
 /****************************************************************************
@@ -403,9 +401,14 @@ BOOL cli_send_nt_trans(struct cli_state *cli,
                return False;
        }       
 
+       /* Note we're in a trans state. Save the sequence
+        * numbers for replies. */
+       client_set_trans_sign_state_on(cli, mid);
+
        if (this_ldata < ldata || this_lparam < lparam) {
                /* receive interim response */
                if (!cli_receive_smb(cli) || cli_is_error(cli)) {
+                       client_set_trans_sign_state_off(cli, mid);
                        return(False);
                }
 
@@ -447,6 +450,7 @@ BOOL cli_send_nt_trans(struct cli_state *cli,
                        show_msg(cli->outbuf);
 
                        if (!cli_send_smb(cli)) {
+                               client_set_trans_sign_state_off(cli, mid);
                                return False;
                        }
                        
@@ -458,16 +462,12 @@ BOOL cli_send_nt_trans(struct cli_state *cli,
                }
        }
 
-       /* Note we're in a trans state. Save the sequence
-        * numbers for replies. */
-
-       cli_signing_trans_start(cli, mid);
        return(True);
 }
 
 /****************************************************************************
-  receive a SMB nttrans response allocating the necessary memory
-  ****************************************************************************/
+ Receive a SMB nttrans response allocating the necessary memory.
+****************************************************************************/
 
 BOOL cli_receive_nt_trans(struct cli_state *cli,
                          char **param, unsigned int *param_len,
@@ -478,13 +478,11 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
        unsigned int this_data,this_param;
        uint8 eclass;
        uint32 ecode;
-       char *tdata;
-       char *tparam;
+       BOOL ret = False;
 
        *data_len = *param_len = 0;
 
        if (!cli_receive_smb(cli)) {
-               cli_signing_trans_stop(cli);
                return False;
        }
 
@@ -494,7 +492,6 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
        if (CVAL(cli->inbuf,smb_com) != SMBnttrans) {
                DEBUG(0,("Expected SMBnttrans response, got command 0x%02x\n",
                         CVAL(cli->inbuf,smb_com)));
-               cli_signing_trans_stop(cli);
                return(False);
        }
 
@@ -505,9 +502,8 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
         */
        if (cli_is_dos_error(cli)) {
                 cli_dos_error(cli, &eclass, &ecode);
-               if (cli->pipes[cli->pipe_idx].fnum == 0 || !(eclass == ERRDOS && ecode == ERRmoredata)) {
-                       cli_signing_trans_stop(cli);
-                       return(False);
+               if (!(eclass == ERRDOS && ecode == ERRmoredata)) {
+                       goto out;
                }
        }
 
@@ -517,8 +513,7 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
        if (cli_is_nt_error(cli)) {
                if (!NT_STATUS_EQUAL(cli_nt_error(cli),
                                     NT_STATUS_BUFFER_TOO_SMALL)) {
-                       cli_signing_trans_stop(cli);
-                       return(False);
+                       goto out;
                }
        }
 
@@ -528,24 +523,18 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
 
        /* allocate it */
        if (total_data) {
-               tdata = SMB_REALLOC(*data,total_data);
-               if (!tdata) {
+               *data = (char *)SMB_REALLOC(*data,total_data);
+               if (!(*data)) {
                        DEBUG(0,("cli_receive_nt_trans: failed to enlarge data buffer to %d\n",total_data));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               } else {
-                       *data = tdata;
+                       goto out;
                }
        }
 
        if (total_param) {
-               tparam = SMB_REALLOC(*param,total_param);
-               if (!tparam) {
+               *param = (char *)SMB_REALLOC(*param,total_param);
+               if (!(*param)) {
                        DEBUG(0,("cli_receive_nt_trans: failed to enlarge param buffer to %d\n", total_param));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               } else {
-                       *param = tparam;
+                       goto out;
                }
        }
 
@@ -556,8 +545,7 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                if (this_data + *data_len > total_data ||
                    this_param + *param_len > total_param) {
                        DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                if (this_data + *data_len < this_data ||
@@ -565,8 +553,7 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                                this_param + *param_len < this_param ||
                                this_param + *param_len < *param_len) {
                        DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                if (this_data) {
@@ -578,16 +565,14 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                                        data_offset_out + this_data < data_offset_out ||
                                        data_offset_out + this_data < this_data) {
                                DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
                        if (data_offset_in > cli->bufsize ||
                                        data_offset_in + this_data >  cli->bufsize ||
                                        data_offset_in + this_data < data_offset_in ||
                                        data_offset_in + this_data < this_data) {
                                DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
 
                        memcpy(*data + data_offset_out, smb_base(cli->inbuf) + data_offset_in, this_data);
@@ -602,16 +587,14 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                                        param_offset_out + this_param < param_offset_out ||
                                        param_offset_out + this_param < this_param) {
                                DEBUG(1,("Param overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
                        if (param_offset_in > cli->bufsize ||
                                        param_offset_in + this_param >  cli->bufsize ||
                                        param_offset_in + this_param < param_offset_in ||
                                        param_offset_in + this_param < this_param) {
                                DEBUG(1,("Param overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
 
                        memcpy(*param + param_offset_out, smb_base(cli->inbuf) + param_offset_in, this_param);
@@ -620,12 +603,13 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                *data_len += this_data;
                *param_len += this_param;
 
-               if (total_data <= *data_len && total_param <= *param_len)
+               if (total_data <= *data_len && total_param <= *param_len) {
+                       ret = True;
                        break;
+               }
                
                if (!cli_receive_smb(cli)) {
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                show_msg(cli->inbuf);
@@ -634,26 +618,38 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                if (CVAL(cli->inbuf,smb_com) != SMBnttrans) {
                        DEBUG(0,("Expected SMBnttrans response, got command 0x%02x\n",
                                 CVAL(cli->inbuf,smb_com)));
-                       cli_signing_trans_stop(cli);
-                       return(False);
+                       goto out;
                }
                if (cli_is_dos_error(cli)) {
                         cli_dos_error(cli, &eclass, &ecode);
-                       if(cli->pipes[cli->pipe_idx].fnum == 0 || !(eclass == ERRDOS && ecode == ERRmoredata)) {
-                               cli_signing_trans_stop(cli);
-                               return(False);
+                       if(!(eclass == ERRDOS && ecode == ERRmoredata)) {
+                               goto out;
+                       }
+               }
+               /*
+                * Likewise for NT_STATUS_BUFFER_TOO_SMALL
+                */
+               if (cli_is_nt_error(cli)) {
+                       if (!NT_STATUS_EQUAL(cli_nt_error(cli),
+                                            NT_STATUS_BUFFER_TOO_SMALL)) {
+                               goto out;
                        }
                }
+
                /* parse out the total lengths again - they can shrink! */
                if (SVAL(cli->inbuf,smb_ntr_TotalDataCount) < total_data)
                        total_data = SVAL(cli->inbuf,smb_ntr_TotalDataCount);
                if (SVAL(cli->inbuf,smb_ntr_TotalParameterCount) < total_param)
                        total_param = SVAL(cli->inbuf,smb_ntr_TotalParameterCount);
                
-               if (total_data <= *data_len && total_param <= *param_len)
+               if (total_data <= *data_len && total_param <= *param_len) {
+                       ret = True;
                        break;
+               }
        }
-       
-       cli_signing_trans_stop(cli);
-       return(True);
+
+  out:
+
+       client_set_trans_sign_state_off(cli, SVAL(cli->inbuf,smb_mid));
+       return ret;
 }