[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.
[samba.git] / source / passdb / secrets.c
index ebdf28c241aa421e055d5b55a442b33f1567e82e..771adb96e3dbf9c63751de8bf29d1bee86ed1448 100644 (file)
@@ -1,4 +1,4 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
    Copyright (C) Andrew Tridgell 1992-2001
    Copyright (C) Andrew Bartlett      2002
@@ -7,17 +7,16 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 /* the Samba secrets database stores any generated, private information
@@ -37,11 +36,11 @@ BOOL global_machine_password_needs_changing;
  * Use a TDB to store an incrementing random seed.
  *
  * Initialised to the current pid, the very first time Samba starts,
- * and incremented by one each time it is needed.  
- * 
+ * and incremented by one each time it is needed.
+ *
  * @note Not called by systems with a working /dev/urandom.
  */
-static void get_rand_seed(int *new_seed) 
+static void get_rand_seed(int *new_seed)
 {
        *new_seed = sys_getpid();
        if (tdb) {
@@ -69,8 +68,8 @@ BOOL secrets_init(void)
        }
 
        /**
-        * Set a reseed function for the crypto random generator 
-        * 
+        * Set a reseed function for the crypto random generator
+        *
         * This avoids a problem where systems without /dev/urandom
         * could send the same challenge to multiple clients
         */
@@ -97,7 +96,7 @@ void *secrets_fetch(const char *key, size_t *size)
        return dbuf.dptr;
 }
 
-/* store a secrets entry 
+/* store a secrets entry
  */
 BOOL secrets_store(const char *key, const void *data, size_t size)
 {
@@ -105,7 +104,7 @@ BOOL secrets_store(const char *key, const void *data, size_t size)
        if (!tdb)
                return False;
        return tdb_trans_store(tdb, string_tdb_data(key),
-                              make_tdb_data((const char *)data, size),
+                              make_tdb_data((const uint8 *)data, size),
                               TDB_REPLACE) == 0;
 }
 
@@ -148,7 +147,7 @@ BOOL secrets_fetch_domain_sid(const char *domain, DOM_SID *sid)
        if (dyn_sid == NULL)
                return False;
 
-       if (size != sizeof(DOM_SID)) { 
+       if (size != sizeof(DOM_SID)) {
                SAFE_FREE(dyn_sid);
                return False;
        }
@@ -190,7 +189,7 @@ BOOL secrets_fetch_domain_guid(const char *domain, struct GUID *guid)
                }
        }
 
-       if (size != sizeof(struct GUID)) { 
+       if (size != sizeof(struct GUID)) {
                DEBUG(1,("UUID size %d is wrong!\n", (int)size));
                SAFE_FREE(dyn_guid);
                return False;
@@ -212,7 +211,7 @@ static const char *trust_keystr(const char *domain)
 {
        static fstring keystr;
 
-       slprintf(keystr,sizeof(keystr)-1,"%s/%s", 
+       slprintf(keystr,sizeof(keystr)-1,"%s/%s",
                 SECRETS_MACHINE_ACCT_PASS, domain);
        strupper_m(keystr);
 
@@ -232,7 +231,7 @@ static char *trustdom_keystr(const char *domain)
 
        pstr_sprintf(keystr, "%s/%s", SECRETS_DOMTRUST_ACCT_PASS, domain);
        strupper_m(keystr);
-               
+
        return keystr;
 }
 
@@ -256,9 +255,9 @@ BOOL secrets_lock_trust_account_password(const char *domain, BOOL dolock)
  Routine to get the default secure channel type for trust accounts
 ************************************************************************/
 
-uint32 get_default_sec_channel(void) 
+uint32 get_default_sec_channel(void)
 {
-       if (lp_server_role() == ROLE_DOMAIN_BDC || 
+       if (lp_server_role() == ROLE_DOMAIN_BDC ||
            lp_server_role() == ROLE_DOMAIN_PDC) {
                return SEC_CHAN_BDC;
        } else {
@@ -280,7 +279,7 @@ BOOL secrets_fetch_trust_account_password(const char *domain, uint8 ret_pwd[16],
        char *plaintext;
        size_t size = 0;
 
-       plaintext = secrets_fetch_machine_password(domain, pass_last_set_time, 
+       plaintext = secrets_fetch_machine_password(domain, pass_last_set_time,
                                                   channel);
        if (plaintext) {
                DEBUG(4,("Using cleartext machine password\n"));
@@ -294,7 +293,7 @@ BOOL secrets_fetch_trust_account_password(const char *domain, uint8 ret_pwd[16],
                DEBUG(5, ("secrets_fetch failed!\n"));
                return False;
        }
-       
+
        if (size != sizeof(*pass)) {
                DEBUG(0, ("secrets were of incorrect size!\n"));
                return False;
@@ -330,26 +329,26 @@ BOOL secrets_fetch_trust_account_password(const char *domain, uint8 ret_pwd[16],
  *
  * @return length of the packed representation of the whole structure
  **/
-static size_t tdb_sid_pack(char* pack_buf, int bufsize, DOM_SID* sid)
+static size_t tdb_sid_pack(uint8 *pack_buf, int bufsize, DOM_SID* sid)
 {
        int idx;
        size_t len = 0;
-       
+
        if (!sid || !pack_buf) return -1;
-       
+
        len += tdb_pack(pack_buf + len, bufsize - len, "bb", sid->sid_rev_num,
                        sid->num_auths);
-       
+
        for (idx = 0; idx < 6; idx++) {
                len += tdb_pack(pack_buf + len, bufsize - len, "b",
                                sid->id_auth[idx]);
        }
-       
+
        for (idx = 0; idx < MAXSUBAUTHS; idx++) {
                len += tdb_pack(pack_buf + len, bufsize - len, "d",
                                sid->sub_auths[idx]);
        }
-       
+
        return len;
 }
 
@@ -362,25 +361,25 @@ static size_t tdb_sid_pack(char* pack_buf, int bufsize, DOM_SID* sid)
  *
  * @return size of structure unpacked from buffer
  **/
-static size_t tdb_sid_unpack(char* pack_buf, int bufsize, DOM_SID* sid)
+static size_t tdb_sid_unpack(uint8 *pack_buf, int bufsize, DOM_SID* sid)
 {
        int idx, len = 0;
-       
+
        if (!sid || !pack_buf) return -1;
 
        len += tdb_unpack(pack_buf + len, bufsize - len, "bb",
                          &sid->sid_rev_num, &sid->num_auths);
-                         
+
        for (idx = 0; idx < 6; idx++) {
                len += tdb_unpack(pack_buf + len, bufsize - len, "b",
                                  &sid->id_auth[idx]);
        }
-       
+
        for (idx = 0; idx < MAXSUBAUTHS; idx++) {
                len += tdb_unpack(pack_buf + len, bufsize - len, "d",
                                  &sid->sub_auths[idx]);
        }
-       
+
        return len;
 }
 
@@ -393,21 +392,21 @@ static size_t tdb_sid_unpack(char* pack_buf, int bufsize, DOM_SID* sid)
  *
  * @return length of the packed representation of the whole structure
  **/
-static size_t tdb_trusted_dom_pass_pack(char* pack_buf, int bufsize,
+static size_t tdb_trusted_dom_pass_pack(uint8 *pack_buf, int bufsize,
                                        TRUSTED_DOM_PASS* pass)
 {
        int idx, len = 0;
-       
+
        if (!pack_buf || !pass) return -1;
-       
+
        /* packing unicode domain name and password */
        len += tdb_pack(pack_buf + len, bufsize - len, "d",
                        pass->uni_name_len);
-       
+
        for (idx = 0; idx < 32; idx++)
                len +=  tdb_pack(pack_buf + len, bufsize - len, "w",
                                 pass->uni_name[idx]);
-       
+
        len += tdb_pack(pack_buf + len, bufsize - len, "dPd", pass->pass_len,
                             pass->pass, pass->mod_time);
 
@@ -427,28 +426,28 @@ static size_t tdb_trusted_dom_pass_pack(char* pack_buf, int bufsize,
  *
  * @return size of structure unpacked from buffer
  **/
-static size_t tdb_trusted_dom_pass_unpack(char* pack_buf, int bufsize,
+static size_t tdb_trusted_dom_pass_unpack(uint8 *pack_buf, int bufsize,
                                          TRUSTED_DOM_PASS* pass)
 {
        int idx, len = 0;
-       
+
        if (!pack_buf || !pass) return -1;
 
        /* unpack unicode domain name and plaintext password */
        len += tdb_unpack(pack_buf, bufsize - len, "d", &pass->uni_name_len);
-       
+
        for (idx = 0; idx < 32; idx++)
                len +=  tdb_unpack(pack_buf + len, bufsize - len, "w",
                                   &pass->uni_name[idx]);
 
        len += tdb_unpack(pack_buf + len, bufsize - len, "dPd",
                          &pass->pass_len, &pass->pass, &pass->mod_time);
-       
+
        /* unpack domain sid */
        len += tdb_sid_unpack(pack_buf + len, bufsize - len,
                              &pass->domain_sid);
-       
-       return len;     
+
+       return len;
 }
 
 /************************************************************************
@@ -460,15 +459,15 @@ BOOL secrets_fetch_trusted_domain_password(const char *domain, char** pwd,
 {
        struct trusted_dom_pass pass;
        size_t size = 0;
-       
+
        /* unpacking structures */
-       char* pass_buf;
+       uint8 *pass_buf;
        int pass_len = 0;
 
        ZERO_STRUCT(pass);
 
        /* fetching trusted domain password structure */
-       if (!(pass_buf = (char *)secrets_fetch(trustdom_keystr(domain),
+       if (!(pass_buf = (uint8 *)secrets_fetch(trustdom_keystr(domain),
                                               &size))) {
                DEBUG(5, ("secrets_fetch failed!\n"));
                return False;
@@ -482,8 +481,8 @@ BOOL secrets_fetch_trusted_domain_password(const char *domain, char** pwd,
                DEBUG(5, ("Invalid secrets size. Unpacked data doesn't match trusted_dom_pass structure.\n"));
                return False;
        }
-                       
-       /* the trust's password */      
+
+       /* the trust's password */
        if (pwd) {
                *pwd = SMB_STRDUP(pass.pass);
                if (!*pwd) {
@@ -496,10 +495,24 @@ BOOL secrets_fetch_trusted_domain_password(const char *domain, char** pwd,
 
        /* domain sid */
        if (sid != NULL) sid_copy(sid, &pass.domain_sid);
-               
+
        return True;
 }
 
+/************************************************************************
+ Routine to set the trust account password for a domain.
+************************************************************************/
+
+BOOL secrets_store_trust_account_password(const char *domain, uint8 new_pwd[16])
+{
+       struct machine_acct_pass pass;
+
+       pass.mod_time = time(NULL);
+       memcpy(pass.hash, new_pwd, 16);
+
+       return secrets_store(trust_keystr(domain), (void *)&pass, sizeof(pass));
+}
+
 /**
  * Routine to store the password for trusted domain
  *
@@ -519,7 +532,7 @@ BOOL secrets_store_trusted_domain_password(const char* domain, const char* pwd,
        pstring pass_buf;
        int pass_len = 0;
        int pass_buf_len = sizeof(pass_buf);
-       
+
        struct trusted_dom_pass pass;
        ZERO_STRUCT(pass);
 
@@ -528,7 +541,7 @@ BOOL secrets_store_trusted_domain_password(const char* domain, const char* pwd,
                          domain));
                return False;
        }
-       
+
        strncpy_w(pass.uni_name, uni_dom_name, sizeof(pass.uni_name) - 1);
        pass.uni_name_len = strlen_w(uni_dom_name)+1;
        SAFE_FREE(uni_dom_name);
@@ -542,8 +555,8 @@ BOOL secrets_store_trusted_domain_password(const char* domain, const char* pwd,
 
        /* domain sid */
        sid_copy(&pass.domain_sid, sid);
-       
-       pass_len = tdb_trusted_dom_pass_pack(pass_buf, pass_buf_len, &pass);
+
+       pass_len = tdb_trusted_dom_pass_pack((uint8 *)pass_buf, pass_buf_len, &pass);
 
        return secrets_store(trustdom_keystr(domain), (void *)&pass_buf, pass_len);
 }
@@ -556,78 +569,40 @@ the password is assumed to be a null terminated ascii string
 BOOL secrets_store_machine_password(const char *pass, const char *domain, uint32 sec_channel)
 {
        char *key = NULL;
-       BOOL ret = False;
+       BOOL ret;
        uint32 last_change_time;
        uint32 sec_channel_type;
 
-       if (tdb_transaction_start(tdb) == -1) {
-               DEBUG(5, ("tdb_transaction_start failed: %s\n",
-                         tdb_errorstr(tdb)));
+       asprintf(&key, "%s/%s", SECRETS_MACHINE_PASSWORD, domain);
+       if (!key)
                return False;
-       }
-
-       if (asprintf(&key, "%s/%s", SECRETS_MACHINE_PASSWORD, domain) == -1) {
-               DEBUG(5, ("asprintf failed\n"));
-               goto fail;
-       }
        strupper_m(key);
 
        ret = secrets_store(key, pass, strlen(pass)+1);
        SAFE_FREE(key);
 
-       if (!ret) {
-               DEBUG(5, ("secrets_store failed: %s\n",
-                         tdb_errorstr(tdb)));
-               goto fail;
-       }
-       
-       if (asprintf(&key, "%s/%s", SECRETS_MACHINE_LAST_CHANGE_TIME,
-                    domain) == -1) {
-               DEBUG(5, ("asprintf failed\n"));
-               goto fail;
-       }
+       if (!ret)
+               return ret;
+
+       asprintf(&key, "%s/%s", SECRETS_MACHINE_LAST_CHANGE_TIME, domain);
+       if (!key)
+               return False;
        strupper_m(key);
 
        SIVAL(&last_change_time, 0, time(NULL));
        ret = secrets_store(key, &last_change_time, sizeof(last_change_time));
        SAFE_FREE(key);
 
-       if (!ret) {
-               DEBUG(5, ("secrets_store failed: %s\n",
-                         tdb_errorstr(tdb)));
-               goto fail;
-       }
-       
-       if (asprintf(&key, "%s/%s", SECRETS_MACHINE_SEC_CHANNEL_TYPE,
-                    domain) == -1) {
-               DEBUG(5, ("asprintf failed\n"));
-               goto fail;
-       }
+       asprintf(&key, "%s/%s", SECRETS_MACHINE_SEC_CHANNEL_TYPE, domain);
+       if (!key)
+               return False;
        strupper_m(key);
 
        SIVAL(&sec_channel_type, 0, sec_channel);
        ret = secrets_store(key, &sec_channel_type, sizeof(sec_channel_type));
        SAFE_FREE(key);
 
-       if (!ret) {
-               DEBUG(5, ("secrets_store failed: %s\n",
-                         tdb_errorstr(tdb)));
-               goto fail;
-       }
-
-       if (tdb_transaction_commit(tdb) != 0) {
-               DEBUG(5, ("tdb_transaction_commit failed: %s\n",
-                         tdb_errorstr(tdb)));
-               return False;
-       }
-
-       return True;
-
- fail:
-       if (tdb_transaction_cancel(tdb) != 0) {
-               smb_panic("tdb_transaction_cancel failed!\n");
-       }
-       return False;
+       return ret;
 }
 
 /************************************************************************
@@ -635,7 +610,7 @@ BOOL secrets_store_machine_password(const char *pass, const char *domain, uint32
  the password is assumed to be a null terminated ascii string.
 ************************************************************************/
 
-char *secrets_fetch_machine_password(const char *domain, 
+char *secrets_fetch_machine_password(const char *domain,
                                     time_t *pass_last_set_time,
                                     uint32 *channel)
 {
@@ -645,7 +620,7 @@ char *secrets_fetch_machine_password(const char *domain,
        strupper_m(key);
        ret = (char *)secrets_fetch(key, NULL);
        SAFE_FREE(key);
-       
+
        if (pass_last_set_time) {
                size_t size;
                uint32 *last_set_time;
@@ -660,7 +635,7 @@ char *secrets_fetch_machine_password(const char *domain,
                }
                SAFE_FREE(key);
        }
-       
+
        if (channel) {
                size_t size;
                uint32 *channel_type;
@@ -675,10 +650,19 @@ char *secrets_fetch_machine_password(const char *domain,
                }
                SAFE_FREE(key);
        }
-       
+
        return ret;
 }
 
+/************************************************************************
+ Routine to delete the machine trust account password file for a domain.
+************************************************************************/
+
+BOOL trust_password_delete(const char *domain)
+{
+       return secrets_delete(trust_keystr(domain));
+}
+
 /************************************************************************
  Routine to delete the password for trusted domain
 ************************************************************************/
@@ -692,14 +676,14 @@ BOOL secrets_store_ldap_pw(const char* dn, char* pw)
 {
        char *key = NULL;
        BOOL ret;
-       
+
        if (asprintf(&key, "%s/%s", SECRETS_LDAP_BIND_PW, dn) < 0) {
                DEBUG(0, ("secrets_store_ldap_pw: asprintf failed!\n"));
                return False;
        }
-               
+
        ret = secrets_store(key, pw, strlen(pw)+1);
-       
+
        SAFE_FREE(key);
        return ret;
 }
@@ -712,14 +696,14 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
 {
        char *key = NULL;
        size_t size = 0;
-       
+
        *dn = smb_xstrdup(lp_ldap_admin_dn());
-       
+
        if (asprintf(&key, "%s/%s", SECRETS_LDAP_BIND_PW, *dn) < 0) {
                SAFE_FREE(*dn);
                DEBUG(0, ("fetch_ldap_pw: asprintf failed!\n"));
        }
-       
+
        *pw=(char *)secrets_fetch(key, &size);
        SAFE_FREE(key);
 
@@ -729,7 +713,7 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
                char* old_style_key = SMB_STRDUP(*dn);
                char *data;
                fstring old_style_pw;
-               
+
                if (!old_style_key) {
                        DEBUG(0, ("fetch_ldap_pw: strdup failed!\n"));
                        return False;
@@ -737,7 +721,7 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
 
                for (p=old_style_key; *p; p++)
                        if (*p == ',') *p = '/';
-       
+
                data=(char *)secrets_fetch(old_style_key, &size);
                if (!size && size < sizeof(old_style_pw)) {
                        DEBUG(0,("fetch_ldap_pw: neither ldap secret retrieved!\n"));
@@ -756,7 +740,7 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
                        DEBUG(0,("fetch_ldap_pw: ldap secret could not be upgraded!\n"));
                        SAFE_FREE(old_style_key);
                        SAFE_FREE(*dn);
-                       return False;                   
+                       return False;
                }
                if (!secrets_delete(old_style_key)) {
                        DEBUG(0,("fetch_ldap_pw: old ldap secret could not be deleted!\n"));
@@ -764,15 +748,15 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
 
                SAFE_FREE(old_style_key);
 
-               *pw = smb_xstrdup(old_style_pw);                
+               *pw = smb_xstrdup(old_style_pw);
        }
-       
+
        return True;
 }
 
 /**
  * Get trusted domains info from secrets.tdb.
- **/ 
+ **/
 
 NTSTATUS secrets_trusted_domains(TALLOC_CTX *mem_ctx, uint32 *num_domains,
                                 struct trustdom_info ***domains)
@@ -786,7 +770,7 @@ NTSTATUS secrets_trusted_domains(TALLOC_CTX *mem_ctx, uint32 *num_domains,
        }
 
        if (!secrets_init()) return NT_STATUS_ACCESS_DENIED;
-       
+
        /* generate searching pattern */
        pattern = talloc_asprintf(tmp_ctx, "%s/*", SECRETS_DOMTRUST_ACCT_PASS);
        if (pattern == NULL) {
@@ -813,15 +797,15 @@ NTSTATUS secrets_trusted_domains(TALLOC_CTX *mem_ctx, uint32 *num_domains,
 
        /* searching for keys in secrets db -- way to go ... */
        for (k = keys; k; k = k->next) {
-               char *packed_pass;
+               uint8 *packed_pass;
                size_t size = 0, packed_size = 0;
                struct trusted_dom_pass pass;
                char *secrets_key;
                struct trustdom_info *dom_info;
-               
+
                /* important: ensure null-termination of the key string */
                secrets_key = talloc_strndup(tmp_ctx,
-                                            k->node_key.dptr,
+                                            (const char *)k->node_key.dptr,
                                             k->node_key.dsize);
                if (!secrets_key) {
                        DEBUG(0, ("strndup failed!\n"));
@@ -830,12 +814,12 @@ NTSTATUS secrets_trusted_domains(TALLOC_CTX *mem_ctx, uint32 *num_domains,
                        return NT_STATUS_NO_MEMORY;
                }
 
-               packed_pass = (char *)secrets_fetch(secrets_key, &size);
+               packed_pass = (uint8 *)secrets_fetch(secrets_key, &size);
                packed_size = tdb_trusted_dom_pass_unpack(packed_pass, size,
                                                          &pass);
                /* packed representation isn't needed anymore */
                SAFE_FREE(packed_pass);
-               
+
                if (size != packed_size) {
                        DEBUG(2, ("Secrets record %s is invalid!\n",
                                  secrets_key));
@@ -876,7 +860,7 @@ NTSTATUS secrets_trusted_domains(TALLOC_CTX *mem_ctx, uint32 *num_domains,
                        return NT_STATUS_NO_MEMORY;
                }
        }
-       
+
        DEBUG(5, ("secrets_get_trusted_domains: got %d domains\n",
                  *num_domains));
 
@@ -972,7 +956,7 @@ BOOL secrets_fetch_afs_key(const char *cell, struct afs_key *result)
 
 /******************************************************************************
   When kerberos is not available, choose between anonymous or
-  authenticated connections.  
+  authenticated connections.
 
   We need to use an authenticated connection if DCs have the
   RestrictAnonymous registry entry set > 0, or the "Additional
@@ -986,16 +970,16 @@ void secrets_fetch_ipc_userpass(char **username, char **domain, char **password)
        *username = (char *)secrets_fetch(SECRETS_AUTH_USER, NULL);
        *domain = (char *)secrets_fetch(SECRETS_AUTH_DOMAIN, NULL);
        *password = (char *)secrets_fetch(SECRETS_AUTH_PASSWORD, NULL);
-       
+
        if (*username && **username) {
 
                if (!*domain || !**domain)
                        *domain = smb_xstrdup(lp_workgroup());
-               
+
                if (!*password || !**password)
                        *password = smb_xstrdup("");
 
-               DEBUG(3, ("IPC$ connections done by user %s\\%s\n", 
+               DEBUG(3, ("IPC$ connections done by user %s\\%s\n",
                          *domain, *username));
 
        } else {
@@ -1033,7 +1017,7 @@ static TDB_CONTEXT *open_schannel_session_store(TALLOC_CTX *mem_ctx)
        if (vers.dptr == NULL) {
                /* First opener, no version. */
                SIVAL(&ver,0,1);
-               vers.dptr = (char *)&ver;
+               vers.dptr = (uint8 *)&ver;
                vers.dsize = 4;
                tdb_store_bystring(tdb_sc, "SCHANNEL_STORE_VERSION", vers, TDB_REPLACE);
                vers.dptr = NULL;
@@ -1090,7 +1074,7 @@ BOOL secrets_store_schannel_session_info(TALLOC_CTX *mem_ctx,
                                pdc->remote_machine,
                                pdc->domain);
 
-       value.dptr = (char *)TALLOC(mem_ctx, value.dsize);
+       value.dptr = TALLOC_ARRAY(mem_ctx, uint8, value.dsize);
        if (!value.dptr) {
                TALLOC_FREE(keystr);
                return False;
@@ -1231,14 +1215,14 @@ BOOL secrets_store_generic(const char *owner, const char *key, const char *secre
 {
        char *tdbkey = NULL;
        BOOL ret;
-       
+
        if (asprintf(&tdbkey, "SECRETS/GENERIC/%s/%s", owner, key) < 0) {
                DEBUG(0, ("asprintf failed!\n"));
                return False;
        }
-               
+
        ret = secrets_store(tdbkey, secret, strlen(secret)+1);
-       
+
        SAFE_FREE(tdbkey);
        return ret;
 }
@@ -1261,7 +1245,7 @@ char *secrets_fetch_generic(const char *owner, const char *key)
                DEBUG(0, ("Out of memory!\n"));
                return NULL;
        }
-       
+
        secret = (char *)secrets_fetch(tdbkey, NULL);
        SAFE_FREE(tdbkey);