[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.
[samba.git] / source / rpc_parse / parse_lsa.c
index b7c0fa3814f85f188e0c426663af53d0f3d41d28..15d7d80c039dedf68c3faaacb69a23eec110622d 100644 (file)
@@ -10,7 +10,7 @@
  *  
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
+ *  the Free Software Foundation; either version 3 of the License, or
  *  (at your option) any later version.
  *  
  *  This program is distributed in the hope that it will be useful,
@@ -19,8 +19,7 @@
  *  GNU General Public License for more details.
  *  
  *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *  along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "includes.h"
@@ -573,14 +572,17 @@ void init_r_enum_trust_dom(TALLOC_CTX *ctx, LSA_R_ENUM_TRUST_DOM *out,
                        return;
                }
 
-               out->domlist->domains = TALLOC_ARRAY( ctx, DOMAIN_INFO,
+               if (out->count) {
+                       out->domlist->domains = TALLOC_ARRAY( ctx, DOMAIN_INFO,
                                                      out->count );
-               
-               if ( !out->domlist->domains ) {
-                       out->status = NT_STATUS_NO_MEMORY;
-                       return;
+                       if ( !out->domlist->domains ) {
+                               out->status = NT_STATUS_NO_MEMORY;
+                               return;
+                       }
+               } else {                
+                       out->domlist->domains = NULL;
                }
-               
+       
                out->domlist->count = out->count;
                
                /* initialize the list of domains and their sid */
@@ -595,7 +597,7 @@ void init_r_enum_trust_dom(TALLOC_CTX *ctx, LSA_R_ENUM_TRUST_DOM *out,
                                
                        init_dom_sid2(out->domlist->domains[i].sid,
                                      &(td[i])->sid);
-                       if (push_ucs2_talloc(ctx, &name, (td[i])->name) < 0){
+                       if (push_ucs2_talloc(ctx, &name, (td[i])->name) == (size_t)-1){
                                out->status = NT_STATUS_NO_MEMORY;
                                return;
                        }
@@ -664,7 +666,7 @@ BOOL lsa_io_r_enum_trust_dom(const char *desc, LSA_R_ENUM_TRUST_DOM *out,
        if(!prs_uint32("count", ps, depth, &out->count))
                return False;
 
-       if ( !prs_pointer("trusted_domains", ps, depth, (void**)&out->domlist, sizeof(DOMAIN_LIST), (PRS_POINTER_CAST)lsa_io_domain_list))
+       if ( !prs_pointer("trusted_domains", ps, depth, (void*)&out->domlist, sizeof(DOMAIN_LIST), (PRS_POINTER_CAST)lsa_io_domain_list))
                return False;
                
        if(!prs_ntstatus("status", ps, depth, &out->status))
@@ -673,16 +675,97 @@ BOOL lsa_io_r_enum_trust_dom(const char *desc, LSA_R_ENUM_TRUST_DOM *out,
        return True;
 }
 
+/*******************************************************************
+reads or writes a structure.
+********************************************************************/
+
+static BOOL lsa_io_dom_query_1(const char *desc, DOM_QUERY_1 *d_q, prs_struct *ps, int depth)
+{
+       if (d_q == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "lsa_io_dom_query_1");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_uint32("percent_full", ps, depth, &d_q->percent_full))
+               return False;
+       if (!prs_uint32("log_size", ps, depth, &d_q->log_size))
+               return False;
+       if (!smb_io_nttime("retention_time", ps, depth, &d_q->retention_time))
+               return False;
+       if (!prs_uint8("shutdown_in_progress", ps, depth, &d_q->shutdown_in_progress))
+               return False;
+       if (!smb_io_nttime("time_to_shutdown", ps, depth, &d_q->time_to_shutdown))
+               return False;
+       if (!prs_uint32("next_audit_record", ps, depth, &d_q->next_audit_record))
+               return False;
+       if (!prs_uint32("unknown", ps, depth, &d_q->unknown))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+reads or writes a structure.
+********************************************************************/
+
+static BOOL lsa_io_dom_query_2(const char *desc, DOM_QUERY_2 *d_q, prs_struct *ps, int depth)
+{
+       if (d_q == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "lsa_io_dom_query_2");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_uint32("auditing_enabled", ps, depth, &d_q->auditing_enabled))
+               return False;
+       if (!prs_uint32("ptr   ", ps, depth, &d_q->ptr))
+               return False;
+       if (!prs_uint32("count1", ps, depth, &d_q->count1))
+               return False;
+
+       if (d_q->ptr) {
+
+               if (!prs_uint32("count2", ps, depth, &d_q->count2))
+                       return False;
+
+               if (d_q->count1 != d_q->count2)
+                       return False;
+
+               if (UNMARSHALLING(ps)) {
+                       if (d_q->count2) {
+                               d_q->auditsettings = TALLOC_ZERO_ARRAY(ps->mem_ctx, uint32, d_q->count2);
+                               if (!d_q->auditsettings) {
+                                       return False;
+                               }
+                       } else {
+                               d_q->auditsettings = NULL;
+                       }
+               }
+
+               if (!prs_uint32s(False, "auditsettings", ps, depth, d_q->auditsettings, d_q->count2))
+                       return False;
+       }
+
+       return True;
+}
+
 /*******************************************************************
 reads or writes a dom query structure.
 ********************************************************************/
 
-static BOOL lsa_io_dom_query(const char *desc, DOM_QUERY *d_q, prs_struct *ps, int depth)
+static BOOL lsa_io_dom_query_3(const char *desc, DOM_QUERY_3 *d_q, prs_struct *ps, int depth)
 {
        if (d_q == NULL)
                return False;
 
-       prs_debug(ps, depth, desc, "lsa_io_dom_query");
+       prs_debug(ps, depth, desc, "lsa_io_dom_query_3");
        depth++;
 
        if(!prs_align(ps))
@@ -715,78 +798,237 @@ static BOOL lsa_io_dom_query(const char *desc, DOM_QUERY *d_q, prs_struct *ps, i
 }
 
 /*******************************************************************
-reads or writes a structure.
+ Reads or writes a dom query structure.
 ********************************************************************/
 
-static BOOL lsa_io_dom_query_2(const char *desc, DOM_QUERY_2 *d_q, prs_struct *ps, int depth)
+static BOOL lsa_io_dom_query_5(const char *desc, DOM_QUERY_5 *d_q, prs_struct *ps, int depth)
 {
-       uint32 ptr = 1;
+       return lsa_io_dom_query_3("", d_q, ps, depth);
+}
+
+/*******************************************************************
+ Reads or writes a dom query structure.
+********************************************************************/
 
+static BOOL lsa_io_dom_query_6(const char *desc, DOM_QUERY_6 *d_q, prs_struct *ps, int depth)
+{
        if (d_q == NULL)
                return False;
 
-       prs_debug(ps, depth, desc, "lsa_io_dom_query_2");
+       prs_debug(ps, depth, desc, "lsa_io_dom_query_6");
        depth++;
 
-       if (!prs_align(ps))
+       if (!prs_uint16("server_role", ps, depth, &d_q->server_role))
                return False;
 
-       if (!prs_uint32("auditing_enabled", ps, depth, &d_q->auditing_enabled))
+       return True;
+}
+
+/*******************************************************************
+ Reads or writes a dom query structure.
+********************************************************************/
+
+static BOOL lsa_io_dom_query_10(const char *desc, DOM_QUERY_10 *d_q, prs_struct *ps, int depth)
+{
+       if (d_q == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "lsa_io_dom_query_10");
+       depth++;
+
+       if (!prs_uint8("shutdown_on_full", ps, depth, &d_q->shutdown_on_full))
                return False;
-       if (!prs_uint32("ptr   ", ps, depth, &ptr))
+
+       return True;
+}
+
+/*******************************************************************
+ Reads or writes a dom query structure.
+********************************************************************/
+
+static BOOL lsa_io_dom_query_11(const char *desc, DOM_QUERY_11 *d_q, prs_struct *ps, int depth)
+{
+       if (d_q == NULL)
                return False;
-       if (!prs_uint32("count1", ps, depth, &d_q->count1))
+
+       prs_debug(ps, depth, desc, "lsa_io_dom_query_11");
+       depth++;
+
+       if (!prs_uint16("unknown", ps, depth, &d_q->unknown))
+               return False;
+       if (!prs_uint8("shutdown_on_full", ps, depth, &d_q->shutdown_on_full))
                return False;
-       if (!prs_uint32("count2", ps, depth, &d_q->count2))
+       if (!prs_uint8("log_is_full", ps, depth, &d_q->log_is_full))
                return False;
 
-       if (UNMARSHALLING(ps)) {
-               d_q->auditsettings = TALLOC_ZERO_ARRAY(ps->mem_ctx, uint32, d_q->count2);
-       }
+       return True;
+}
+
+/*******************************************************************
+ Reads or writes an LSA_DNS_DOM_INFO structure.
+********************************************************************/
+
+BOOL lsa_io_dom_query_12(const char *desc, DOM_QUERY_12 *info, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "lsa_io_dom_query_12");
+       depth++;
 
-       if (d_q->auditsettings == NULL) {
-               DEBUG(1, ("lsa_io_dom_query_2: NULL auditsettings!\n"));
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_unihdr("nb_name", &info->hdr_nb_dom_name, ps, depth))
+               return False;
+       if(!smb_io_unihdr("dns_name", &info->hdr_dns_dom_name, ps, depth))
+               return False;
+       if(!smb_io_unihdr("forest", &info->hdr_forest_name, ps, depth))
                return False;
-       }
 
-       if (!prs_uint32s(False, "auditsettings", ps, depth, d_q->auditsettings, d_q->count2))
+       if(!prs_align(ps))
+               return False;
+       if ( !smb_io_uuid("dom_guid", &info->dom_guid, ps, depth) )
                return False;
 
-    return True;
+       if(!prs_align(ps))
+               return False;
+       if(!prs_uint32("dom_sid", ps, depth, &info->ptr_dom_sid))
+               return False;
+
+       if(!smb_io_unistr2("nb_name", &info->uni_nb_dom_name,
+                          info->hdr_nb_dom_name.buffer, ps, depth))
+               return False;
+       if(!smb_io_unistr2("dns_name", &info->uni_dns_dom_name, 
+                          info->hdr_dns_dom_name.buffer, ps, depth))
+               return False;
+       if(!smb_io_unistr2("forest", &info->uni_forest_name, 
+                          info->hdr_forest_name.buffer, ps, depth))
+               return False;
+
+       if(!smb_io_dom_sid2("dom_sid", &info->dom_sid, ps, depth))
+               return False;
+
+       return True;
+       
 }
 
 /*******************************************************************
Reads or writes a dom query structure.
Inits an LSA_Q_QUERY_INFO structure.
 ********************************************************************/
 
-static BOOL lsa_io_dom_query_3(const char *desc, DOM_QUERY_3 *d_q, prs_struct *ps, int depth)
+void init_q_set(LSA_Q_SET_INFO *in, POLICY_HND *hnd, uint16 info_class, LSA_INFO_CTR ctr)
 {
-       return lsa_io_dom_query("", d_q, ps, depth);
+       DEBUG(5,("init_q_set\n"));
+
+       in->info_class = info_class;
+
+       in->pol = *hnd;
+
+       in->ctr = ctr;
+       in->ctr.info_class = info_class;
 }
 
 /*******************************************************************
- Reads or writes a dom query structure.
+reads or writes a structure.
 ********************************************************************/
 
-static BOOL lsa_io_dom_query_5(const char *desc, DOM_QUERY_5 *d_q, prs_struct *ps, int depth)
+static BOOL lsa_io_query_info_ctr2(const char *desc, prs_struct *ps, int depth, LSA_INFO_CTR2 *ctr)
 {
-       return lsa_io_dom_query("", d_q, ps, depth);
+       prs_debug(ps, depth, desc, "lsa_io_query_info_ctr2");
+       depth++;
+
+       if(!prs_uint16("info_class", ps, depth, &ctr->info_class))
+               return False;
+
+       switch (ctr->info_class) {
+       case 1:
+               if(!lsa_io_dom_query_1("", &ctr->info.id1, ps, depth))
+                       return False;
+               break;
+       case 2:
+               if(!lsa_io_dom_query_2("", &ctr->info.id2, ps, depth))
+                       return False;
+               break;
+       case 3:
+               if(!lsa_io_dom_query_3("", &ctr->info.id3, ps, depth))
+                       return False;
+               break;
+       case 5:
+               if(!lsa_io_dom_query_5("", &ctr->info.id5, ps, depth))
+                       return False;
+               break;
+       case 6:
+               if(!lsa_io_dom_query_6("", &ctr->info.id6, ps, depth))
+                       return False;
+               break;
+       case 10:
+               if(!lsa_io_dom_query_10("", &ctr->info.id10, ps, depth))
+                       return False;
+               break;
+       case 11:
+               if(!lsa_io_dom_query_11("", &ctr->info.id11, ps, depth))
+                       return False;
+               break;
+       case 12:
+               if(!lsa_io_dom_query_12("", &ctr->info.id12, ps, depth))
+                       return False;
+               break;
+       default:
+               DEBUG(0,("invalid info_class: %d\n", ctr->info_class));
+               return False;
+               break;
+       }
+
+       return True;
 }
 
+
 /*******************************************************************
- Reads or writes a dom query structure.
+reads or writes a structure.
 ********************************************************************/
 
-static BOOL lsa_io_dom_query_6(const char *desc, DOM_QUERY_6 *d_q, prs_struct *ps, int depth)
+static BOOL lsa_io_query_info_ctr(const char *desc, prs_struct *ps, int depth, LSA_INFO_CTR *ctr)
 {
-       if (d_q == NULL)
+       prs_debug(ps, depth, desc, "lsa_io_query_info_ctr");
+       depth++;
+
+       if(!prs_uint16("info_class", ps, depth, &ctr->info_class))
                return False;
 
-       prs_debug(ps, depth, desc, "lsa_io_dom_query_6");
-       depth++;
+       if(!prs_align(ps))
+               return False;
 
-       if (!prs_uint16("server_role", ps, depth, &d_q->server_role))
+       switch (ctr->info_class) {
+       case 1:
+               if(!lsa_io_dom_query_1("", &ctr->info.id1, ps, depth))
+                       return False;
+               break;
+       case 2:
+               if(!lsa_io_dom_query_2("", &ctr->info.id2, ps, depth))
+                       return False;
+               break;
+       case 3:
+               if(!lsa_io_dom_query_3("", &ctr->info.id3, ps, depth))
+                       return False;
+               break;
+       case 5:
+               if(!lsa_io_dom_query_5("", &ctr->info.id5, ps, depth))
+                       return False;
+               break;
+       case 6:
+               if(!lsa_io_dom_query_6("", &ctr->info.id6, ps, depth))
+                       return False;
+               break;
+       case 10:
+               if(!lsa_io_dom_query_10("", &ctr->info.id10, ps, depth))
+                       return False;
+               break;
+       case 11:
+               if(!lsa_io_dom_query_11("", &ctr->info.id11, ps, depth))
+                       return False;
+               break;
+       default:
+               DEBUG(0,("invalid info_class: %d\n", ctr->info_class));
                return False;
+               break;
+       }
 
        return True;
 }
@@ -797,40 +1039,20 @@ static BOOL lsa_io_dom_query_6(const char *desc, DOM_QUERY_6 *d_q, prs_struct *p
 
 BOOL lsa_io_r_query(const char *desc, LSA_R_QUERY_INFO *out, prs_struct *ps, int depth)
 {
+
        prs_debug(ps, depth, desc, "lsa_io_r_query");
        depth++;
 
-       if(!prs_uint32("undoc_buffer", ps, depth, &out->undoc_buffer))
+       if(!prs_align(ps))
                return False;
 
-       if (out->undoc_buffer != 0) {
-               if(!prs_uint16("info_class", ps, depth, &out->info_class))
-                       return False;
+       if(!prs_uint32("dom_ptr", ps, depth, &out->dom_ptr))
+               return False;
 
-               if(!prs_align(ps))
-                       return False;
+       if (out->dom_ptr) {
 
-               switch (out->info_class) {
-               case 2:
-                       if(!lsa_io_dom_query_2("", &out->dom.id2, ps, depth))
-                               return False;
-                       break;
-               case 3:
-                       if(!lsa_io_dom_query_3("", &out->dom.id3, ps, depth))
-                               return False;
-                       break;
-               case 5:
-                       if(!lsa_io_dom_query_5("", &out->dom.id5, ps, depth))
-                               return False;
-                       break;
-               case 6:
-                       if(!lsa_io_dom_query_6("", &out->dom.id6, ps, depth))
-                               return False;
-                       break;
-               default:
-                       /* PANIC! */
-                       break;
-               }
+               if(!lsa_io_query_info_ctr("", ps, depth, &out->ctr))
+                       return False;
        }
 
        if(!prs_align(ps))
@@ -842,6 +1064,49 @@ BOOL lsa_io_r_query(const char *desc, LSA_R_QUERY_INFO *out, prs_struct *ps, int
        return True;
 }
 
+/*******************************************************************
+ Reads or writes an LSA_Q_SET_INFO structure.
+********************************************************************/
+
+BOOL lsa_io_q_set(const char *desc, LSA_Q_SET_INFO *in, prs_struct *ps, 
+                 int depth)
+{
+       prs_debug(ps, depth, desc, "lsa_io_q_set");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!smb_io_pol_hnd("", &in->pol, ps, depth))
+               return False;
+
+       if(!prs_uint16("info_class", ps, depth, &in->info_class))
+               return False;
+
+       if(!lsa_io_query_info_ctr("", ps, depth, &in->ctr))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ Reads or writes an LSA_R_SET_INFO structure.
+********************************************************************/
+
+BOOL lsa_io_r_set(const char *desc, LSA_R_SET_INFO *out, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "lsa_io_r_set");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_ntstatus("status", ps, depth, &out->status))
+               return False;
+
+       return True;
+}
+
 /*******************************************************************
  Inits a LSA_SID_ENUM structure.
 ********************************************************************/
@@ -859,16 +1124,16 @@ static void init_lsa_sid_enum(TALLOC_CTX *mem_ctx, LSA_SID_ENUM *sen,
 
        /* Allocate memory for sids and sid pointers */
 
-       if (num_entries == 0) return;
-
-       if ((sen->ptr_sid = TALLOC_ZERO_ARRAY(mem_ctx, uint32, num_entries )) == NULL) {
-               DEBUG(3, ("init_lsa_sid_enum(): out of memory for ptr_sid\n"));
-               return;
-       }
+       if (num_entries) {
+               if ((sen->ptr_sid = TALLOC_ZERO_ARRAY(mem_ctx, uint32, num_entries )) == NULL) {
+                       DEBUG(3, ("init_lsa_sid_enum(): out of memory for ptr_sid\n"));
+                       return;
+               }
 
-       if ((sen->sid = TALLOC_ZERO_ARRAY(mem_ctx, DOM_SID2, num_entries)) == NULL) {
-               DEBUG(3, ("init_lsa_sid_enum(): out of memory for sids\n"));
-               return;
+               if ((sen->sid = TALLOC_ZERO_ARRAY(mem_ctx, DOM_SID2, num_entries)) == NULL) {
+                       DEBUG(3, ("init_lsa_sid_enum(): out of memory for sids\n"));
+                       return;
+               }
        }
 
        /* Copy across SIDs and SID pointers */
@@ -912,7 +1177,7 @@ static BOOL lsa_io_sid_enum(const char *desc, LSA_SID_ENUM *sen, prs_struct *ps,
 
        /* Mallocate memory if we're unpacking from the wire */
 
-       if (UNMARSHALLING(ps)) {
+       if (UNMARSHALLING(ps) && sen->num_entries) {
                if ((sen->ptr_sid = PRS_ALLOC_MEM( ps, uint32, sen->num_entries)) == NULL) {
                        DEBUG(3, ("init_lsa_sid_enum(): out of memory for "
                                  "ptr_sid\n"));
@@ -1090,12 +1355,17 @@ static BOOL lsa_io_trans_names(const char *desc, LSA_TRANS_NAME_ENUM *trn,
                               &trn->num_entries2))
                        return False;
 
-               if (UNMARSHALLING(ps)) {
-                       if ((trn->name = PRS_ALLOC_MEM(ps, LSA_TRANS_NAME, trn->num_entries)) == NULL) {
+               if (trn->num_entries2 != trn->num_entries) {
+                       /* RPC fault */
+                       return False;
+               }
+
+               if (UNMARSHALLING(ps) && trn->num_entries2) {
+                       if ((trn->name = PRS_ALLOC_MEM(ps, LSA_TRANS_NAME, trn->num_entries2)) == NULL) {
                                return False;
                        }
 
-                       if ((trn->uni_name = PRS_ALLOC_MEM(ps, UNISTR2, trn->num_entries)) == NULL) {
+                       if ((trn->uni_name = PRS_ALLOC_MEM(ps, UNISTR2, trn->num_entries2)) == NULL) {
                                return False;
                        }
                }
@@ -1147,12 +1417,17 @@ static BOOL lsa_io_trans_names2(const char *desc, LSA_TRANS_NAME_ENUM2 *trn,
                               &trn->num_entries2))
                        return False;
 
-               if (UNMARSHALLING(ps)) {
-                       if ((trn->name = PRS_ALLOC_MEM(ps, LSA_TRANS_NAME2, trn->num_entries)) == NULL) {
+               if (trn->num_entries2 != trn->num_entries) {
+                       /* RPC fault */
+                       return False;
+               }
+
+               if (UNMARSHALLING(ps) && trn->num_entries2) {
+                       if ((trn->name = PRS_ALLOC_MEM(ps, LSA_TRANS_NAME2, trn->num_entries2)) == NULL) {
                                return False;
                        }
 
-                       if ((trn->uni_name = PRS_ALLOC_MEM(ps, UNISTR2, trn->num_entries)) == NULL) {
+                       if ((trn->uni_name = PRS_ALLOC_MEM(ps, UNISTR2, trn->num_entries2)) == NULL) {
                                return False;
                        }
                }
@@ -1200,7 +1475,7 @@ BOOL lsa_io_r_lookup_sids(const char *desc, LSA_R_LOOKUP_SIDS *r_s,
                if(!lsa_io_dom_r_ref ("dom_ref", r_s->dom_ref, ps, depth)) /* domain reference info */
                        return False;
 
-       if(!lsa_io_trans_names("names  ", r_s->names, ps, depth)) /* translated names */
+       if(!lsa_io_trans_names("names  ", &r_s->names, ps, depth)) /* translated names */
                return False;
 
        if(!prs_align(ps))
@@ -1235,7 +1510,7 @@ BOOL lsa_io_r_lookup_sids2(const char *desc, LSA_R_LOOKUP_SIDS2 *r_s,
                if(!lsa_io_dom_r_ref ("dom_ref", r_s->dom_ref, ps, depth)) /* domain reference info */
                        return False;
 
-       if(!lsa_io_trans_names2("names  ", r_s->names, ps, depth)) /* translated names */
+       if(!lsa_io_trans_names2("names  ", &r_s->names, ps, depth)) /* translated names */
                return False;
 
        if(!prs_align(ps))
@@ -1271,7 +1546,7 @@ BOOL lsa_io_r_lookup_sids3(const char *desc, LSA_R_LOOKUP_SIDS3 *r_s,
                if(!lsa_io_dom_r_ref ("dom_ref", r_s->dom_ref, ps, depth)) /* domain reference info */
                        return False;
 
-       if(!lsa_io_trans_names2("names  ", r_s->names, ps, depth)) /* translated names */
+       if(!lsa_io_trans_names2("names  ", &r_s->names, ps, depth)) /* translated names */
                return False;
 
        if(!prs_align(ps))
@@ -1291,7 +1566,8 @@ makes a structure.
 ********************************************************************/
 
 void init_q_lookup_names(TALLOC_CTX *mem_ctx, LSA_Q_LOOKUP_NAMES *q_l, 
-                        POLICY_HND *hnd, int num_names, const char **names)
+                        POLICY_HND *hnd, int num_names, const char **names, 
+                        int level)
 {
        unsigned int i;
 
@@ -1302,16 +1578,21 @@ void init_q_lookup_names(TALLOC_CTX *mem_ctx, LSA_Q_LOOKUP_NAMES *q_l,
        q_l->pol = *hnd;
        q_l->num_entries = num_names;
        q_l->num_entries2 = num_names;
-       q_l->lookup_level = 1;
+       q_l->lookup_level = level;
 
-       if ((q_l->uni_name = TALLOC_ZERO_ARRAY(mem_ctx, UNISTR2, num_names)) == NULL) {
-               DEBUG(3, ("init_q_lookup_names(): out of memory\n"));
-               return;
-       }
+       if (num_names) {
+               if ((q_l->uni_name = TALLOC_ZERO_ARRAY(mem_ctx, UNISTR2, num_names)) == NULL) {
+                       DEBUG(3, ("init_q_lookup_names(): out of memory\n"));
+                       return;
+               }
 
-       if ((q_l->hdr_name = TALLOC_ZERO_ARRAY(mem_ctx, UNIHDR, num_names)) == NULL) {
-               DEBUG(3, ("init_q_lookup_names(): out of memory\n"));
-               return;
+               if ((q_l->hdr_name = TALLOC_ZERO_ARRAY(mem_ctx, UNIHDR, num_names)) == NULL) {
+                       DEBUG(3, ("init_q_lookup_names(): out of memory\n"));
+                       return;
+               }
+       } else {
+               q_l->uni_name = NULL;
+               q_l->hdr_name = NULL;
        }
 
        for (i = 0; i < num_names; i++) {
@@ -1419,7 +1700,7 @@ BOOL lsa_io_r_lookup_names(const char *desc, LSA_R_LOOKUP_NAMES *out, prs_struct
                        return False;
                }
 
-               if (UNMARSHALLING(ps)) {
+               if (UNMARSHALLING(ps) && out->num_entries2) {
                        if ((out->dom_rid = PRS_ALLOC_MEM(ps, DOM_RID, out->num_entries2))
                            == NULL) {
                                DEBUG(3, ("lsa_io_r_lookup_names(): out of memory\n"));
@@ -1544,7 +1825,7 @@ BOOL lsa_io_r_lookup_names2(const char *desc, LSA_R_LOOKUP_NAMES2 *out, prs_stru
                        return False;
                }
 
-               if (UNMARSHALLING(ps)) {
+               if (UNMARSHALLING(ps) && out->num_entries2) {
                        if ((out->dom_rid = PRS_ALLOC_MEM(ps, DOM_RID2, out->num_entries2))
                            == NULL) {
                                DEBUG(3, ("lsa_io_r_lookup_names2(): out of memory\n"));
@@ -1697,7 +1978,7 @@ BOOL lsa_io_r_lookup_names3(const char *desc, LSA_R_LOOKUP_NAMES3 *out, prs_stru
                        return False;
                }
 
-               if (UNMARSHALLING(ps)) {
+               if (UNMARSHALLING(ps) && out->num_entries2) {
                        if ((out->trans_sids = PRS_ALLOC_MEM(ps, LSA_TRANSLATED_SID3, out->num_entries2))
                            == NULL) {
                                DEBUG(3, ("lsa_io_r_lookup_names3(): out of memory\n"));
@@ -1826,7 +2107,7 @@ BOOL lsa_io_r_lookup_names4(const char *desc, LSA_R_LOOKUP_NAMES4 *out, prs_stru
                        return False;
                }
 
-               if (UNMARSHALLING(ps)) {
+               if (UNMARSHALLING(ps) && out->num_entries2) {
                        if ((out->trans_sids = PRS_ALLOC_MEM(ps, LSA_TRANSLATED_SID3, out->num_entries2))
                            == NULL) {
                                DEBUG(3, ("lsa_io_r_lookup_names4(): out of memory\n"));
@@ -1858,50 +2139,6 @@ BOOL lsa_io_r_lookup_names4(const char *desc, LSA_R_LOOKUP_NAMES4 *out, prs_stru
        return True;
 }
 
-/*******************************************************************
- Inits an LSA_Q_CLOSE structure.
-********************************************************************/
-
-void init_lsa_q_close(LSA_Q_CLOSE *in, POLICY_HND *hnd)
-{
-       DEBUG(5, ("init_lsa_q_close\n"));
-
-       memcpy(&in->pol, hnd, sizeof(in->pol));
-}
-
-/*******************************************************************
- Reads or writes an LSA_Q_CLOSE structure.
-********************************************************************/
-
-BOOL lsa_io_q_close(const char *desc, LSA_Q_CLOSE *in, prs_struct *ps, int depth)
-{
-       prs_debug(ps, depth, desc, "lsa_io_q_close");
-       depth++;
-
-       if(!smb_io_pol_hnd("", &in->pol, ps, depth))
-               return False;
-
-       return True;
-}
-
-/*******************************************************************
- Reads or writes an LSA_R_CLOSE structure.
-********************************************************************/
-
-BOOL lsa_io_r_close(const char *desc,  LSA_R_CLOSE *out, prs_struct *ps, int depth)
-{
-       prs_debug(ps, depth, desc, "lsa_io_r_close");
-       depth++;
-
-       if(!smb_io_pol_hnd("", &out->pol, ps, depth))
-               return False;
-
-       if(!prs_ntstatus("status", ps, depth, &out->status))
-               return False;
-
-       return True;
-}
-
 /*******************************************************************
  Reads or writes an LSA_Q_OPEN_SECRET structure.
 ********************************************************************/
@@ -2065,7 +2302,7 @@ BOOL lsa_io_r_enum_privs(const char *desc, LSA_R_ENUM_PRIVS *out, prs_struct *ps
                if(!prs_uint32("count1", ps, depth, &out->count1))
                        return False;
 
-               if (UNMARSHALLING(ps))
+               if (UNMARSHALLING(ps) && out->count1)
                        if (!(out->privs = PRS_ALLOC_MEM(ps, LSA_PRIV_ENTRY, out->count1)))
                                return False;
 
@@ -2500,7 +2737,7 @@ static BOOL lsa_io_luid_attr(const char *desc, LUID_ATTR *out, prs_struct *ps, i
 
 static BOOL lsa_io_privilege_set(const char *desc, PRIVILEGE_SET *out, prs_struct *ps, int depth)
 {
-       uint32 i;
+       uint32 i, dummy;
 
        prs_debug(ps, depth, desc, "lsa_io_privilege_set");
        depth++;
@@ -2508,7 +2745,7 @@ static BOOL lsa_io_privilege_set(const char *desc, PRIVILEGE_SET *out, prs_struc
        if(!prs_align(ps))
                return False;
  
-       if(!prs_uint32("count", ps, depth, &out->count))
+       if(!prs_uint32("count", ps, depth, &dummy))
                return False;
        if(!prs_uint32("control", ps, depth, &out->control))
                return False;
@@ -2663,7 +2900,7 @@ BOOL lsa_io_r_setsystemaccount(const char *desc, LSA_R_SETSYSTEMACCOUNT  *out, p
 }
 
 
-static void init_lsa_string( LSA_STRING *uni, const char *string )
+void init_lsa_string( LSA_STRING *uni, const char *string )
 {
        init_unistr2(&uni->unistring, string, UNI_FLAGS_NONE);
        init_uni_hdr(&uni->hdr, &uni->unistring);
@@ -2851,52 +3088,6 @@ BOOL policy_handle_is_valid(const POLICY_HND *hnd)
        return ((memcmp(&zero_pol, hnd, sizeof(POLICY_HND)) == 0) ? False : True );
 }
 
-/*******************************************************************
- Reads or writes an LSA_DNS_DOM_INFO structure.
-********************************************************************/
-
-BOOL lsa_io_dns_dom_info(const char *desc, LSA_DNS_DOM_INFO *info,
-                        prs_struct *ps, int depth)
-{
-       prs_debug(ps, depth, desc, "lsa_io_dns_dom_info");
-       depth++;
-
-       if(!prs_align(ps))
-               return False;
-       if(!smb_io_unihdr("nb_name", &info->hdr_nb_dom_name, ps, depth))
-               return False;
-       if(!smb_io_unihdr("dns_name", &info->hdr_dns_dom_name, ps, depth))
-               return False;
-       if(!smb_io_unihdr("forest", &info->hdr_forest_name, ps, depth))
-               return False;
-
-       if(!prs_align(ps))
-               return False;
-       if ( !smb_io_uuid("dom_guid", &info->dom_guid, ps, depth) )
-               return False;
-
-       if(!prs_align(ps))
-               return False;
-       if(!prs_uint32("dom_sid", ps, depth, &info->ptr_dom_sid))
-               return False;
-
-       if(!smb_io_unistr2("nb_name", &info->uni_nb_dom_name,
-                          info->hdr_nb_dom_name.buffer, ps, depth))
-               return False;
-       if(!smb_io_unistr2("dns_name", &info->uni_dns_dom_name, 
-                          info->hdr_dns_dom_name.buffer, ps, depth))
-               return False;
-       if(!smb_io_unistr2("forest", &info->uni_forest_name, 
-                          info->hdr_forest_name.buffer, ps, depth))
-               return False;
-
-       if(!smb_io_dom_sid2("dom_sid", &info->dom_sid, ps, depth))
-               return False;
-
-       return True;
-       
-}
-
 /*******************************************************************
  Inits an LSA_Q_QUERY_INFO2 structure.
 ********************************************************************/
@@ -2944,20 +3135,13 @@ BOOL lsa_io_r_query_info2(const char *desc, LSA_R_QUERY_INFO2 *out,
        if(!prs_align(ps))
                return False;
 
-       if(!prs_uint32("ptr", ps, depth, &out->ptr))
-               return False;
-       if(!prs_uint16("info_class", ps, depth, &out->info_class))
+       if(!prs_uint32("dom_ptr", ps, depth, &out->dom_ptr))
                return False;
-       switch(out->info_class) {
-       case 0x000c:
-               if (!lsa_io_dns_dom_info("info12", &out->info.dns_dom_info,
-                                        ps, depth))
+
+       if (out->dom_ptr) {
+
+               if(!lsa_io_query_info_ctr2("", ps, depth, &out->ctr))
                        return False;
-               break;
-       default:
-               DEBUG(0,("lsa_io_r_query_info2: unknown info class %d\n",
-                        out->info_class));
-               return False;
        }
 
        if(!prs_align(ps))
@@ -2987,20 +3171,20 @@ void init_q_enum_acct_rights(LSA_Q_ENUM_ACCT_RIGHTS *in,
 NTSTATUS init_r_enum_acct_rights( LSA_R_ENUM_ACCT_RIGHTS *out, PRIVILEGE_SET *privileges )
 {
        uint32 i;
-       char *privname;
+       const char *privname;
        const char **privname_array = NULL;
        int num_priv = 0;
 
        for ( i=0; i<privileges->count; i++ ) {
                privname = luid_to_privilege_name( &privileges->set[i].luid );
                if ( privname ) {
-                       if ( !add_string_to_array( get_talloc_ctx(), privname, &privname_array, &num_priv ) ) 
+                       if ( !add_string_to_array( talloc_tos(), privname, &privname_array, &num_priv ) )
                                return NT_STATUS_NO_MEMORY;
                }
        }
 
        if ( num_priv ) {
-               out->rights = TALLOC_P( get_talloc_ctx(), UNISTR4_ARRAY );
+               out->rights = TALLOC_P( talloc_tos(), UNISTR4_ARRAY );
                if (!out->rights) {
                        return NT_STATUS_NO_MEMORY;
                }
@@ -3047,7 +3231,7 @@ BOOL lsa_io_r_enum_acct_rights(const char *desc, LSA_R_ENUM_ACCT_RIGHTS *out, pr
        if(!prs_uint32("count   ", ps, depth, &out->count))
                return False;
 
-       if ( !prs_pointer("rights", ps, depth, (void**)&out->rights, sizeof(UNISTR4_ARRAY), (PRS_POINTER_CAST)prs_unistr4_array) )
+       if ( !prs_pointer("rights", ps, depth, (void*)&out->rights, sizeof(UNISTR4_ARRAY), (PRS_POINTER_CAST)prs_unistr4_array) )
                return False;
 
        if(!prs_align(ps))
@@ -3071,7 +3255,7 @@ void init_q_add_acct_rights( LSA_Q_ADD_ACCT_RIGHTS *in, POLICY_HND *hnd,
        in->pol = *hnd;
        init_dom_sid2(&in->sid, sid);
        
-       in->rights = TALLOC_P( get_talloc_ctx(), UNISTR4_ARRAY );
+       in->rights = TALLOC_P( talloc_tos(), UNISTR4_ARRAY );
        if (!in->rights) {
                smb_panic("init_q_add_acct_rights: talloc fail\n");
                return;
@@ -3099,7 +3283,7 @@ BOOL lsa_io_q_add_acct_rights(const char *desc, LSA_Q_ADD_ACCT_RIGHTS *in, prs_s
        if(!prs_uint32("count", ps, depth, &in->count))
                return False;
 
-       if ( !prs_pointer("rights", ps, depth, (void**)&in->rights, sizeof(UNISTR4_ARRAY), (PRS_POINTER_CAST)prs_unistr4_array) )
+       if ( !prs_pointer("rights", ps, depth, (void*)&in->rights, sizeof(UNISTR4_ARRAY), (PRS_POINTER_CAST)prs_unistr4_array) )
                return False;
 
        return True;
@@ -3139,7 +3323,7 @@ void init_q_remove_acct_rights(LSA_Q_REMOVE_ACCT_RIGHTS *in,
        in->removeall = removeall;
        in->count = count;
 
-       in->rights = TALLOC_P( get_talloc_ctx(), UNISTR4_ARRAY );
+       in->rights = TALLOC_P( talloc_tos(), UNISTR4_ARRAY );
        if (!in->rights) {
                smb_panic("init_q_remove_acct_rights: talloc fail\n");
                return;
@@ -3168,7 +3352,7 @@ BOOL lsa_io_q_remove_acct_rights(const char *desc, LSA_Q_REMOVE_ACCT_RIGHTS *in,
        if(!prs_uint32("count", ps, depth, &in->count))
                return False;
 
-       if ( !prs_pointer("rights", ps, depth, (void**)&in->rights, sizeof(UNISTR4_ARRAY), (PRS_POINTER_CAST)prs_unistr4_array) )
+       if ( !prs_pointer("rights", ps, depth, (void*)&in->rights, sizeof(UNISTR4_ARRAY), (PRS_POINTER_CAST)prs_unistr4_array) )
                return False;
 
        return True;
@@ -3680,7 +3864,7 @@ static BOOL smb_io_lsa_data_buf(const char *desc, LSA_DATA_BUF *buf,
        prs_debug(ps, depth, desc, "smb_io_lsa_data_buf");
        depth++;
 
-       if ( UNMARSHALLING(ps) ) {
+       if ( UNMARSHALLING(ps) && length ) {
                if ( !(buf->data = PRS_ALLOC_MEM( ps, uint8, length )) )
                        return False;
        }
@@ -3694,7 +3878,7 @@ static BOOL smb_io_lsa_data_buf(const char *desc, LSA_DATA_BUF *buf,
        if (!prs_uint32("length", ps, depth, &buf->length))
                return False;
 
-       if(!prs_uint8s(False, "data", ps, depth, buf->data, size))
+       if(!prs_uint8s(False, "data", ps, depth, buf->data, length))
                return False;
 
        return True;
@@ -3853,7 +4037,7 @@ BOOL lsa_io_r_query_trusted_domain_info(const char *desc,
        prs_debug(ps, depth, desc, "lsa_io_r_query_trusted_domain_info");
        depth++;
 
-       if (!prs_pointer("trustdom", ps, depth, (void**)&r_q->info, 
+       if (!prs_pointer("trustdom", ps, depth, (void*)&r_q->info, 
                         sizeof(LSA_TRUSTED_DOMAIN_INFO), 
                         (PRS_POINTER_CAST)lsa_io_trustdom_query) )
                return False;
@@ -3982,7 +4166,7 @@ BOOL lsa_io_r_query_dom_info(const char *desc, LSA_R_QUERY_DOM_INFO_POLICY *out,
        prs_debug(ps, depth, desc, "lsa_io_r_query_dom_info");
        depth++;
 
-       if (!prs_pointer("dominfo", ps, depth, (void**)&out->info, 
+       if (!prs_pointer("dominfo", ps, depth, (void*)&out->info, 
                         sizeof(LSA_DOM_INFO_UNION), 
                         (PRS_POINTER_CAST)lsa_io_dom_info_query) )
                return False;