smbd: Fix a typo in a few places
[samba.git] / source3 / modules / vfs_acl_xattr.c
index bd8a164f0fe4dd000b3e79b2038684bef6810e16..1a3ab34d659d264b959875b6e340ed9ebdff5d02 100644 (file)
@@ -24,6 +24,8 @@
 #include "librpc/gen_ndr/xattr.h"
 #include "auth.h"
 #include "vfs_acl_common.h"
+#include "lib/util/tevent_ntstatus.h"
+#include "lib/util/tevent_unix.h"
 
 /* Pull in the common functions. */
 #define ACL_MODULE_NAME "acl_xattr"
@@ -37,7 +39,6 @@
 
 static ssize_t getxattr_do(vfs_handle_struct *handle,
                           files_struct *fsp,
-                          const struct smb_filename *smb_fname,
                           const char *xattr_name,
                           uint8_t *val,
                           size_t size)
@@ -46,12 +47,7 @@ static ssize_t getxattr_do(vfs_handle_struct *handle,
        int saved_errno = 0;
 
        become_root();
-       if (fsp && fsp->fh->fd != -1) {
-               sizeret = SMB_VFS_FGETXATTR(fsp, xattr_name, val, size);
-       } else {
-               sizeret = SMB_VFS_GETXATTR(handle->conn, smb_fname,
-                                          XATTR_NTACL_NAME, val, size);
-       }
+       sizeret = SMB_VFS_FGETXATTR(fsp, xattr_name, val, size);
        if (sizeret == -1) {
                saved_errno = errno;
        }
@@ -86,7 +82,7 @@ static NTSTATUS fget_acl_blob(TALLOC_CTX *ctx,
        val = tmp;
 
        sizeret =
-           getxattr_do(handle, fsp, NULL, XATTR_NTACL_NAME, val, size);
+           getxattr_do(handle, fsp, XATTR_NTACL_NAME, val, size);
 
        if (sizeret >= 0) {
                pblob->data = val;
@@ -100,65 +96,7 @@ static NTSTATUS fget_acl_blob(TALLOC_CTX *ctx,
 
        /* Too small, try again. */
        sizeret =
-           getxattr_do(handle, fsp, NULL, XATTR_NTACL_NAME, NULL, 0);
-       if (sizeret < 0) {
-               goto err;
-       }
-
-       if (size < sizeret) {
-               size = sizeret;
-       }
-
-       if (size > 65536) {
-               /* Max ACL size is 65536 bytes. */
-               errno = ERANGE;
-               goto err;
-       }
-
-       goto again;
-  err:
-       /* Real error - exit here. */
-       TALLOC_FREE(val);
-       return map_nt_error_from_unix(errno);
-}
-
-static NTSTATUS get_acl_blob(TALLOC_CTX *ctx,
-                       vfs_handle_struct *handle,
-                       const struct smb_filename *smb_fname,
-                       DATA_BLOB *pblob)
-{
-       size_t size = 4096;
-       uint8_t *val = NULL;
-       uint8_t *tmp;
-       ssize_t sizeret;
-
-       ZERO_STRUCTP(pblob);
-
-  again:
-
-       tmp = talloc_realloc(ctx, val, uint8_t, size);
-       if (tmp == NULL) {
-               TALLOC_FREE(val);
-               return NT_STATUS_NO_MEMORY;
-       }
-       val = tmp;
-
-       sizeret =
-           getxattr_do(handle, NULL, smb_fname, XATTR_NTACL_NAME, val, size);
-
-       if (sizeret >= 0) {
-               pblob->data = val;
-               pblob->length = sizeret;
-               return NT_STATUS_OK;
-       }
-
-       if (errno != ERANGE) {
-               goto err;
-       }
-
-       /* Too small, try again. */
-       sizeret =
-           getxattr_do(handle, NULL, smb_fname, XATTR_NTACL_NAME, NULL, 0);
+           getxattr_do(handle, fsp, XATTR_NTACL_NAME, NULL, 0);
        if (sizeret < 0) {
                goto err;
        }
@@ -195,14 +133,8 @@ static NTSTATUS store_acl_blob_fsp(vfs_handle_struct *handle,
                  (unsigned int)pblob->length, fsp_str_dbg(fsp)));
 
        become_root();
-       if (fsp->fh->fd != -1) {
-               ret = SMB_VFS_FSETXATTR(fsp, XATTR_NTACL_NAME,
+       ret = SMB_VFS_FSETXATTR(fsp, XATTR_NTACL_NAME,
                        pblob->data, pblob->length, 0);
-       } else {
-               ret = SMB_VFS_SETXATTR(fsp->conn, fsp->fsp_name,
-                               XATTR_NTACL_NAME,
-                               pblob->data, pblob->length, 0);
-       }
        if (ret) {
                saved_errno = errno;
        }
@@ -222,53 +154,39 @@ static NTSTATUS store_acl_blob_fsp(vfs_handle_struct *handle,
  Remove a Windows ACL - we're setting the underlying POSIX ACL.
 *********************************************************************/
 
-static int sys_acl_set_file_xattr(vfs_handle_struct *handle,
-                               const struct smb_filename *smb_fname,
+static int sys_acl_set_fd_xattr(vfs_handle_struct *handle,
+                               files_struct *fsp,
                                SMB_ACL_TYPE_T type,
                                SMB_ACL_T theacl)
 {
-       int ret = SMB_VFS_NEXT_SYS_ACL_SET_FILE(handle,
-                                               smb_fname,
-                                               type,
-                                               theacl);
+       struct acl_common_fsp_ext *ext = (struct acl_common_fsp_ext *)
+               VFS_FETCH_FSP_EXTENSION(handle, fsp);
+       int ret;
+
+       ret = SMB_VFS_NEXT_SYS_ACL_SET_FD(handle,
+                                         fsp,
+                                         type,
+                                         theacl);
        if (ret == -1) {
                return -1;
        }
 
-       become_root();
-       SMB_VFS_REMOVEXATTR(handle->conn, smb_fname,
-                       XATTR_NTACL_NAME);
-       unbecome_root();
-
-       return ret;
-}
-
-/*********************************************************************
- Remove a Windows ACL - we're setting the underlying POSIX ACL.
-*********************************************************************/
-
-static int sys_acl_set_fd_xattr(vfs_handle_struct *handle,
-                            files_struct *fsp,
-                            SMB_ACL_T theacl)
-{
-       int ret = SMB_VFS_NEXT_SYS_ACL_SET_FD(handle,
-                                               fsp,
-                                               theacl);
-       if (ret == -1) {
-               return -1;
+       if (ext != NULL && ext->setting_nt_acl) {
+               return 0;
        }
 
        become_root();
        SMB_VFS_FREMOVEXATTR(fsp, XATTR_NTACL_NAME);
        unbecome_root();
 
-       return ret;
+       return 0;
 }
 
 static int connect_acl_xattr(struct vfs_handle_struct *handle,
                                const char *service,
                                const char *user)
 {
+       const char *security_acl_xattr_name = NULL;
        int ret = SMB_VFS_NEXT_CONNECT(handle, service, user);
        bool ok;
        struct acl_common_config *config = NULL;
@@ -332,6 +250,17 @@ static int connect_acl_xattr(struct vfs_handle_struct *handle,
                                "yes");
        }
 
+       security_acl_xattr_name = lp_parm_const_string(SNUM(handle->conn),
+                                         "acl_xattr",
+                                         "security_acl_name",
+                                         NULL);
+       if (security_acl_xattr_name != NULL) {
+               config->security_acl_xattr_name = talloc_strdup(config, security_acl_xattr_name);
+               if (config->security_acl_xattr_name == NULL) {
+                       return -1;
+               }
+       }
+
        return 0;
 }
 
@@ -367,18 +296,6 @@ static NTSTATUS acl_xattr_fget_nt_acl(vfs_handle_struct *handle,
        return status;
 }
 
-static NTSTATUS acl_xattr_get_nt_acl(vfs_handle_struct *handle,
-                                    const struct smb_filename *smb_fname,
-                                    uint32_t security_info,
-                                    TALLOC_CTX *mem_ctx,
-                                    struct security_descriptor **ppdesc)
-{
-       NTSTATUS status;
-       status = get_nt_acl_common(get_acl_blob, handle, smb_fname,
-                                  security_info, mem_ctx, ppdesc);
-       return status;
-}
-
 static NTSTATUS acl_xattr_fset_nt_acl(vfs_handle_struct *handle,
                                      files_struct *fsp,
                                      uint32_t security_info_sent,
@@ -391,16 +308,240 @@ static NTSTATUS acl_xattr_fset_nt_acl(vfs_handle_struct *handle,
        return status;
 }
 
+struct acl_xattr_getxattrat_state {
+       struct vfs_aio_state aio_state;
+       ssize_t xattr_size;
+       uint8_t *xattr_value;
+};
+
+static void acl_xattr_getxattrat_done(struct tevent_req *subreq);
+
+static struct tevent_req *acl_xattr_getxattrat_send(
+                               TALLOC_CTX *mem_ctx,
+                               struct tevent_context *ev,
+                               struct vfs_handle_struct *handle,
+                               files_struct *dirfsp,
+                               const struct smb_filename *smb_fname,
+                               const char *xattr_name,
+                               size_t alloc_hint)
+{
+       struct tevent_req *req = NULL;
+       struct tevent_req *subreq = NULL;
+       struct acl_xattr_getxattrat_state *state = NULL;
+       struct acl_common_config *config = NULL;
+
+       SMB_VFS_HANDLE_GET_DATA(handle, config,
+                               struct acl_common_config,
+                               return NULL);
+
+       req = tevent_req_create(mem_ctx, &state,
+                               struct acl_xattr_getxattrat_state);
+       if (req == NULL) {
+               return NULL;
+       }
+
+       if (strequal(xattr_name, config->security_acl_xattr_name)) {
+               tevent_req_nterror(req, NT_STATUS_ACCESS_DENIED);
+               return tevent_req_post(req, ev);
+       }
+       if (config->security_acl_xattr_name != NULL &&
+           strequal(xattr_name, XATTR_NTACL_NAME))
+       {
+               xattr_name = config->security_acl_xattr_name;
+       }
+
+       subreq = SMB_VFS_NEXT_GETXATTRAT_SEND(state,
+                                             ev,
+                                             handle,
+                                             dirfsp,
+                                             smb_fname,
+                                             xattr_name,
+                                             alloc_hint);
+       if (tevent_req_nomem(subreq, req)) {
+               return tevent_req_post(req, ev);
+       }
+       tevent_req_set_callback(subreq, acl_xattr_getxattrat_done, req);
+
+       return req;
+}
+
+static void acl_xattr_getxattrat_done(struct tevent_req *subreq)
+{
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct acl_xattr_getxattrat_state *state = tevent_req_data(
+               req, struct acl_xattr_getxattrat_state);
+
+       state->xattr_size = SMB_VFS_NEXT_GETXATTRAT_RECV(subreq,
+                                                        &state->aio_state,
+                                                        state,
+                                                        &state->xattr_value);
+       TALLOC_FREE(subreq);
+       if (state->xattr_size == -1) {
+               tevent_req_error(req, state->aio_state.error);
+               return;
+       }
+
+       tevent_req_done(req);
+}
+
+static ssize_t acl_xattr_getxattrat_recv(struct tevent_req *req,
+                                        struct vfs_aio_state *aio_state,
+                                        TALLOC_CTX *mem_ctx,
+                                        uint8_t **xattr_value)
+{
+       struct acl_xattr_getxattrat_state *state = tevent_req_data(
+               req, struct acl_xattr_getxattrat_state);
+       ssize_t xattr_size;
+
+       if (tevent_req_is_unix_error(req, &aio_state->error)) {
+               tevent_req_received(req);
+               return -1;
+       }
+
+       *aio_state = state->aio_state;
+       xattr_size = state->xattr_size;
+       if (xattr_value != NULL) {
+               *xattr_value = talloc_move(mem_ctx, &state->xattr_value);
+       }
+
+       tevent_req_received(req);
+       return xattr_size;
+}
+
+static ssize_t acl_xattr_fgetxattr(struct vfs_handle_struct *handle,
+                                  struct files_struct *fsp,
+                                  const char *name,
+                                  void *value,
+                                  size_t size)
+{
+       struct acl_common_config *config = NULL;
+
+       SMB_VFS_HANDLE_GET_DATA(handle, config,
+                               struct acl_common_config,
+                               return -1);
+
+       if (strequal(name, config->security_acl_xattr_name)) {
+               errno = EACCES;
+               return -1;
+       }
+       if (config->security_acl_xattr_name != NULL &&
+           strequal(name, XATTR_NTACL_NAME))
+       {
+               name = config->security_acl_xattr_name;
+       }
+
+       return SMB_VFS_NEXT_FGETXATTR(handle, fsp, name, value, size);
+}
+
+static ssize_t acl_xattr_flistxattr(struct vfs_handle_struct *handle,
+                                   struct files_struct *fsp,
+                                   char *listbuf,
+                                   size_t bufsize)
+{
+       struct acl_common_config *config = NULL;
+       ssize_t size;
+       char *p = NULL;
+       size_t nlen, consumed;
+
+       SMB_VFS_HANDLE_GET_DATA(handle, config,
+                               struct acl_common_config,
+                               return -1);
+
+       size = SMB_VFS_NEXT_FLISTXATTR(handle, fsp, listbuf, bufsize);
+       if (size < 0) {
+               return -1;
+       }
+
+       p = listbuf;
+       while (p - listbuf < size) {
+               nlen = strlen(p) + 1;
+               if (strequal(p, config->security_acl_xattr_name)) {
+                       break;
+               }
+               p += nlen;
+       }
+       if (p - listbuf >= size) {
+               /* No match */
+               return size;
+       }
+
+       /*
+        * The consumed helper variable just makes the math
+        * a bit more digestible.
+        */
+       consumed = p - listbuf;
+       if (consumed + nlen < size) {
+               /* If not the last name move, else just skip */
+               memmove(p, p + nlen, size - consumed - nlen);
+       }
+       size -= nlen;
+
+       return size;
+}
+
+static int acl_xattr_fremovexattr(struct vfs_handle_struct *handle,
+                                 struct files_struct *fsp,
+                                 const char *name)
+{
+       struct acl_common_config *config = NULL;
+
+       SMB_VFS_HANDLE_GET_DATA(handle, config,
+                               struct acl_common_config,
+                               return -1);
+
+       if (strequal(name, config->security_acl_xattr_name)) {
+               errno = EACCES;
+               return -1;
+       }
+       if (config->security_acl_xattr_name != NULL &&
+           strequal(name, XATTR_NTACL_NAME))
+       {
+               name = config->security_acl_xattr_name;
+       }
+
+       return SMB_VFS_NEXT_FREMOVEXATTR(handle, fsp, name);
+}
+
+static int acl_xattr_fsetxattr(struct vfs_handle_struct *handle,
+                              struct files_struct *fsp,
+                              const char *name,
+                              const void *value,
+                              size_t size,
+                              int flags)
+{
+       struct acl_common_config *config = NULL;
+
+       SMB_VFS_HANDLE_GET_DATA(handle, config,
+                               struct acl_common_config,
+                               return -1);
+
+       if (strequal(name, config->security_acl_xattr_name)) {
+               errno = EACCES;
+               return -1;
+       }
+       if (config->security_acl_xattr_name != NULL &&
+           strequal(name, XATTR_NTACL_NAME))
+       {
+               name = config->security_acl_xattr_name;
+       }
+
+       return SMB_VFS_NEXT_FSETXATTR(handle, fsp, name, value, size, flags);
+}
+
 static struct vfs_fn_pointers vfs_acl_xattr_fns = {
        .connect_fn = connect_acl_xattr,
        .unlinkat_fn = acl_xattr_unlinkat,
-       .chmod_fn = chmod_acl_module_common,
        .fchmod_fn = fchmod_acl_module_common,
        .fget_nt_acl_fn = acl_xattr_fget_nt_acl,
-       .get_nt_acl_fn = acl_xattr_get_nt_acl,
        .fset_nt_acl_fn = acl_xattr_fset_nt_acl,
-       .sys_acl_set_file_fn = sys_acl_set_file_xattr,
-       .sys_acl_set_fd_fn = sys_acl_set_fd_xattr
+       .sys_acl_set_fd_fn = sys_acl_set_fd_xattr,
+       .getxattrat_send_fn = acl_xattr_getxattrat_send,
+       .getxattrat_recv_fn = acl_xattr_getxattrat_recv,
+       .fgetxattr_fn = acl_xattr_fgetxattr,
+       .flistxattr_fn = acl_xattr_flistxattr,
+       .fremovexattr_fn = acl_xattr_fremovexattr,
+       .fsetxattr_fn = acl_xattr_fsetxattr,
 };
 
 static_decl_vfs;