smbd: Fix a typo in a few places
[samba.git] / source3 / modules / vfs_audit.c
index 81bb43ec27a767423c9a09a6d2b45397ba0e170c..2b01a6a8d91ff35b336d2cc528b4ecb12db306fa 100644 (file)
@@ -177,65 +177,51 @@ static void audit_disconnect(vfs_handle_struct *handle)
        return;
 }
 
-static DIR *audit_opendir(vfs_handle_struct *handle,
-                       const struct smb_filename *smb_fname,
-                       const char *mask,
-                       uint32_t attr)
-{
-       DIR *result;
-       
-       result = SMB_VFS_NEXT_OPENDIR(handle, smb_fname, mask, attr);
-
-       syslog(audit_syslog_priority(handle), "opendir %s %s%s\n",
-              smb_fname->base_name,
-              (result == NULL) ? "failed: " : "",
-              (result == NULL) ? strerror(errno) : "");
-
-       return result;
-}
-
-static int audit_mkdir(vfs_handle_struct *handle,
+static int audit_mkdirat(vfs_handle_struct *handle,
+               struct files_struct *dirfsp,
                const struct smb_filename *smb_fname,
                mode_t mode)
 {
+       struct smb_filename *full_fname = NULL;
        int result;
-       
-       result = SMB_VFS_NEXT_MKDIR(handle, smb_fname, mode);
-       
-       syslog(audit_syslog_priority(handle), "mkdir %s %s%s\n", 
-              smb_fname->base_name,
-              (result < 0) ? "failed: " : "",
-              (result < 0) ? strerror(errno) : "");
-
-       return result;
-}
 
-static int audit_rmdir(vfs_handle_struct *handle,
-               const struct smb_filename *smb_fname)
-{
-       int result;
+       full_fname = full_path_from_dirfsp_atname(talloc_tos(),
+                                                 dirfsp,
+                                                 smb_fname);
+       if (full_fname == NULL) {
+               errno = ENOMEM;
+               return -1;
+       }
 
-       result = SMB_VFS_NEXT_RMDIR(handle, smb_fname);
+       result = SMB_VFS_NEXT_MKDIRAT(handle,
+                       dirfsp,
+                       smb_fname,
+                       mode);
 
-       syslog(audit_syslog_priority(handle), "rmdir %s %s%s\n", 
-              smb_fname->base_name,
+       syslog(audit_syslog_priority(handle), "mkdirat %s %s%s\n",
+              full_fname->base_name,
               (result < 0) ? "failed: " : "",
               (result < 0) ? strerror(errno) : "");
 
+       TALLOC_FREE(full_fname);
        return result;
 }
 
-static int audit_open(vfs_handle_struct *handle,
-                     struct smb_filename *smb_fname, files_struct *fsp,
-                     int flags, mode_t mode)
+static int audit_openat(vfs_handle_struct *handle,
+                       const struct files_struct *dirfsp,
+                       const struct smb_filename *smb_fname,
+                       struct files_struct *fsp,
+                       const struct vfs_open_how *how)
 {
        int result;
 
-       result = SMB_VFS_NEXT_OPEN(handle, smb_fname, fsp, flags, mode);
+       result = SMB_VFS_NEXT_OPENAT(handle, dirfsp, smb_fname, fsp, how);
 
-       syslog(audit_syslog_priority(handle), "open %s (fd %d) %s%s%s\n", 
-              smb_fname->base_name, result,
-              ((flags & O_WRONLY) || (flags & O_RDWR)) ? "for writing " : "", 
+       syslog(audit_syslog_priority(handle),
+              "openat %s (fd %d) %s%s%s\n",
+              fsp_str_dbg(fsp), result,
+              ((how->flags & O_WRONLY) || (how->flags & O_RDWR)) ?
+              "for writing " : "",
               (result < 0) ? "failed: " : "",
               (result < 0) ? strerror(errno) : "");
 
@@ -249,82 +235,90 @@ static int audit_close(vfs_handle_struct *handle, files_struct *fsp)
        result = SMB_VFS_NEXT_CLOSE(handle, fsp);
 
        syslog(audit_syslog_priority(handle), "close fd %d %s%s\n",
-              fsp->fh->fd,
+              fsp_get_pathref_fd(fsp),
               (result < 0) ? "failed: " : "",
               (result < 0) ? strerror(errno) : "");
 
        return result;
 }
 
-static int audit_rename(vfs_handle_struct *handle,
-                       const struct smb_filename *smb_fname_src,
-                       const struct smb_filename *smb_fname_dst)
-{
-       int result;
-
-       result = SMB_VFS_NEXT_RENAME(handle, smb_fname_src, smb_fname_dst);
-
-       syslog(audit_syslog_priority(handle), "rename %s -> %s %s%s\n",
-              smb_fname_src->base_name,
-              smb_fname_dst->base_name,
-              (result < 0) ? "failed: " : "",
-              (result < 0) ? strerror(errno) : "");
-
-       return result;    
-}
-
 static int audit_renameat(vfs_handle_struct *handle,
                        files_struct *srcfsp,
                        const struct smb_filename *smb_fname_src,
                        files_struct *dstfsp,
                        const struct smb_filename *smb_fname_dst)
 {
+       struct smb_filename *full_fname_src = NULL;
+       struct smb_filename *full_fname_dst = NULL;
        int result;
-
+       int saved_errno = 0;
+
+       full_fname_src = full_path_from_dirfsp_atname(talloc_tos(),
+                                                 srcfsp,
+                                                 smb_fname_src);
+       if (full_fname_src == NULL) {
+               errno = ENOMEM;
+               return -1;
+       }
+       full_fname_dst = full_path_from_dirfsp_atname(talloc_tos(),
+                                                 dstfsp,
+                                                 smb_fname_dst);
+       if (full_fname_dst == NULL) {
+               TALLOC_FREE(full_fname_src);
+               errno = ENOMEM;
+               return -1;
+       }
        result = SMB_VFS_NEXT_RENAMEAT(handle,
                        srcfsp,
                        smb_fname_src,
                        dstfsp,
                        smb_fname_dst);
+       if (result == -1) {
+               saved_errno = errno;
+       }
 
        syslog(audit_syslog_priority(handle), "renameat %s -> %s %s%s\n",
-              smb_fname_src->base_name,
-              smb_fname_dst->base_name,
+              full_fname_src->base_name,
+              full_fname_dst->base_name,
               (result < 0) ? "failed: " : "",
               (result < 0) ? strerror(errno) : "");
 
-       return result;
-}
+       TALLOC_FREE(full_fname_src);
+       TALLOC_FREE(full_fname_dst);
 
-
-static int audit_unlink(vfs_handle_struct *handle,
-                       const struct smb_filename *smb_fname)
-{
-       int result;
-
-       result = SMB_VFS_NEXT_UNLINK(handle, smb_fname);
-
-       syslog(audit_syslog_priority(handle), "unlink %s %s%s\n",
-              smb_fname->base_name,
-              (result < 0) ? "failed: " : "",
-              (result < 0) ? strerror(errno) : "");
+       if (saved_errno != 0) {
+               errno = saved_errno;
+       }
 
        return result;
 }
 
-static int audit_chmod(vfs_handle_struct *handle,
+static int audit_unlinkat(vfs_handle_struct *handle,
+                       struct files_struct *dirfsp,
                        const struct smb_filename *smb_fname,
-                       mode_t mode)
+                       int flags)
 {
+       struct smb_filename *full_fname = NULL;
        int result;
 
-       result = SMB_VFS_NEXT_CHMOD(handle, smb_fname, mode);
+       full_fname = full_path_from_dirfsp_atname(talloc_tos(),
+                                                 dirfsp,
+                                                 smb_fname);
+       if (full_fname == NULL) {
+               return -1;
+       }
+
+       result = SMB_VFS_NEXT_UNLINKAT(handle,
+                       dirfsp,
+                       smb_fname,
+                       flags);
 
-       syslog(audit_syslog_priority(handle), "chmod %s mode 0x%x %s%s\n",
-              smb_fname->base_name, mode,
+       syslog(audit_syslog_priority(handle), "unlinkat %s %s%s\n",
+              full_fname->base_name,
               (result < 0) ? "failed: " : "",
               (result < 0) ? strerror(errno) : "");
 
+       TALLOC_FREE(full_fname);
        return result;
 }
 
@@ -345,15 +339,11 @@ static int audit_fchmod(vfs_handle_struct *handle, files_struct *fsp, mode_t mod
 static struct vfs_fn_pointers vfs_audit_fns = {
        .connect_fn = audit_connect,
        .disconnect_fn = audit_disconnect,
-       .opendir_fn = audit_opendir,
-       .mkdir_fn = audit_mkdir,
-       .rmdir_fn = audit_rmdir,
-       .open_fn = audit_open,
+       .mkdirat_fn = audit_mkdirat,
+       .openat_fn = audit_openat,
        .close_fn = audit_close,
-       .rename_fn = audit_rename,
        .renameat_fn = audit_renameat,
-       .unlink_fn = audit_unlink,
-       .chmod_fn = audit_chmod,
+       .unlinkat_fn = audit_unlinkat,
        .fchmod_fn = audit_fchmod,
 };