vfs: Remove shadow_copy2_get_real_filename_at()
authorVolker Lendecke <vl@samba.org>
Thu, 11 Jan 2024 16:49:29 +0000 (16:49 +0000)
committerJeremy Allison <jra@samba.org>
Tue, 16 Jan 2024 19:44:53 +0000 (19:44 +0000)
commit0caaa2d1723084ba5a707432830c5916e85e21bc
tree472c15992035ff868b28c758e9ab050f2bdc63ab
parent6afcb7f0dbfe741e43b2070f8a78d87cdb73e042
vfs: Remove shadow_copy2_get_real_filename_at()

The synthetic_pathref() call in shadow_copy2_get_real_filename_at()
fails if shadow:snapdir is set outside of the share root, it creates
an absolute path and non_widelink_open() blocks that.

We don't need shadow_copy2_get_real_filename_at() anymore because the
dirfsp already points at the correct directory in the snapshot
directory. So get_real_filename_full_scan_at() just works fine.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=15556

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan 16 19:44:53 UTC 2024 on atb-devel-224
selftest/knownfail.d/shadow_copy2_ci [deleted file]
source3/modules/vfs_shadow_copy2.c