traffic: Machine accounts were generated as critical objects
authorTim Beale <timbeale@catalyst.net.nz>
Tue, 30 Oct 2018 03:14:33 +0000 (16:14 +1300)
committerTim Beale <timbeale@samba.org>
Mon, 5 Nov 2018 02:43:24 +0000 (03:43 +0100)
commit3338a3e257fa9f285ae639d6ac382e3e234be90e
tree3ccca64a58091fae7a932798ce3b0b8ff564365d
parentbe51b51263a460e9790b8a210914a68499af7953
traffic: Machine accounts were generated as critical objects

Due to the userAccountControl flags we were specifying, the machine
accounts were all created as critical objects. When trying to populate
1000s of machine accounts in a DB, this makes replication unnecessarily
slow (because it has to replicate them all twice).

This patch changes it so when we're just creating machine accounts for
the purpose of populating a semi-realistic DB, we jsut use the default
WORKSTATION_TRUST_ACCOUNT flag.

Note that for the accounts used for traffic-replay, we apparently need
the existing flags in order for the DC to accept certain requests.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Mon Nov  5 03:43:24 CET 2018 on sn-devel-144
python/samba/emulate/traffic.py