CVE-2020-25718 s4-rpc_server: Change sid list functions to operate on a array of...
authorAndrew Bartlett <abartlet@samba.org>
Thu, 30 Sep 2021 21:47:29 +0000 (10:47 +1300)
committerJule Anger <janger@samba.org>
Mon, 8 Nov 2021 09:52:12 +0000 (10:52 +0100)
commit4b78fe5c13b2fdb66d0c186829bfb9c064deac50
tree93415aee0975dd2abab6c9e91886aec0ac879175
parent8c1092d8ec02a0b8110515a9d904a46184df9f06
CVE-2020-25718 s4-rpc_server: Change sid list functions to operate on a array of struct dom_sid

This is instead of an array of struct dom_sid *.

The reason is that auth_user_info_dc has an array of struct dom_sid
(the user token) and for checking if an RODC should be allowed
to print a particular ticket, we want to reuse that a rather
then reconstruct it via tokenGroups.

This also avoids a lot of memory allocation.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14558

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
source4/rpc_server/common/sid_helper.c
source4/rpc_server/drsuapi/getncchanges.c
source4/rpc_server/netlogon/dcerpc_netlogon.c