git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3a4f236) | patch
s3: libsmbclient: Fix return value if cli_open() fails
authorRikard Falkeborn <rikard.falkeborn@gmail.com>
Thu, 16 May 2019 19:03:42 +0000 (21:03 +0200)
committerJeremy Allison <jra@samba.org>
Sun, 19 May 2019 17:34:21 +0000 (17:34 +0000)
commit730037504d2c29e43a075d22b17f761f1d2e837a
tree26d61164a717c863c1d3e806088d3df7ba1bee90tree
parent3a4f23636d60799a3d3b80d395ef7af710195919commit | diff
s3: libsmbclient: Fix return value if cli_open() fails

Returning -1 in a function with bool as return value type is the same
as returning true. Change to false to indicate the error.

Detected by the help of cppcheck.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/libsmb/libsmb_file.c diff | blob | history
Samba Shared Repository