ctdb-common: For AF_PACKET socket types, protocol is in network order
authorAmitay Isaacs <amitay@gmail.com>
Thu, 3 Mar 2016 03:17:40 +0000 (14:17 +1100)
committerKarolin Seeger <kseeger@samba.org>
Mon, 4 Jul 2016 07:14:28 +0000 (09:14 +0200)
commit7e73588cdd3280a1866c27a9309cb5fc65b21a00
treefe1e7df5399f790d5c7ba343e07553e25839485e
parent8368f6fb9617f066d88deb41da902c5c59aa280e
ctdb-common: For AF_PACKET socket types, protocol is in network order

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11770

From man page of packet(7):

                                             protocol is the  IEEE  802.3
   protocol  number  in  network  byte  order.  See the <linux/if_ether.h>
   include file for a list of allowed protocols.  When protocol is set  to
   htons(ETH_P_ALL),  then all protocols are received.

Protocol argument was changed from network order to host order wrongly
in commit 9f8395cb7d49b63a82f75bf504f5f83920102b29.

Specifying "protocol" field to socket(AF_PACKET, ...) call only affects
the packets that are recevied.  So use protocol = 0 when sending raw
packets.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Mar  4 12:58:50 CET 2016 on sn-devel-144

(cherry picked from commit f5b6a5b13406c245ab9cc8c1699483af9eb21f88)
ctdb/common/system_linux.c