git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9b73235) | patch
s3:mod:posixacl_xattr: use NUMERIC_CMP in posixacl_xattr_entry_compare
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Sun, 7 Apr 2024 03:12:56 +0000 (15:12 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 23 Apr 2024 01:33:29 +0000 (01:33 +0000)
commit8b2605a5d9cc14f9e6ddf2db704cdca2f523d74e
tree090e9c5031aaec8dfc551eea74cdfbadf3b2ed57tree
parent9b73235d4957a487fbb3214fdfda6461a2cf0b21commit | diff
s3:mod:posixacl_xattr: use NUMERIC_CMP in posixacl_xattr_entry_compare

The first subtraction was between uint16_t, so is safe with 32 bit
int, but the second compared uint32_t, so was not safe.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/modules/posixacl_xattr.c diff | blob | history
Samba Shared Repository