repl_metadata: Avoid silent skipping an object during DRS (due to RODC rename collisions)
authorGarming Sam <garming@catalyst.net.nz>
Wed, 14 Feb 2018 00:32:33 +0000 (13:32 +1300)
committerGarming Sam <garming@samba.org>
Thu, 15 Feb 2018 09:18:42 +0000 (10:18 +0100)
commit9952eda7a1923971f77f3183cfa4c505386b30ee
tree1fb91c66e8e7cf0346201fd584406ec9a63051ad
parent59fa9e7ecf84bd4c2469e9a6835855769c4f6287
repl_metadata: Avoid silent skipping an object during DRS (due to RODC rename collisions)

No error code was being set in this case, and so, we would commit the
HWM and UDV without actually having all the updates.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13269

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Thu Feb 15 10:18:42 CET 2018 on sn-devel-144
selftest/knownfail.d/rodc_repl [deleted file]
source4/dsdb/samdb/ldb_modules/repl_meta_data.c