Re-fix bug 5202 - cannot change ACLs on writable file with "dos filemode=yes"
authorJeremy Allison <jra@samba.org>
Fri, 8 Jan 2010 18:24:34 +0000 (10:24 -0800)
committerKarolin Seeger <kseeger@samba.org>
Mon, 11 Jan 2010 11:12:59 +0000 (12:12 +0100)
commit9bd957580360ed7a0f98b02d1e03d7fcaf8a878e
tree874e086472efbf7cf473a26010d4b49d2b4dbedd
parent5fd32614f147a045aaee30ed9cf62e42ac6e30d8
Re-fix bug 5202 - cannot change ACLs on writable file with "dos filemode=yes"

This bug re-occurred for 3.3.x and above.

The reason is that to change a NT ACL we now have to open the file requesting
WRITE_DAC and WRITE_OWNER access. The mapping from POSIX "w" to NT permissions
in posix_acls doesn't add these bits when "dos filemode = yes", so even though
the permission or owner change would be allowed by the POSIX ACL code, the
NTCreateX call fails with ACCESS_DENIED now we always check NT permissions
first.

Added in the mapping from "w" to WRITE_DAC and WRITE_OWNER access.

Jeremy.
source/smbd/posix_acls.c