s3:pam_smbpass: don't call openlog() or closelog() from pam_smbpass
authorBjörn Jacke <bj@sernet.de>
Tue, 26 May 2009 13:40:21 +0000 (15:40 +0200)
committerKarolin Seeger <kseeger@samba.org>
Wed, 27 May 2009 07:47:09 +0000 (09:47 +0200)
commit9ff6c8d528f5d04dd9246645d1106718dbfdf6dc
tree6b3df3f26ccd124b6a9d3bb61e7545c6819f7d25
parenta03099aa862b1a0fa4eb89f9be875f9781c39fb1
s3:pam_smbpass: don't call openlog() or closelog() from pam_smbpass

Patch from Steve Langasek with tiny fixes by me to make it apply to master.
Also see Debian bug #434372 and bugzilla #4831.

Calling openlog() or closelog() inside a pam module is not good as these
functions are not stackable and no program won't re-do openlog() just because a
pam module might have called closelog().
(cherry picked from commit 5c34ea94bdf9e3efb6743e52dd3c0c0088cff7d8)
source3/pam_smbpass/pam_smb_acct.c
source3/pam_smbpass/pam_smb_auth.c
source3/pam_smbpass/pam_smb_passwd.c
source3/pam_smbpass/support.c
source3/pam_smbpass/support.h