git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1a45e5b) | patch
replmd: Avoid passing msg to replmd_process_linked_attribute()
authorTim Beale <timbeale@catalyst.net.nz>
Mon, 19 Nov 2018 22:45:07 +0000 (11:45 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 23 Nov 2018 04:00:22 +0000 (05:00 +0100)
commitb9c5417b523c4c53cb275c12ec84bbc849705bec
tree83125f60e96f525c487c23e47fc5c249f3b49bb4tree
parent1a45e5b136bedfed1fa3a8b87b79da759c3958c4commit | diff
replmd: Avoid passing msg to replmd_process_linked_attribute()

We can prevent anyone from inadvertently adding/removing msg->elements[]
in replmd_process_linked_attribute() by just not passing msg into the
function. Currently we only actually need the source DN and a memory
context for reallocating old_el->values.

The warning comment has been moved to a more appropriate place.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/repl_meta_data.c diff | blob | history
Samba Shared Repository