Fix bug #6911 - Kerberos authentication from vista to samba fails when security blob...
authorJeremy Allison <jra@samba.org>
Thu, 26 May 2011 23:39:30 +0000 (16:39 -0700)
committerKarolin Seeger <kseeger@samba.org>
Sun, 29 May 2011 17:57:18 +0000 (19:57 +0200)
commitc718b7d43bc5616f7f5e110afdf5332a62e04cb8
tree52f1cbc5af27a32ab18ddc76019ce289cefb6018
parent67a9d4bb376d89c4411024164165ca1ed7a0b157
Fix bug #6911 - Kerberos authentication from vista to samba fails when security blob size is greater than 16 kB

We were not correctly checking the output of asn1_start_tag().
asn1_start_tag() returns -1 and sets data->has_error if the
remaining blob size is too short to contain the tag length.
We were checking data->has_error and returning NT_STATUS_OK
(to allow the second asn.1 parse to fail in that case). We
should not be checking data->has_error in this case, but
falling through to the code that already checks the length.

Thanks to Jim for reproducing this for me. We don't get bitten
by this as we announce a max buffer size of 16k, greater than
Windows's 4k, which means that most krb5 spnego packets already
fit.

Jeremy.
source3/smbd/sesssetup.c