ctdb-tools: Avoid filtering stderr when onnode not running in parallel
authorMartin Schwenke <martin@meltin.net>
Tue, 17 Apr 2018 22:05:25 +0000 (08:05 +1000)
committerAmitay Isaacs <amitay@samba.org>
Fri, 27 Apr 2018 04:53:16 +0000 (06:53 +0200)
commitd44fed601d4e867cd2d282df5673753d2aefb0c9
tree39bb84fed4a919c6059c244e28e23f010c2fb545
parentd8741feec533934e02bd54b7bcc4fb71dbe1a1e1
ctdb-tools: Avoid filtering stderr when onnode not running in parallel

stderr_filter() only does anything useful when running in
parallel (i.e. with the -p option).  So, simplify the non-parallel
case by not using stderr_filter().

As a side-effect, this fixes an issue introduced in commit
85a4375788d8ef8345ec390807f18299abdadb20 where local daemon tests
would hang when trying to start daemons with VALGRIND set (to a
valgrind command that does not use --log-file).  This is because
valgrind would keep stderr open for its output so the pipeline
involving stderr_filter() would never complete.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tools/onnode