From: Andrew Bartlett <abartlet@samba.org>
Date: Sun, 26 Sep 2010 02:34:58 +0000 (+1000)
Subject: s4-kerberos Don't segfault if the password isn't specified in keytab generation
X-Git-Tag: samba-4.0.0alpha14~2797
X-Git-Url: http://git.samba.org/?p=samba.git;a=commitdiff_plain;h=0b5a556b76f0d05457c1c370b0f81fba124190a3

s4-kerberos Don't segfault if the password isn't specified in keytab generation

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Sep 26 03:29:34 UTC 2010 on sn-devel-104
---

diff --git a/source4/auth/kerberos/kerberos_util.c b/source4/auth/kerberos/kerberos_util.c
index 37a5ae6f390..76edf0d05aa 100644
--- a/source4/auth/kerberos/kerberos_util.c
+++ b/source4/auth/kerberos/kerberos_util.c
@@ -597,6 +597,13 @@ static krb5_error_code create_keytab(TALLOC_CTX *parent_ctx,
 
 	/* Finally, do the dance to get the password to put in the entry */
 	password_s =  ldb_msg_find_attr_as_string(msg, "secret", NULL);
+
+	if (!password_s) {
+		/* There is no password here, so nothing to do */
+		talloc_free(mem_ctx);
+		return 0;
+	}
+
 	if (add_old && kvno != 0) {
 		old_secret = ldb_msg_find_attr_as_string(msg, "priorSecret", NULL);
 	} else {