From: Andreas Schneider <asn@samba.org>
Date: Fri, 17 Jul 2015 08:54:17 +0000 (+0200)
Subject: s3-auth: Fix a possible null pointer dereference
X-Git-Tag: samba-4.1.20~7
X-Git-Url: http://git.samba.org/?p=samba.git;a=commitdiff_plain;h=e889ea33b03e2f88e285549793356f70930b53d8

s3-auth: Fix a possible null pointer dereference

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11404

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

(cherry picked from commit 109ff388fd5e1306189d680a8f964a69374f1b01)

Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Tue Jul 21 19:02:14 CEST 2015 on sn-devel-104
---

diff --git a/source3/auth/auth_ntlmssp.c b/source3/auth/auth_ntlmssp.c
index f99bd44d7ed..dae5f776a0b 100644
--- a/source3/auth/auth_ntlmssp.c
+++ b/source3/auth/auth_ntlmssp.c
@@ -153,7 +153,9 @@ NTSTATUS auth3_check_password(struct auth4_context *auth4_context,
 							&server_info,
 							user_info->client.account_name,
 							user_info->client.domain_name);
-		*server_returned_info = talloc_steal(mem_ctx, server_info);
+		if (NT_STATUS_IS_OK(nt_status)) {
+			*server_returned_info = talloc_steal(mem_ctx, server_info);
+		}
 		return nt_status;
 	}