samba.git
14 years agos3/ldap: also handle DirX return codes
Björn Jacke [Thu, 7 May 2009 15:50:34 +0000 (17:50 +0200)]
s3/ldap: also handle DirX return codes

this is a backport of f238809d236443b8968e1b4b197a55935c7c7e85 from master
(cherry picked from commit 1b040289f14bb22d3b6ab07a452236549d6c9bf6)
(cherry picked from commit 7f1771f26dcc334c32df332545d33937f8602bd6)

14 years agos3:smbd: fix posix acls when setting an ACL without explicit ACE for the owner (bug...
Stefan Metzmacher [Fri, 8 May 2009 12:33:49 +0000 (14:33 +0200)]
s3:smbd: fix posix acls when setting an ACL without explicit ACE for the owner (bug#2346)

The problem of bug #2346 remains for users exported by
winbindd, because create_token_from_username() just fakes
the token when the user is not in the local sam domain. This causes
user_in_group_sid() to give totally wrong results.
In uid_entry_in_group() we need to check if we already
have the full unix token in the current_user struct.
If so we should use the current_user unix token,
instead of doing a very complex user_in_group_sid()
which doesn't give reliable results anyway.

metze
(cherry picked from commit b79eff843be392f3065e912edca1434081d93c44)
(cherry picked from commit cb5c72c0a05a78ff1b86eb02cf5ecd3d7d69623d)
(cherry picked from commit ef0d72513b5404f176186632aab67d7b87039ba2)

14 years agos3/packaging: Fix build on RHEL when ccache is not available.
Karolin Seeger [Wed, 13 May 2009 08:07:56 +0000 (10:07 +0200)]
s3/packaging: Fix build on RHEL when ccache is not available.

This fixes bug #5832.
Patch was provided by D.L. Meyer <dlmeyer [at] uiuc.edu>.

Thanks for reporting and providing the patch!

Karolin
(cherry picked from commit 42e0cb8c0a1b8470ac8e9ad1c5a741e299debb8f)
(cherry picked from commit b2205a7697598729f85cb767621b8c610654053c)
(cherry picked from commit 07d40da10ac9aab58cb7684dc39f6c1ffeb2d020)

14 years agoFix bug 5798: "CFLAGS info lost in configure"
Volker Lendecke [Thu, 2 Oct 2008 00:17:04 +0000 (02:17 +0200)]
Fix bug 5798: "CFLAGS info lost in configure"

picked from 9097a67de

Volker
(cherry picked from commit 9ffb1e6f0ded2647efe567912873a1a63e2ffed1)
(cherry picked from commit d3f39da433c22632007a9300d4dab4cda0dfd43e)

14 years agoFix bug #6291 - force user stop working. A previous fix broke the invariant that...
Jeremy Allison [Tue, 28 Apr 2009 18:07:51 +0000 (11:07 -0700)]
Fix bug #6291 - force user stop working. A previous fix broke the invariant that *uid is always initialized on return from create_token_from_username(). Restore it. Jeremy.
(cherry picked from commit 09b76c57098ed4d11855000ae31cd346cb9a765d)
(cherry picked from commit 191e4c415e7008070110970ba51f3f82dc493a8b)

14 years agos3/docs: Remove unnecessary .sp.
Karolin Seeger [Wed, 6 May 2009 14:06:59 +0000 (16:06 +0200)]
s3/docs: Remove unnecessary .sp.

Karolin
(cherry picked from commit 4a4dc776b2f0ca813abcf4f47f0d5721f75f3e6a)
(cherry picked from commit 6a617a9677da9df8f70cf2039245cfb5ce3d94c3)
(cherry picked from commit 8c5771422bf25dba0638c3419ac14f0841b94293)
(cherry picked from commit fe7c528089815a533402b5a3b247db94a2c70d6d)

14 years agos3-docs: Fix Bug #6331. Document "net dom join/net dom unjoin".
Günther Deschner [Wed, 6 May 2009 13:43:23 +0000 (15:43 +0200)]
s3-docs: Fix Bug #6331. Document "net dom join/net dom unjoin".

Guenther
(cherry picked from commit e398f1e91575909d2a90fab1e6f00804815a0b2f)
(cherry picked from commit e19dddb2b438b75dcd995aaa763fcbe55d7de5cc)
(cherry picked from commit 457313c37904246fb0628ab0f2ef207dc38b2f85)

14 years agos3/packaging: Add keyutils-devel to build requires.
Karolin Seeger [Mon, 4 May 2009 13:54:34 +0000 (15:54 +0200)]
s3/packaging: Add keyutils-devel to build requires.

This should fiy bug #5853. Thanks to D.L. Meyer <dlmeyer [at] uiuc.edu>
for reporting.

Karolin
(cherry picked from commit d8de7e3193143ec50d86adc704123ca240a8f549)
(cherry picked from commit c89c2db8c51bd3cede2e2e8fb58214971eda4129)
(cherry picked from commit 437136465e52a893a3f866bda40d4c9d812693d9)

14 years agos3/docs: Fix typo.
Karolin Seeger [Mon, 4 May 2009 13:17:30 +0000 (15:17 +0200)]
s3/docs: Fix typo.

Karolin
(cherry picked from commit c2eb0d87a2436614741119ebd14fda05b42a2ddd)
(cherry picked from commit 98c238a54dbe3e64262252a9fb38b382c53c1bcf)
(cherry picked from commit b118a70a9fc96e8ae5e51ebc8abc9076b07fdf27)

14 years ago3.2 samr bug 6301: fix samr_ConnectVersion enum which is 32bit not 16bit.
Günther Deschner [Tue, 28 Apr 2009 23:55:09 +0000 (01:55 +0200)]
3.2 samr bug 6301: fix samr_ConnectVersion enum which is 32bit not 16bit.

Port of 67ca76c288eb095ae to 3.2

Signed-off-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 0b0b0499f0ba60cfff943fa2200a6534c0a3f816)

14 years agos3/docs: Fix typos.
Karolin Seeger [Sun, 3 May 2009 07:55:46 +0000 (09:55 +0200)]
s3/docs: Fix typos.

That fixes bug #4247. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!

Karolin
(cherry picked from commit eaf949947c2eb03363c4b6f588f87b70110d6ff7)
(cherry picked from commit cea79d1fbf44b0d5bff5aa12962fb3d3cb61c367)
(cherry picked from commit 226620d0ed221da983b4f662fcef14906588f1bd)
(cherry picked from commit 07835177469d7699a478014f7a4a556684705bb6)

14 years agos3/docs: Fix typo.
Karolin Seeger [Sun, 3 May 2009 07:35:55 +0000 (09:35 +0200)]
s3/docs: Fix typo.

This fixes bug #4245. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!

Karolin
(cherry picked from commit 579c91581f5b6d5341a12923fe6cde377223caff)
(cherry picked from commit 49caab4044e47236594c6688f202aed555b9da61)
(cherry picked from commit 139f95c85f96e7ccba024283608f9ee5990f6676)
(cherry picked from commit 148aa12c89df78718addd7b72c79a8005e680509)

14 years agos3/docs: Fix serveral typos.
Karolin Seeger [Wed, 29 Apr 2009 12:12:01 +0000 (14:12 +0200)]
s3/docs: Fix serveral typos.

This fixes bug #4315.
Thanks to Felipe Augusto van de Wiel <faw [at] cathedrallabs [dot] org>!

Karolin
(cherry picked from commit 3422b9c546cdd262bd747e1e737c2b6479b4d21e)
(cherry picked from commit 3da62734fffa99cde1084beeb69e94a7bc623dde)
(cherry picked from commit b487a48c876fcaf88ec3fb4b05bacdd9b0bd8cd0)
(cherry picked from commit ccea7f24879265291615802982b67451ddb818ad)

14 years agos3-selftest: test wbinfo --allocate-uid/gid.
Günther Deschner [Wed, 22 Apr 2009 21:48:24 +0000 (23:48 +0200)]
s3-selftest: test wbinfo --allocate-uid/gid.

Guenther
(cherry picked from commit c3843c40b5c426910a184dcef3b17283e6e224e9)
(cherry picked from commit 679be14a080dfcbbbc9403ff0fc67b61073a357e)

14 years agoFix profile acls in some corner cases
Simo Sorce [Wed, 22 Apr 2009 13:12:58 +0000 (09:12 -0400)]
Fix profile acls in some corner cases

Always add back the real original owner of the directory in the ACE List after
we steal its ACE for the Administrators group.
(cherry picked from commit 8e438431a1447fd482c107fbe0aee3af49afe068)

14 years agoAvoid duplicate aces
Simo Sorce [Wed, 22 Apr 2009 10:15:21 +0000 (06:15 -0400)]
Avoid duplicate aces

When adding arbitrary aces to an nt_ace_list we need to make sure we
are not actually adding a duplicate.
add_or_replace_ace() takes care of doing the right thing.
(cherry picked from commit 958207e321f330426536bf7e936b30fa2efffddc)

14 years agoAdd comment explaining the previous fix.
Jeremy Allison [Wed, 22 Apr 2009 10:04:22 +0000 (03:04 -0700)]
Add comment explaining the previous fix.
Jeremy.
(cherry picked from commit 9da82269dc6d9da3c0393a85e0217bf22cd2fe5c)

14 years agoFix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but...
Jeremy Allison [Wed, 22 Apr 2009 09:24:27 +0000 (02:24 -0700)]
Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but not returning a result.
Jeremy
(cherry picked from commit e7687dd9ca244a53fdf2312a78cdb028dd8971d5)

14 years agos3:docs: document the --request-timeout option of net
Stefan Metzmacher [Fri, 3 Apr 2009 10:21:17 +0000 (12:21 +0200)]
s3:docs: document the --request-timeout option of net

metze
(cherry picked from commit cdbbc81bad5d53397bf80898cf68d8867cf64cba)
(cherry picked from commit 1d1e859c4e08fed1775a170ccff459f3a18e13ba)
(cherry picked from commit 8775968526046f040a2e6ba8697d719b5e3bced8)
(cherry picked from commit b9395cb807b7c2a72ec6ba3cb7429bd2add79c54)

14 years agos3:net: add --request-timeout option
Stefan Metzmacher [Thu, 26 Mar 2009 19:32:55 +0000 (20:32 +0100)]
s3:net: add --request-timeout option

metze
(cherry picked from commit 257809558bfab3e45703cf8be76357596392a3ea)
(cherry picked from commit e20b8706401d1a4eee0fe494825deef6ab23ab23)
(cherry picked from commit d80e02de5714aaa650bef91767ce0775bd2392f5)
(cherry picked from commit 340c23e150061a20af72e9b9a1762d288660861c)

14 years agos3:net_rpc: don't shutdown a cli_state passed from the caller
Stefan Metzmacher [Thu, 26 Mar 2009 19:29:24 +0000 (20:29 +0100)]
s3:net_rpc: don't shutdown a cli_state passed from the caller

This fixes a crash bug if we timeout in net rpc trustdom list.

metze

(cherry picked from commit c0dfe0cf80ee50f395912b7d6aec0d87febd34c0)
(cherry picked from commit d87563604ca7b1c18c5a84d76726c2a99dc454f8)
(cherry picked from commit cba4214b963983730bedc792e391b5435889597a)
(cherry picked from commit 34bf50b0302ff112af52088b93b40b1bcaf002e8)

14 years agos3:registry: Prevent creation of keys containing the '/' character.
Michael Adam [Fri, 17 Apr 2009 09:40:17 +0000 (11:40 +0200)]
s3:registry: Prevent creation of keys containing the '/' character.

Even though "net conf setparm abc/def comment xyz" does not
create a broken registry we do not want such keys to be created.
Since we get problems accessing these with "net registry" since
the registry code treats the '/' sign as a separator as a lower
level.

This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.

Michael
(cherry picked from commit de6f09988d84752e5333cba1fa69c5a685e903b7)

15 years agoWHATSNEW: Rewording. samba-3.2.11
Karolin Seeger [Fri, 17 Apr 2009 09:57:41 +0000 (11:57 +0200)]
WHATSNEW: Rewording.

Karolin
(cherry picked from commit 642afabf26dbb7d0f73c15c5502a90020f65a914)

15 years agoVERSION: Raise version number upt to 3.2.11.
Karolin Seeger [Fri, 17 Apr 2009 09:52:02 +0000 (11:52 +0200)]
VERSION: Raise version number upt to 3.2.11.

Karolin
(cherry picked from commit aaf5c25489b916d4892ce757bb5c0f32f9910c59)

15 years agoWHATSNEW: Update changes since 3.2.10.
Karolin Seeger [Fri, 17 Apr 2009 08:42:31 +0000 (10:42 +0200)]
WHATSNEW: Update changes since 3.2.10.

Karolin
(cherry picked from commit c63dc9866e84461a7a8359958d6bcf753c51d125)

15 years agoWhen doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
Jeremy Allison [Thu, 16 Apr 2009 22:14:37 +0000 (15:14 -0700)]
When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
Jeremy.
(cherry picked from commit 72f55ca71c2d9b4c24866b7e1418fa4c17948db6)

15 years agoDon't look up local user for remote changes, even when root.
Jim McDonough [Thu, 16 Apr 2009 14:42:59 +0000 (16:42 +0200)]
Don't look up local user for remote changes, even when root.
(cherry picked from commit 1c47bcb5b24ab360d5e632bbf3dcbc7d1d9f6fc4)

15 years agos3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3.
Günther Deschner [Wed, 15 Apr 2009 23:42:35 +0000 (01:42 +0200)]
s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3.

LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.

Guenther
(cherry picked from commit 597be402e40ff880b595ae49a8600b932365cbcb)
(cherry picked from commit f049fb5643f93cc4806ada5db8e591bbe4cb9204)

15 years agoFix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
Jeremy Allison [Wed, 15 Apr 2009 21:09:32 +0000 (14:09 -0700)]
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
What a difference a name makes... :-). Just because something is missnamed
SA_RIGHT_SAM_OPEN_DOMAIN, when it should actually be SA_RIGHT_SAM_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
(cherry picked from commit 3591c95beaed3abfa10b1579e377b0103647a177)

15 years agopackaging(RHEL): add cifs.upcall binary and manpage to client package
Michael Adam [Mon, 8 Sep 2008 13:51:57 +0000 (15:51 +0200)]
packaging(RHEL): add cifs.upcall binary and manpage to client package

Michael
(cherry picked from commit f1b80bcb58b8aa5c586835dc201ce674b3417835)
(cherry picked from commit b4c58d49902d62f25aa0c9289d1857aa2636c028)
(cherry picked from commit 6d308951c5b0fec988685f64f040f0770b537efb)

15 years agos3-loadparm: Fix resume command typo for "printing = vlp".
Guenther Deschner [Mon, 13 Apr 2009 16:44:54 +0000 (09:44 -0700)]
s3-loadparm: Fix resume command typo for "printing = vlp".
(cherry picked from commit 8203f5f3890afec3ec631f822b0f2e5ddd262b9a)

15 years agoFix a memleak in an unlikely error path in change_notify_create()
Volker Lendecke [Sat, 11 Apr 2009 20:54:06 +0000 (13:54 -0700)]
Fix a memleak in an unlikely error path in change_notify_create()
(cherry picked from commit 7284b7bb226990abce91d40782bf4e592e2f7b4d)

15 years agoFix bug #6254 - PUT/GET produces an error in IPv6 to a smb-server(3.3)
Jeremy Allison [Fri, 10 Apr 2009 05:46:31 +0000 (22:46 -0700)]
Fix bug #6254 - PUT/GET produces an error in IPv6 to a smb-server(3.3)
has parameter "msdfs root = yes"
This was broken by the refactoring around create_file().
MSDFS pathname processing must be done FIRST.
MSDFS pathnames containing IPv6 addresses can
be confused with NTFS stream names (they contain
":" characters.
Jeremy.
(cherry picked from commit eb29aa406f14397e3c55e559e2c02da6eb6c4cbd)

15 years agos3/popt.h: Fix typo.
Karolin Seeger [Tue, 7 Apr 2009 18:01:27 +0000 (20:01 +0200)]
s3/popt.h: Fix typo.

This used to be commit 8da2fa36 in master.

Karolin
(cherry picked from commit 3df28fce45ce552df2c0815597fc1808ea08b363)
(cherry picked from commit 89542c9dc4fede1547886b480791322f0497f277)

15 years agos3/loadparm: Fiy typos.
Karolin Seeger [Tue, 7 Apr 2009 18:00:47 +0000 (20:00 +0200)]
s3/loadparm: Fiy typos.

This used to be commit 44588095 in master.

Karolin
(cherry picked from commit 7648c51afaf844e576935dadc0d66a94e2cad28b)
(cherry picked from commit a3081c94e64d226328885191212bd1ba46add09e)

15 years agos3/gpo_ldap: Fix typo.
Karolin Seeger [Tue, 7 Apr 2009 17:58:47 +0000 (19:58 +0200)]
s3/gpo_ldap: Fix typo.

This used to be commit a103222e in master.

Karolin
(cherry picked from commit a33677c8a80925965a4023785fc3a221d2ed9585)
(cherry picked from commit 7038846d514b9ea25d991bc72b807921ab1ee158)

15 years agos3/smbconf_reg: Fix typo.
Karolin Seeger [Tue, 7 Apr 2009 17:58:14 +0000 (19:58 +0200)]
s3/smbconf_reg: Fix typo.

This used to be commit 6343cab3 in master.

Karolin
(cherry picked from commit 56e877662dd6da64b348803c24e85f60ee6b3d85)
(cherry picked from commit 36cb36581208f754b14e2a955fbd886e6c82cfaa)

15 years agos3-examples: Fix Bug #6205. Correct sample smb.conf share configuration.
Günther Deschner [Mon, 6 Apr 2009 10:45:46 +0000 (12:45 +0200)]
s3-examples: Fix Bug #6205. Correct sample smb.conf share configuration.

Thanks to Jeffrey Riaboy <dakusan@castledragmire.com>.

Guenther
(cherry picked from commit 2b1fe2c98f4e0013dee4cbae62dc36cdd4085c7d)
(cherry picked from commit d3d4baecb89ddac6d460269e126a60b99f687a5b)

15 years agoFix smbd crash for close_on_completion
Volker Lendecke [Sat, 28 Mar 2009 18:58:45 +0000 (19:58 +0100)]
Fix smbd crash for close_on_completion

handle_trans() can talloc_free "conn" if the client requests
close_on_completion. "state" is a talloc_child of conn, so it will be gone when
we later free state->data et al.
(cherry picked from commit 51ecc77eeabe5fc89e4d1b1fb8a15c71614d4049)

15 years agoAllow pdbedit to change a user rid/sid. Based on a fix from Alexander
Jeremy Allison [Thu, 2 Apr 2009 03:14:35 +0000 (20:14 -0700)]
Allow pdbedit to change a user rid/sid. Based on a fix from Alexander
Zagrebin <alexz@visp.ru>.
Jeremy.
(cherry picked from commit 5b43fff78081541f642b07a70b03c6d5902e42dd)

15 years agoWHATSNEW: Rewording. samba-3.2.10
Karolin Seeger [Wed, 1 Apr 2009 11:42:32 +0000 (13:42 +0200)]
WHATSNEW: Rewording.

Karolin
(cherry picked from commit c572b19ffcff201f9b8ad0af3bf5434dfe5d06bf)

15 years agoVERSION: Raise version number up to 3.2.10.
Karolin Seeger [Wed, 1 Apr 2009 11:32:07 +0000 (13:32 +0200)]
VERSION: Raise version number up to 3.2.10.

Karolin
(cherry picked from commit 887420a30dbb178f29ee9313f2c19dd1b3c3c5e9)

15 years agoWHATSNEW: Prepare WHATSNEW for 3.2.10.
Karolin Seeger [Wed, 1 Apr 2009 11:31:23 +0000 (13:31 +0200)]
WHATSNEW: Prepare WHATSNEW for 3.2.10.

A release a day... ;-)

Karolin
(cherry picked from commit c9bee29bed290777a4ab32ffe2ed88029a3a6348)

15 years agoTidy up some convert_string_internal error cases, found by Andrew Bartlett.
Jeremy Allison [Wed, 1 Apr 2009 01:29:30 +0000 (18:29 -0700)]
Tidy up some convert_string_internal error cases, found by Andrew Bartlett.
Jeremy.
(cherry picked from commit 3797ddb3acc713cc200114e9e27dfb3901e5cdf1)

15 years agos3: fix the fix for bug #6195 - dont let smbd child processes panic
Michael Adam [Wed, 1 Apr 2009 10:23:07 +0000 (12:23 +0200)]
s3: fix the fix for bug #6195 - dont let smbd child processes panic

This patch makes sure the original and temporary TDBs are closed
_before_ the rename. Originally, the open TDB was renamed, and so
the name passdb.tdb.tmp stayed around in the db context. Hence
upon client connect, the smbd children died because reinit_after_fork()
calling tdb_reopen_all() would try to reopen passdb.tdb.tmp which
existed no longer...

Michael
(cherry picked from commit 1ab40fbca806f1136dd1d65edd688beb5ec592c7)

15 years agoWHATSNEW: Fix announcement.
Karolin Seeger [Tue, 31 Mar 2009 14:12:30 +0000 (16:12 +0200)]
WHATSNEW: Fix announcement.

Karolin
(cherry picked from commit b3e838884350e4da19660f0c1078aabd8e55536b)

15 years agoVERSION: Raise version number up to 3.2.9. samba-3.2.9
Karolin Seeger [Tue, 31 Mar 2009 08:44:20 +0000 (10:44 +0200)]
VERSION: Raise version number up to 3.2.9.

Karolin
(cherry picked from commit d999a7e99804bf71f62c905452a720c20016f8e9)

15 years agoWHATSNEW: Update changes.
Karolin Seeger [Tue, 31 Mar 2009 08:43:47 +0000 (10:43 +0200)]
WHATSNEW: Update changes.

Karolin
(cherry picked from commit bee6e86c71278563d52f9bde19ffb4bda2a35d1b)

15 years agoEnsure files starting with multiple dots are hidden
Jeremy Allison [Mon, 30 Mar 2009 22:09:10 +0000 (15:09 -0700)]
Ensure files starting with multiple dots are hidden
if "hide dot files" is set. Thanks to Barry Kelly <bkelly.ie@gmail.com>
for pointing this one out.
Jeremy.
(cherry picked from commit 5bdc16a867b9c14682b327c79f79834edcd6842d)

15 years agoWHATSNEW: Update changes.
Karolin Seeger [Mon, 30 Mar 2009 10:43:17 +0000 (12:43 +0200)]
WHATSNEW: Update changes.

Karolin
(cherry picked from commit e7634cd0c17d0fa4dcca5952313b6af750477dec)

15 years agoFix the problem of 3.0.x passdb databases being version
Jeremy Allison [Sat, 28 Mar 2009 04:26:56 +0000 (21:26 -0700)]
Fix the problem of 3.0.x passdb databases being version
3 but using a different hash calculation than 3.2.x passwd
databases (also version 3). Introduces a minor version
number.
Jeremy.
(cherry picked from commit 10b518592e616ecfaadd829ecd0674a04510b422)

15 years ago[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errno
Derrell Lipman [Fri, 27 Mar 2009 21:10:04 +0000 (17:10 -0400)]
[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errno

Fixed.

It turns out there were a number of places where cli_resolve_path() was called
and the error path upon that function failing did not set errno. There were a
couple of places the failure handling code did set errno to ENOENT, so I made
them all consistent, although I think better errno choices for this condition
exist, e.g.  EHOSTUNREACH.

Derrell
(cherry picked from commit f4e68b09a6ba30d968bccfad8bf6b67b4456b111)

15 years agoFix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly...
Jeremy Allison [Fri, 27 Mar 2009 19:09:51 +0000 (12:09 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly. For the clustering case.
Clustered setups should have only ever used
the unsigned version of TDB_DATA in the
first place so they can't be in this mess :-).
Just do the normal upgrade in the clustered case.
Jeremy.
(cherry picked from commit 52fe104996439db24a7e6b17baa7fec47ba230bb)

15 years agoWHATSNEW: Update changes since 3.2.8.
Karolin Seeger [Fri, 27 Mar 2009 13:04:38 +0000 (14:04 +0100)]
WHATSNEW: Update changes since 3.2.8.

Karolin
(cherry picked from commit 7fa853e490be446a6da2086e1749b59a8f741e09)

15 years agoTry and fix the build farm RAW-STREAMS errors. Ordering of
Jeremy Allison [Thu, 26 Mar 2009 22:33:39 +0000 (15:33 -0700)]
Try and fix the build farm RAW-STREAMS errors. Ordering of
modules shouldn't matter, so as vfs_streams_depot doesn't
implement get/setxattrs then call into the full VFS stack
at the top.
Jeremy
(cherry picked from commit a1d9b31a0c8a38dbfa94f578830d5d35695aff3b)

15 years agoFix bug #6224 - nmbd waits 5 minutes at startup before checking if it needs to run...
Jeremy Allison [Thu, 26 Mar 2009 19:13:28 +0000 (12:13 -0700)]
Fix bug #6224 - nmbd waits 5 minutes at startup before checking if it needs to run elections
Fix logic bug that causes nmbd to wait 5 minutes before
looking for a master browser. This one is *old* :-). Thanks
for Simo for bugging me on this.
Jeremy.
(cherry picked from commit 857c2e4407a0f4fcee721372ffed5366bc3051f9)

15 years agos3: parse_packet can return NULL which is then dereferenced in match_mailslot_name
Tim Prouty [Thu, 26 Mar 2009 18:28:37 +0000 (11:28 -0700)]
s3: parse_packet can return NULL which is then dereferenced in match_mailslot_name
(cherry picked from commit d097e3f918853cf642c4a51f6ed3a4d8c85d283e)

15 years agoFix a scary "fill_share_mode_lock failed" message
Volker Lendecke [Thu, 26 Mar 2009 11:24:50 +0000 (12:24 +0100)]
Fix a scary "fill_share_mode_lock failed" message

To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.

Change the corresponding debug message to level 10 and explain more.
(cherry picked from commit f73d4cf1fcfd8f9e2543a222faed133472fd890c)

15 years agos3-net: Fix Bug #6102. NetQueryDisplayInformation could return wrong information.
Günther Deschner [Thu, 26 Mar 2009 09:41:11 +0000 (10:41 +0100)]
s3-net: Fix Bug #6102. NetQueryDisplayInformation could return wrong information.

Guenther
(cherry picked from commit 490ed838f2626893bb623ea6ad8d79595c8c44c4)

15 years agos3-net: Fix Bug #6193: avoid messing with sync_context in fetch_database_to_ldif().
Günther Deschner [Wed, 25 Mar 2009 16:06:57 +0000 (17:06 +0100)]
s3-net: Fix Bug #6193: avoid messing with sync_context in fetch_database_to_ldif().

We absolutely need to avoid messing with the sync_context as that breaks the
stream of replication data coming from the DC (only replicates ~350 instead of
~4000 groups).

Guenther
(cherry picked from commit 1a1823c357fb8e01ac0e8c8749e6f5004bf3cf3e)

15 years agowinbind_pam: fix gcc 4.4 compile warning
Volker Lendecke [Tue, 24 Mar 2009 22:34:13 +0000 (15:34 -0700)]
winbind_pam: fix gcc 4.4 compile warning
(cherry picked from commit 4a99f2f006e6324cf38b68f0f390daf52f24b1b3)

15 years agoFix two memleaks in the encryption code
Volker Lendecke [Tue, 24 Mar 2009 22:29:35 +0000 (15:29 -0700)]
Fix two memleaks in the encryption code

ntlmssp_seal_packet creates its own signature data blob, which we then
have to free.

Jeremy, please check and merge appropriately (Yes, I'm asking you to do the
janitor work, I want you to *look* at this :-))

Volker
(cherry picked from commit 525af716cd52500a4e3dccf9eeb9ea85f86be7ca)

15 years agos3:smbd: if we allow trans2 on the IPC$ share, then we have to allow transs2 too.
Stefan Metzmacher [Tue, 24 Mar 2009 18:50:49 +0000 (11:50 -0700)]
s3:smbd: if we allow trans2 on the IPC$ share, then we have to allow transs2 too.

Otherwise we'll confuse the client signing engine, when we reply an error to each transs2.

metze
(cherry picked from commit e217138a36b1ba1eff164aecfa52ba6fe8864747)

15 years agoFix bug 6097
Volker Lendecke [Tue, 24 Mar 2009 10:07:16 +0000 (11:07 +0100)]
Fix bug 6097

A client sent a SID with authority 0 and 0 sub-authorities. W2k3 replies with
NT_STATUS_INVALID_SID, even if other SIDs in the list are valid.

Thanks to Pavel <wylda@volny.cz> for the bug report!
(cherry picked from commit bb76066e8797599e5ca75821a686e32dd0c97a74)

15 years agos3:dsgetdcname: use parentheses in if condition to make negation clear
Björn Jacke [Mon, 23 Mar 2009 11:26:03 +0000 (12:26 +0100)]
s3:dsgetdcname: use parentheses in if condition to make negation clear

Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 87b428e424e2e3cca975ecd0efed327e72950a1d)
(cherry picked from commit ca58d12b6513beb40c14fcab2758cf21af0179f3)

15 years agos3-krb5: Fix Coverity #762 (REVERSE_INULL).
Günther Deschner [Fri, 20 Mar 2009 10:11:04 +0000 (11:11 +0100)]
s3-krb5: Fix Coverity #762 (REVERSE_INULL).

Guenther
(cherry picked from commit 97190ae184dff6450b1390c854f7426e2ee3f980)
(cherry picked from commit 0f7757e94bfa35d22a7349d78578685c0dba22d7)
(cherry picked from commit 66faa809847ad60b8027ae86068f8d62c0d181ed)

15 years agos3-krb5: Fix Coverity #722 (RESOURCE_LEAK).
Günther Deschner [Thu, 19 Mar 2009 15:42:54 +0000 (16:42 +0100)]
s3-krb5: Fix Coverity #722 (RESOURCE_LEAK).

Guenther
(cherry picked from commit 1524abd8bf12d82e1fb0063585fc9a465fc7bf9c)
(cherry picked from commit 3517388b5d5439ffe3f9629aaf826fa1dfbb4ba7)
(cherry picked from commit 5ce5a9bea994d7db3d352d0800333d0fd0b833df)

15 years agos3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Stefan Metzmacher [Wed, 18 Mar 2009 06:56:51 +0000 (07:56 +0100)]
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests

Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".

The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.

cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().

The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.

metze
(cherry picked from commit 880fbc4e8cd67de73c4bcda94489eb1e1422a04b)
(cherry picked from commit 70466990b4b7c68ae95dbbcf741cd3f41f2dd0b3)
(cherry picked from commit d01cca5e3ddb925696d49a1ea728013ec1032372)
(cherry picked from commit 6c13360e195189f7afc70c5fda6ef27f46145b0b)

15 years agofix build on old Heimdal based systems
Björn Jacke [Mon, 16 Mar 2009 00:51:09 +0000 (01:51 +0100)]
fix build on old Heimdal based systems

Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 011ad7245d53a716c4c766f5ef8d317bb3a53d0f)
(cherry picked from commit 5eaa2541f19277bc00c47b944739c6732f90809b)

15 years agoAllow DFS client paths to work when POSIX pathnames have been
Jeremy Allison [Thu, 19 Mar 2009 03:54:13 +0000 (20:54 -0700)]
Allow DFS client paths to work when POSIX pathnames have been
selected (we need to path in pathname /that/look/like/this).
Jeremy.
(cherry picked from commit 0c11c2deee7ab9d281df6df91b793b7f1c1764a4)

15 years agoFix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Jeremy Allison [Thu, 19 Mar 2009 02:58:01 +0000 (19:58 -0700)]
Fix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.
(cherry picked from commit 985ba585207e840caa17c3d87d93ef1ba5f15cbb)

15 years agoFix bug 6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
Jeremy Allison [Wed, 18 Mar 2009 21:31:01 +0000 (14:31 -0700)]
Fix bug 6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
This is a really nasty one to fix as in order to successfully update the
passdb.tdb we must do the equivalent of a tdbbackup to move to the new hash
values before we do the upgrade.
Jeremy.
(cherry picked from commit b5d794d5de872bcf757c8021c103b6b3d320b8db)

15 years agoFix a valgrind error
Volker Lendecke [Tue, 17 Mar 2009 10:22:41 +0000 (11:22 +0100)]
Fix a valgrind error

Found in "make test" -- if we can't connect at all, "cli" is uninitialized
(cherry picked from commit 8ffe7b07df753568d960155c27d57de2bd99993f)

15 years agoFix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members
Volker Lendecke [Mon, 16 Mar 2009 12:17:04 +0000 (13:17 +0100)]
Fix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members

Thanks to François Legal <devel@thom.fr.eu.org> for reporting this bug
(cherry picked from commit e6a23d498bfd4bbe19cecf24ba3f94af83c9bf8b)

15 years agoFix a malloc/talloc mismatch when cli_initialise() fails
Volker Lendecke [Sun, 15 Mar 2009 10:58:07 +0000 (11:58 +0100)]
Fix a malloc/talloc mismatch when cli_initialise() fails
(cherry picked from commit 20d378eebfcaca53f456f0fbae39d46031729de7)

15 years agoDon't log NDR_PRINT_DEBUG at level 0, this always ends up in syslog
Volker Lendecke [Sat, 14 Feb 2009 12:18:28 +0000 (13:18 +0100)]
Don't log NDR_PRINT_DEBUG at level 0, this always ends up in syslog

I think we eventually need to pass down the debuglevel here.
(cherry picked from commit b2f6110d3ac5d60054a7e5a1d365f0a1f67a2f42)

15 years agofixed a bug in message handling for code the change notify code
Andrew Tridgell [Tue, 10 Mar 2009 05:45:45 +0000 (16:45 +1100)]
fixed a bug in message handling for code the change notify code

The change notify code registered a separate message handler for each
tree connect. This registration uses the global messaging context.

The messaging code would consider a 2nd registration for the same
messaging type as being an 'update' of the handler, rather than a new
handler. It also would only call the first handler in the linked list
for a given message type when dispatching messages.

This patch changes the messaging code to allow for multiple
registrations of the same message type, and allow for multiple calls
to different messaging handler for one incoming message.

This fixes the problem with the test_notify_tcon() test that I
recently committed to the S4 smbtorture
(cherry picked from commit 89e340e09fbdc375c0aa85506add525b8ba5dcd0)
(cherry picked from commit 733881d22f9864ea371b29d7d1817fb4af6b865c)

15 years agoRevert "Revert "Fix a valgrind error / segfault in dns_register_smbd()""
Volker Lendecke [Tue, 10 Mar 2009 15:08:38 +0000 (16:08 +0100)]
Revert "Revert "Fix a valgrind error / segfault in dns_register_smbd()""

This reverts commit 96c57d26ed790b3e94c935cc4faf5661ea43a80c.
(cherry picked from commit 045933cf5bf27fbb704e446cf8686f2f761a1ced)

15 years agoRevert "Fix a valgrind error / segfault in dns_register_smbd()"
Volker Lendecke [Tue, 10 Mar 2009 14:46:16 +0000 (15:46 +0100)]
Revert "Fix a valgrind error / segfault in dns_register_smbd()"

This reverts commit e47d2091136c4d870bb91b8a84eb9f6fd78eb971.

No idea why, but this causes timeouts in the build farm all over the place
(cherry picked from commit 0cf74151286238890ae0da0863e3a5807f4f3d81)

15 years agoFix a valgrind error / segfault in dns_register_smbd()
Volker Lendecke [Tue, 10 Mar 2009 13:06:05 +0000 (14:06 +0100)]
Fix a valgrind error / segfault in dns_register_smbd()
(cherry picked from commit 4624451b7b78695b3f84e7fff91018ee9df0e589)
(cherry picked from commit e47d2091136c4d870bb91b8a84eb9f6fd78eb971)

15 years agos3:lib: interfaces.c isn't used in the configure tests anymore
Stefan Metzmacher [Mon, 9 Mar 2009 11:35:21 +0000 (12:35 +0100)]
s3:lib: interfaces.c isn't used in the configure tests anymore

libreplace always provides the getifaddr() function.

This fixes the build on sles8.

metze
(cherry picked from commit 1410490fe769bc79f98b4ab364685c7aed253e09)
(cherry picked from commit bac96af2053996f28894458fce87e84c5c2356ff)
(cherry picked from commit 8c50d89743a8e9024d238c6613ceea35cf160aa0)

15 years agoGet the sense of the integer wrap test the right way around. Sorry.
Jeremy Allison [Fri, 6 Mar 2009 05:46:38 +0000 (21:46 -0800)]
Get the sense of the integer wrap test the right way around. Sorry.
Jeremy.
(cherry picked from commit b4d9e92dfaa84b1361cdd6e49ad88e252c8fed4d)

15 years agoNow we're allowing a lower bound for auth_len, ensure we
Jeremy Allison [Fri, 6 Mar 2009 05:02:22 +0000 (21:02 -0800)]
Now we're allowing a lower bound for auth_len, ensure we
also check for an upper one (integer wrap).
Jeremy.
(cherry picked from commit f58a6c9e08b2b44399e0333b1358522aec70bbee)

15 years agoFix bug #6161 - smbclient corrupts source path in tar mode
Jeremy Allison [Fri, 6 Mar 2009 01:16:54 +0000 (17:16 -0800)]
Fix bug #6161 - smbclient corrupts source path in tar mode
This was my fault. I broke the smbclient tar argument processing
in creating the string for chdir when removing pstrings.
Jeremy.
(cherry picked from commit 750f9d94b0a1208d45cc117df68042e1d83044bf)

15 years agoComplete the fix for bug 6100
Volker Lendecke [Thu, 5 Mar 2009 23:12:55 +0000 (15:12 -0800)]
Complete the fix for bug 6100

According to [MS-RPCE].pdf, section 2.2.2.11:

----
A client or a server that (during composing of a PDU) has allocated more space
for the authentication token than the security provider fills in SHOULD fill in
the rest of the allocated space with zero octets. These zero octets are still
considered to belong to the authentication token part of the PDU.<36>
----

RPC implementations are allowed to send padding bytes at the end of an auth
footer. Windows 7 makes use of this.

Thanks to Nick Meier <nmeier@microsoft.com>

Volker
(cherry picked from commit 91e2cd86e24cead352f07cc1a6b4a8e3a364adb5)

15 years agoFix an uninitialized variable warning
Volker Lendecke [Wed, 4 Mar 2009 13:00:03 +0000 (14:00 +0100)]
Fix an uninitialized variable warning
(cherry picked from commit 43ea27319933f3b49b61decde8321d9162cfd9ef)

15 years agos3/docs: Add missing full stop.
Karolin Seeger [Fri, 27 Feb 2009 10:09:59 +0000 (11:09 +0100)]
s3/docs: Add missing full stop.

Karolin
(cherry picked from commit 2ab9d365cfceb28c1280566b6fe8ec3767e18149)
(cherry picked from commit aff67e24f3675ace3c69c210aa387bc008f1cbbc)
(cherry picked from commit 0a9aff0bca4c49de0f87e496f62053787777f61d)

15 years agoInitialize the id_map status in idmap_ldap to avoid surprise
Bo Yang [Fri, 27 Feb 2009 19:37:19 +0000 (11:37 -0800)]
Initialize the id_map status in idmap_ldap to avoid surprise
(cherry picked from commit c23dffc930cb9852bb98c2a92f0215cf73f4572d)

15 years agos3: fix guest auth when winbindd is running
Steven Danneman [Fri, 27 Feb 2009 16:35:18 +0000 (08:35 -0800)]
s3: fix guest auth when winbindd is running

This fix is very subtle.  If a server is configured with "security = share"
and "guest ok = yes" and winbindd is running authorization will fail during
tree connect.

This is due to our inability to map the guest sid S-1-5-21-X-501 to a uid
through sid_to_uid().  Winbindd is unaware of the hard coded mapping
between this sid and whatever uid the name in lp_guestaccount() is assigned.
So sid_to_uid() fails and we exit create_token_from_username() without
ever calling pdb_getsampwsid() which IS aware of the hard coded mapping.

This patch just reorganizes the code, moving sid_to_uid() down to the
block of code in which it is needed, avoiding this early failure.
(cherry picked from commit 671812696217fe1337562b661d5131be79797f1c)

15 years agoFix more POSIX path lstat calls. Fix bug where close can return
Jeremy Allison [Wed, 25 Feb 2009 22:55:19 +0000 (14:55 -0800)]
Fix more POSIX path lstat calls. Fix bug where close can return
failure if we have a pending modtime and the containing directory
of the file has been renamed (there is no POSIX "update time by
fd" call). This can't happen on Windows as the rename will fail
if there are open files beneath it. Will add a torture test
for this.
Jeremy.
(cherry picked from commit 5fb3b5e903c08013074ba473399ddee30f6c328f)

15 years agoFix use of streams modules with CIFSFS client.
Jeremy Allison [Wed, 25 Feb 2009 21:48:30 +0000 (13:48 -0800)]
Fix use of streams modules with CIFSFS client.
Jeremy.
(cherry picked from commit 161dc96c1147f637b5ef78bb3f543f6d5e0618c6)

15 years agoAllow set attributes on a stream fnum to be redirected to the base filename.
Jeremy Allison [Wed, 25 Feb 2009 01:59:19 +0000 (17:59 -0800)]
Allow set attributes on a stream fnum to be redirected to the base filename.
Fixes the new RAW-STREAMS torture test.
Jeremy.
(cherry picked from commit 73d0c3143eedb5a9fd4d154aaf42d20ba6a19a1f)

15 years ago Fix guest mounts
Steve French [Tue, 24 Feb 2009 23:10:19 +0000 (17:10 -0600)]
Fix guest mounts
     guest session setup, login (user id) as anonymous.
    This patch is for samba bugzilla bug 4640.

Signed-off-by: Shirish Pargaonkar <shirishp@us.ibm.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
(cherry picked from commit 5e6b019d70fef2ad082fc414053c131294bdeb49)

15 years agocifs mount fix for handling -V parameter
Steve French [Tue, 24 Feb 2009 18:52:08 +0000 (12:52 -0600)]
cifs mount fix for handling -V parameter

also syncs with 3-3 mount.cifs

Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
(cherry picked from commit e831cd78ee3cf89abee058a475540955fad423ce)

15 years agoprefer gssapi header files from subdirectory
Björn Jacke [Sun, 22 Feb 2009 18:46:40 +0000 (19:46 +0100)]
prefer gssapi header files from subdirectory

this fixes some compile time noise on FreeBSD 7
(cherry picked from commit 1bfdbb093f7c5e434ea3e653d389e1ccec578af6)
(cherry picked from commit de96e1a82d6e92c00a0ab3020db8d7c0284aadb1)

15 years agoall BSDs use this evironment variable
Björn Jacke [Sat, 21 Feb 2009 23:43:38 +0000 (00:43 +0100)]
all BSDs use this evironment variable

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit cd6ae0de52164dd6f50b3614f2511acb3eb15993)
(cherry picked from commit 1ad5f50bdab761c7d3894e94f8fe3b171ec1b219)
(cherry picked from commit bc53054616d442b1b28086181d81776f1c33834f)

15 years agos3/docs: Fix typo in man mount.cifs.
Karolin Seeger [Mon, 23 Feb 2009 08:24:50 +0000 (09:24 +0100)]
s3/docs: Fix typo in man mount.cifs.

Thanks to Tobias Stoeckmann for reporting!

Karolin
(cherry picked from commit 09a7f93f6be66a8f2a124e49b4effe2b5863f01d)
(cherry picked from commit fdb5c65fc51784b6a159748ec4df3953b7d2c1cb)
(cherry picked from commit b19f58ccd088a10e487a1261cadb4f3f41987391)

15 years agoFix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
Jeremy Allison [Fri, 20 Feb 2009 16:25:29 +0000 (08:25 -0800)]
Fix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
As the NFSv4 ACL mapping code doesn't map write directory into the DELETE_CHILD
permission bit (which we require before allowing a delete) no one can delete
files without an explicit DELETE_CHILD bit set on the directory. Add this mapping.
Jeremy.
(cherry picked from commit 44e0e830c4c413054bdb30a62629993c4391c492)

15 years agos3/docs: Fix several typos.
Karolin Seeger [Fri, 20 Feb 2009 08:20:16 +0000 (09:20 +0100)]
s3/docs: Fix several typos.

This fixes bug #6127.
Thanks to Justin T Pryzby <justinpryzby [at] users.sourceforge.net>
for the review!

Karolin
(cherry picked from commit 54dbb030e2c6fed0abd0a3a89d08dad9b8a201a1)
(cherry picked from commit a4548e41c6f12e4703249c53ad3dc727d2839931)
(cherry picked from commit 0d68e3d54b8f0bf2861edc7ac3b26c2f48f242eb)

15 years agoBackport the semantics of when to delete alternate data streams on a file truncate.
Jeremy Allison [Thu, 19 Feb 2009 19:55:56 +0000 (11:55 -0800)]
Backport the semantics of when to delete alternate data streams on a file truncate.
Needed to fully support stream semantics.
Jeremy.
(cherry picked from commit cdcb9bbf47396a7213edafeabb009920bb4e16b7)