Günther Deschner [Wed, 6 May 2009 13:43:23 +0000 (15:43 +0200)]
s3-docs: Fix Bug #6331. Document "net dom join/net dom unjoin".
Guenther
(cherry picked from commit
e398f1e91575909d2a90fab1e6f00804815a0b2f)
Günther Deschner [Wed, 6 May 2009 13:43:00 +0000 (15:43 +0200)]
s3-docs: Fix "net eventlog dump" syntax in manpage.
Guenther
(cherry picked from commit
bf197a9c0ab8a58a775277896d40617d36279288)
Günther Deschner [Mon, 4 May 2009 15:25:41 +0000 (17:25 +0200)]
s3-rpcclient: print more infolevels in printer and driver info levels.
Guenther
(cherry picked from commit
d77c45675744895b01d905f7f27ae55e64264c26)
Günther Deschner [Wed, 6 May 2009 08:20:52 +0000 (10:20 +0200)]
s3-printing: fix debug statement in virtual registry layer
(key_driver_fetch_keys).
Guenther
(cherry picked from commit
7ac1ae8d1c3bcf4d001e29fdc1ee314dcbe3df76)
Günther Deschner [Tue, 5 May 2009 23:10:33 +0000 (01:10 +0200)]
s3-printing: simplify print_queue helper functions and return WERROR.
Guenther
(cherry picked from commit
9966541f89b45834cdf63060202621f885bf9f5c)
Michael Adam [Wed, 6 May 2009 00:08:33 +0000 (02:08 +0200)]
s3:loadparm: handle registry config source in file_list - fixes bug #6320
Michael
(cherry picked from commit
4842e45d59dbd6c9ac138e796d30fcf747807d1c)
Volker Lendecke [Wed, 6 May 2009 10:00:49 +0000 (12:00 +0200)]
Fix Coverity ID 897: REVERSE_INULL
tprouty [Tue, 5 May 2009 01:17:04 +0000 (01:17 +0000)]
s3 onefs: Turn up the debug level for non-error cases
tprouty [Sat, 2 May 2009 00:28:38 +0000 (00:28 +0000)]
s3: Fix trans2 path to use case-insensitive stat optimization
Often times before creating a file, a client will first query to see
if it already exists. Since some systems have a case-insensitive stat
that is called from unix_convert, we can definitively return
STATUS_NO_SUCH_FILE to the client without scanning the whole
directory.
This code path is taken from trans2querypathinfo, but trans2findfirst
still does a full directory scan even though the get_real_filename
(the case-insensitive stat vfs call) can prevent this.
This patch adds the get_real_filename call to the trans2find* path,
and also changes the vfs_default behavior for
SMB_VFS_GET_REAL_FILENAME. Previously, in the absence of a
get_real_filename implementation, we would fallback to the full
directory scan. The default behavior now returns -1 and sets errno to
EOPNOTSUPP. This allows SMB_VFS_GET_REALFILENAME to be called from
trans2* and unix_convert.
Steven Danneman [Tue, 5 May 2009 21:42:19 +0000 (14:42 -0700)]
s3:onefs.so Change system function names
Addendum to
c49730e1. Use newer cookie conversion names.
Volker Lendecke [Sat, 2 May 2009 09:31:37 +0000 (11:31 +0200)]
Fix bug 6302: Give the VFS a chance to read from 0-byte files
Michael Adam [Tue, 5 May 2009 15:46:20 +0000 (17:46 +0200)]
s3:loadparm: use the returnvalue of service_ok() in process_smbconf_service().
Michael
(cherry picked from commit
0ca795ef4fab1f880c2b76d7fe8f0aabb302b6e2)
Günther Deschner [Tue, 5 May 2009 19:12:33 +0000 (21:12 +0200)]
s3-ldap: fix more callers of smbldap_dn_talloc() that were passing a NULL context.
Guenther
(cherry picked from commit
fee4c99be494b9679c414d6ba1938aa88adeacd3)
Günther Deschner [Tue, 5 May 2009 16:50:48 +0000 (18:50 +0200)]
s3-ldapsam: Fix Bug #6313: ldapsam_update_sam_account() crashes while doing talloc_free on malloced memory.
Guenther
(cherry picked from commit
5b37df21f6af52d20ad3a25361b1d7faa51308d1)
Günther Deschner [Tue, 5 May 2009 17:38:58 +0000 (19:38 +0200)]
error-codes: add some more group specific windows error codes.
Guenther
(cherry picked from commit
e7a8577df1e92982ff717a62280f86e3b0384d54)
Günther Deschner [Fri, 1 May 2009 00:17:23 +0000 (02:17 +0200)]
s3-printing: Fix driver upload for Xerox 4110 PS printer driver.
We need to allow to set filesystem capabilities from the default vfs in
create_conn_struct() in order to find mixed-case filenames. Thanks Volker!
This one was hard to find, so a little longer explanation:
When a Windows client tries to upload e.g. the Xerox 4110 PS driver, the client
first uploads the driver files to the [print$] share. Some of them (in this case
the Windows Postscript drivers) are with uppercase filenames while some of them
(like the PPD file) are in lowercase. After the driver upload the client issues
the spoolss_AddPrinterDriverEx() call with level 6. There the client tries to
add the PPD file with an uppercase filename (while having stored it in lowercase
on the server). The internal spoolss add driver functions then could not find the
appropriate filename while trying to move them to the version subdirectory (in
this case W32X86/3) and fails then entire spoolss_AddPrinterDriverEx() call.
With this fix, the convert_unix_name() name finds the correct file and
the spoolss_AddPrinterDriverEx() succeeds.
Guenther
(cherry picked from commit
fe839b65a7b4e8d5e085287b7d33ee1f970fe7c2)
Günther Deschner [Tue, 5 May 2009 10:54:21 +0000 (12:54 +0200)]
s3-pam_winbind: Fix Bug 6253: Use correct value for password expiry calculation.
Patch from Blindauer Emmanuel <samba@mooby.net>.
Guenther
(cherry picked from commit
290449aeae950d7490cdcf9d601052fc45bb84dd)
Steven Danneman [Mon, 4 May 2009 22:02:17 +0000 (15:02 -0700)]
s3:onefs.so fix issue with missing entries when enumerating directories
This bug prompted several, fairly large changes to the of OneFS's
readdirplus() within Samba.
One fundamental problem is that we kept our cache cursor pointed at the
next entry to be returned from onefs_readdir(), while the resume cookie
needed to refill the cache such that our cursor would be on this entry,
was located in the previous cache entry. This meant that to correctly handle
seekdir() cases which could be found within the existing cache, and cases
where a cache reload was needed, required that the cache always hold
at least two entries: the entry we wished to return, and the previous entry
which held the resume cookie. Since the readdirplus() syscall gives us no
guarantee that it will always return these two direntries, there was a
fundamental problem with this design.
To fix this problem, I have rearchitected the onefs_readdir() path to keep
its pointer on the entry which contains the resume_cookie, not the entry
which will be returned next. Essentially, I changed onefs_readdir() from a
"return an entry then increment the cursor" model to "increment the cursor
then return an entry". By doing this, we only require that a single entry
be within the cache: the entry containing the resume cookie.
Second, there have been numerous off-by-one bugs in my implementation of
onefs_seekdir() which did a mapping between the 64-bit resume cookie
returned by readdirplus() and its own monotonically increasing "location"
offset. Furthermore, this design caused a somewhat frequent waste of
cycles, as in some cases we'd need to re-enumerate the entire directory to
recover the current "location" from an old resume cookie. As this code was
somewhat difficult to understand, prone to bugs, and innefficient in some
cases I decided it was better to wholesale replace it now, rather than later.
It is possible to algorithmically map the 64-bit resume cookies from
readdirplus() into 32-bit offset values which SMB requires. The onefs.so
module now calls into a system library to do this conversion. This greatly
simplifies both the seekdir() and telldir() paths and is more efficient.
Jeremy Allison [Mon, 4 May 2009 15:31:40 +0000 (08:31 -0700)]
Fix bug #6315 smbd crashes doing vfs_full_audit on IPC$ close event.
The underlying problem
is that once SMBulogoff is called, all server_info contexts associated with the
vuid should become invalid, even if that's the context being currently used by
the connection struct (tid). When the SMBtdis comes in it doesn't need a valid
vuid value, but the code called inside vfs_full_audit always assumes that there
is one (and hence a valid conn->server_info pointer) available.
This is actually a bug inside the vfs_full_audit and other code inside Samba,
which should only indirect conn->server_info on calls which require AS_USER to
be set in our process table. I could fix all these issues, but there's no
guarentee that someone might not add more code that fails this assumption, as
it's a hard assumption to break (it's usually true).
So what I've done is to ensure that on SMBulogoff the previously used
conn->server_info struct is kept around to be used for print debugging purposes
(it won't be used to change to an invalid user context, as such calls need
AS_USER set). This isn't strictly correct, as there's no association with the
(now invalid) context being freed and the call that causes conn->server_info to
be indirected, but it's good enough for most cases.
The hard part was to ensure that once a valid context is used again (via new
sessionsetupX calls, or new calls on a still valid vuid on this tid) that we
don't leak memory by simply replacing the stored conn->server_info pointer. We
would never actually leak the memory (as all conn->server_info pointers are
talloc children of conn), but with the previous patch a malicious client could
cause many server_info structs to be talloced by the right combination of SMB
calls. This new patch introduces free_conn_server_info_if_unused(), which
protects against the above.
Jeremy.
Karolin Seeger [Mon, 4 May 2009 13:17:30 +0000 (15:17 +0200)]
s3/docs: Fix typo.
Karolin
Volker Lendecke [Mon, 4 May 2009 12:39:56 +0000 (14:39 +0200)]
Do not crash in ctdbd_traverse if ctdbd is not around
Volker Lendecke [Mon, 4 May 2009 10:36:13 +0000 (12:36 +0200)]
Increase debug level of "create_connection_server_info failed" message
I don't think we should unconditionally send every refused connection attempt
to a share to syslog, that's where all debug level 0 messages end up.
Geza Gemes [Sun, 3 May 2009 20:13:36 +0000 (22:13 +0200)]
Fix bug 6136: New AFS syscall conventions
Haven't checked this myself, but as I've already got several reports that Samba
won't compile against current OpenAFS anymore, I just believe Geza Gemes. This
patch only affects AFS code, so it should not hurt anything else.
Volker
Karolin Seeger [Sun, 3 May 2009 07:55:46 +0000 (09:55 +0200)]
s3/docs: Fix typos.
That fixes bug #4247. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!
Karolin
(cherry picked from commit
eaf949947c2eb03363c4b6f588f87b70110d6ff7)
Karolin Seeger [Sun, 3 May 2009 07:35:55 +0000 (09:35 +0200)]
s3/docs: Fix typo.
This fixes bug #4245. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!
Karolin
(cherry picked from commit
579c91581f5b6d5341a12923fe6cde377223caff)
Jeremy Allison [Tue, 28 Apr 2009 18:07:51 +0000 (11:07 -0700)]
Fix bug #6291 - force user stop working.
A previous fix broke the invariant that *uid is always
initialized on return from create_token_from_username().
Restore it.
Jeremy.
Michael Adam [Thu, 30 Apr 2009 23:15:38 +0000 (01:15 +0200)]
s3:config.sub: clean some space/tab mixup that git complains about
Michael
(cherry picked from commit
384c1aaa8ee8879b6cc4bc34dfc4d3c9fa11667b)
Michael Adam [Thu, 30 Apr 2009 23:10:10 +0000 (01:10 +0200)]
s3:config.sub: replace old FSF address by the web site url.
Michael
(cherry picked from commit
f3308b91d75356a83e99aade7e88d2cd1edc2042)
Michael Adam [Thu, 30 Apr 2009 23:09:13 +0000 (01:09 +0200)]
s3:config.sub: move to GPLv3
Michael
(cherry picked from commit
62a69994f252f7cc98ef12bc39a25a2ee25afb0a)
Michael Adam [Thu, 30 Apr 2009 22:53:49 +0000 (00:53 +0200)]
s3:update config.sub from gnu.org (2009-04-17)
as requested in bug #6292.
This is taken from
http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD
Michael
(cherry picked from commit
f81c02c3f31a4700d32aff884254fcd752797be7)
Michael Adam [Thu, 30 Apr 2009 23:13:30 +0000 (01:13 +0200)]
s3:config.guess: clean some whitespace/tab mixtures that git complains about
Michael
(cherry picked from commit
faaa306c6ae7b00fa5e53321203f072776eefa0a)
Michael Adam [Thu, 30 Apr 2009 23:06:34 +0000 (01:06 +0200)]
s3:config.guess: replace old FSF address by the web site url.
Michael
(cherry picked from commit
d230ac7b322827930de2e1b922cd4b6a597c933f)
Michael Adam [Thu, 30 Apr 2009 23:04:55 +0000 (01:04 +0200)]
s3:config.guess: move to GPLv3
(cherry picked from commit
fee78294589a02090887233ad112c69d3a5bd383)
Michael Adam [Thu, 30 Apr 2009 22:52:43 +0000 (00:52 +0200)]
s3:update config.guess form gnu.org (version 2009-04-27)
as requested in bug #6292.
This is taken from
http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD
Michael
(cherry picked from commit
1188c78f53fb7d56f4bf61c41fe635b639a311fd)
Günther Deschner [Thu, 30 Apr 2009 21:37:26 +0000 (23:37 +0200)]
s3-netapi: Fix Bug #6309: support remote unjoining of Windows 2003 or greater.
Found by David Markey <admin@dmarkey.com>. Thanks!
Guenther
(cherry picked from commit
ab4b8c9c0438bc5afca17e3ebf05dde6f98bc0aa)
Günther Deschner [Thu, 30 Apr 2009 21:36:24 +0000 (23:36 +0200)]
wkssvcs: add WKSSVC_JOIN_FLAGS_IGNORE_UNSUPPORTED_FLAGS join flag.
Guenther
(cherry picked from commit
26b9c9370ce047ecc732082b2b554ffc295ae406)
Günther Deschner [Thu, 30 Apr 2009 14:49:50 +0000 (16:49 +0200)]
s3-printing: rework move_driver_file_to_download_area() a bit for clarity.
Guenther
(cherry picked from commit
baf78506895b8bd50433058ba0f18e1aaf8aeee5)
Günther Deschner [Thu, 30 Apr 2009 10:30:10 +0000 (12:30 +0200)]
s3-lsa: use LSA_POLICY_MODE flags in _lsa_GetSystemAccessAccount().
Guenther
(cherry picked from commit
af5a71d5280984a7d707e39fb522ecc7e1b71436)
Günther Deschner [Thu, 30 Apr 2009 12:16:01 +0000 (14:16 +0200)]
s3-nss_wins: Fix unresolved ldb symbols in libnss_wins.so.
The objects for this module should probably be cleaned up once.
Guenther
(cherry picked from commit
eee446a94841a5df97b3a47c7076ef52fb5ccdcf)
Günther Deschner [Thu, 30 Apr 2009 09:19:42 +0000 (11:19 +0200)]
s3-spoolss: avoid referring to uid 0 in spoolss server (use sec_initial_uid() instead).
Guenther
(cherry picked from commit
d22965e2e596c8ad78f5330398d43d96bf564773)
Günther Deschner [Wed, 29 Apr 2009 23:25:23 +0000 (01:25 +0200)]
s3-printing: use move_driver_file_to_download_area() to avoid code duplication.
Guenther
(cherry picked from commit
233bfb25c9443688f74c506348b0a7b34489e1d1)
Günther Deschner [Wed, 29 Apr 2009 23:07:31 +0000 (01:07 +0200)]
s3-printing: add move_driver_file_to_download_area().
Guenther
(cherry picked from commit
a2a155bee59c7e849a492933d1ea5769e409bac5)
Volker Lendecke [Thu, 30 Apr 2009 11:37:19 +0000 (13:37 +0200)]
Re-import the v3-3 version of str_list_make().
The merged version behaves differently: "Domain Users" is parsed into two
values, as it does not look at quotes. Samba3 users depend on the ability do
say for example
valid users = "domain users"
which would not work anymore with the merged version.
Thanks to Björn Jacke for testing this!
Volker
Karolin Seeger [Thu, 30 Apr 2009 07:33:43 +0000 (09:33 +0200)]
WHATSNEW: Add new net service subcommands to the WHATSNEW.
Karolin
Karolin Seeger [Thu, 30 Apr 2009 07:27:43 +0000 (09:27 +0200)]
WHATSNEW: Add some WHATSNEW improvements.
Karolin
Karolin Seeger [Wed, 29 Apr 2009 12:44:59 +0000 (14:44 +0200)]
WHATSNEW: Correct WHATSNEW.
Karolin
Günther Deschner [Wed, 29 Apr 2009 12:29:25 +0000 (14:29 +0200)]
s3-test: make it possible to find the built vlp in "make test".
Guenther
(cherry picked from commit
3316ae9d75dfe6c7a960938c9503367880510079)
Jelmer Vernooij [Wed, 22 Apr 2009 21:54:10 +0000 (23:54 +0200)]
Specify explicit path to vlp, for those not having vlp in $PATH.
(cherry picked from commit
79177c1d36e125b08aa4d6e0e42e9a97f625b3c8)
Karolin Seeger [Wed, 29 Apr 2009 12:12:01 +0000 (14:12 +0200)]
s3/docs: Fix serveral typos.
This fixes bug #4315.
Thanks to Felipe Augusto van de Wiel <faw [at] cathedrallabs [dot] org>!
Karolin
(cherry picked from commit
3422b9c546cdd262bd747e1e737c2b6479b4d21e)
Karolin Seeger [Wed, 29 Apr 2009 10:45:39 +0000 (12:45 +0200)]
WHATSNEW: Update WHATSNEW.
Karolin
Karolin Seeger [Wed, 29 Apr 2009 10:38:28 +0000 (12:38 +0200)]
s3/docs: Remove documentation of "use kerberos keytab".
This parameter has been removed with
d96248a9b4655.
Karolin
(cherry picked from commit
b6eab68c20f0914cb946f05ebae2faba67f32806)
Günther Deschner [Mon, 13 Apr 2009 22:01:03 +0000 (00:01 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
Guenther
(cherry picked from commit
6900d61d369961e0c11e590ccdc102169f21cef3)
Günther Deschner [Mon, 13 Apr 2009 22:00:37 +0000 (00:00 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.
Guenther
(cherry picked from commit
5e563ee508d0b3cc87d72ad52d777946ee0537b1)
Günther Deschner [Mon, 13 Apr 2009 21:58:59 +0000 (23:58 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.
Guenther
(cherry picked from commit
d76837f6da2cf735d2b18c97f3b46ae2f04b750d)
Günther Deschner [Wed, 29 Apr 2009 09:46:43 +0000 (11:46 +0200)]
s3-docs: document "net eventlog" in net manpage.
Guenther
(cherry picked from commit
664ff081cadd29a1e750b349ecb23e8402d977cb)
Günther Deschner [Wed, 29 Apr 2009 09:46:12 +0000 (11:46 +0200)]
s3-net: make "net eventlog" help output a little more appropriate.
Guenther
(cherry picked from commit
e89cc775e660183e7126bcfa8fb37496074cf5a1)
Michael Adam [Tue, 28 Apr 2009 23:49:53 +0000 (01:49 +0200)]
s3:smbd/service: switch load_registry_service/shares to use loadparm routines
instead of reading the registry directly with tdb and activating the
configure options by hand.
This eliminates the need for repeating checks done in loadparm.
For instance it disables registry shares without path in the server
as is the case with text based shares.
Michael
(cherry picked from commit
077bcc11257697b243916fbb02cd72b3a122b9ba)
Michael Adam [Tue, 28 Apr 2009 23:31:03 +0000 (01:31 +0200)]
s3:loadparm: refactor process_registry_service out or process_registry_globals
Michael
(cherry picked from commit
fb3b6576127ce837ac711e87c293d1f4cf97473c)
Günther Deschner [Tue, 28 Apr 2009 23:55:09 +0000 (01:55 +0200)]
samr: fix samr_ConnectVersion enum which is 32bit not 16bit.
Volker, please check.
Rafal, haven't we seen this in your tests at sambaxp as well ?
Guenther
(cherry picked from commit
67ca76c288eb095ae59e98927317d51c96c89551)
Günther Deschner [Tue, 28 Apr 2009 23:49:26 +0000 (01:49 +0200)]
svcctl: Fix IDL for svcctl_StartServiceW().
Guenther
(cherry picked from commit
a23fb4663df11b237e94683510d282c286bbeed6)
Michael Adam [Tue, 28 Apr 2009 10:18:23 +0000 (12:18 +0200)]
pm_process():raise level of debug message
Michael
(cherry picked from commit
664da577f931dfd47573d3d77a95afb573fba855)
Michael Adam [Mon, 27 Apr 2009 16:10:14 +0000 (18:10 +0200)]
s3:loadparm: prevent infinite include nesting.
This introduces a hard coded MAX_INCLUDE_DEPTH of 100.
When this is exceeded, handle_include (and hence lp_load) fails.
One could of course implement a more intelligent loop detection
in the include-tree, but this would require some restructuring
of the internal loadparm housekeeping. Maybe as a second improvement
step.
Michael
(cherry picked from commit
d5f2bbdc489b751331e86afae58b0d80c5fedb9c)
Günther Deschner [Mon, 27 Apr 2009 12:39:02 +0000 (14:39 +0200)]
s3-net: make sure to call libnetapi init functions at the top of "net rpc" command.
Without the initialization "net rpc password" will prompt twice for passwords
and will not allow to define the name of the connection admin user.
In the long run we should probably only have one place where to initialize
libnetapi.
Kai, please check.
Guenther
(cherry picked from commit
09ec85715b0e99740156ebb7213eddd1edfea631)
Michael Adam [Mon, 27 Apr 2009 23:24:27 +0000 (01:24 +0200)]
s3:mark registry shares without path unavailable just as with text config
This prevents users from getting access to "/" in misconfigured setups.
Michael
(cherry picked from commit
d16e40b5ef9add630d027ff92e440c44bfb88ef0)
Volker Lendecke [Tue, 28 Apr 2009 09:16:19 +0000 (11:16 +0200)]
Fix annoying debug messages when no snapshots are used
Not being able to open the shadow copy directory is the same as having no
shadow copy support at all. The VFS module should in this case not log with
debug level 0 and set ENOSYS to indicate "no shadow copies used" to the higher
levels.
Günther Deschner [Mon, 27 Apr 2009 23:08:31 +0000 (01:08 +0200)]
s3-svcctl: Fix crash in _svcctl_EnumServicesStatusW().
The resume handle is a unique pointer, always check before dereference.
Guenther
(cherry picked from commit
dd33abf649f4e1479365a2ccc2b41134270ff4ac)
Günther Deschner [Tue, 21 Apr 2009 14:18:51 +0000 (16:18 +0200)]
s3-svcctl: indicate that the spooler is already running if it does.
Guenther
(cherry picked from commit
16b2f4b55a80314aa733dd7f23543c1c3926223c)
Günther Deschner [Fri, 10 Apr 2009 19:39:45 +0000 (21:39 +0200)]
s3-svcctl: fix _svcctl_ControlService.
Guenther
(cherry picked from commit
aa26bdd71969610a4b6a5bdfdd735a1dab31a12c)
Günther Deschner [Fri, 10 Apr 2009 19:10:07 +0000 (21:10 +0200)]
s4-smbtorture: add test_ControlService() to RPC-SVCCTL.
Guenther
(cherry picked from commit
a263eaca499cf2b8a89c3ab04c6ef5e7e9aea396)
Günther Deschner [Fri, 10 Apr 2009 18:55:10 +0000 (20:55 +0200)]
s4-smbtorture: add test_StartServiceW() to RPC-SVCCTL.
Guenther
(cherry picked from commit
f926a4e390e7108dad36ecfffaddb628b23436c0)
Günther Deschner [Mon, 20 Apr 2009 14:49:01 +0000 (16:49 +0200)]
s4-smbtorture: change default service to spooler in RPC-SVCCTL.
Guenther
(cherry picked from commit
ae5dd1219a14e939cb1e3674e6daba7885cc9d51)
Björn Jacke [Sat, 28 Mar 2009 00:21:25 +0000 (01:21 +0100)]
ѕ3/configure: fix regexp for ld version recognition
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
(cherry picked from commit
740c2c4366badc62d017881c9484ee5153b62f94)
Günther Deschner [Fri, 24 Apr 2009 08:02:06 +0000 (10:02 +0200)]
s3-idmap: Fix bug #6286: Call init function for builtin idmap modules before probing for them as shared modules.
idmap-gurus of the world, please check.
Guenther
(cherry picked from commit
67588ca80d654183b8b7b062b9660a506a825f94)
Volker Lendecke [Thu, 23 Apr 2009 12:56:55 +0000 (14:56 +0200)]
Revert "Do not use the file system GET_REAL_FILENAME for mangled names"
This reverts commit
c8cc6da0ab4441ce7b22cf00eed05290e91530c4.
Jeremy Allison [Thu, 23 Apr 2009 09:51:55 +0000 (02:51 -0700)]
Fix coverity #901 - uninitialized data.
Jeremy.
Volker Lendecke [Thu, 23 Apr 2009 09:05:49 +0000 (11:05 +0200)]
Fix Coverity ID 626: DEADCODE
Volker Lendecke [Thu, 23 Apr 2009 08:49:41 +0000 (10:49 +0200)]
Fix Coverity ID 628, Andrew B., please check!
Jeremy Allison [Thu, 23 Apr 2009 08:47:04 +0000 (01:47 -0700)]
Fix coverity #908, #909, uninitialized variable.
Jeremy.
Volker Lendecke [Thu, 23 Apr 2009 08:42:43 +0000 (10:42 +0200)]
Fix Coverity ID 884: DEADCODE
Jeremy Allison [Thu, 23 Apr 2009 08:38:21 +0000 (01:38 -0700)]
Fix coverity #910, uninitialized variable.
Jeremy.
Günther Deschner [Wed, 22 Apr 2009 21:48:24 +0000 (23:48 +0200)]
s3-selftest: test wbinfo --allocate-uid/gid.
Guenther
(cherry picked from commit
59fe99027d0ac972d0d74a24842d6423119c0d21)
Simo Sorce [Wed, 22 Apr 2009 13:12:58 +0000 (09:12 -0400)]
Fix profile acls in some corner cases
Always add back the real original owner of the directory in the ACE List after
we steal its ACE for the Administrators group.
Simo Sorce [Wed, 22 Apr 2009 10:15:21 +0000 (06:15 -0400)]
Avoid duplicate aces
When adding arbitrary aces to an nt_ace_list we need to make sure we
are not actually adding a duplicate.
add_or_replace_ace() takes care of doing the right thing.
Jeremy Allison [Wed, 22 Apr 2009 10:03:04 +0000 (03:03 -0700)]
Add comment explaining the previous fix.
Jeremy.
Jeremy Allison [Wed, 22 Apr 2009 09:54:11 +0000 (02:54 -0700)]
Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but not returning a result.
Jeremy
Günther Deschner [Tue, 21 Apr 2009 11:01:29 +0000 (13:01 +0200)]
s3-secdesc: remove SEC_RIGHT_MAXIMUM_ALLOWED and SEC_RIGHT_SYSTEM_SECURITY.
We had up to three incarnations of these flags in Samba3.
Guenther
(cherry picked from commit
d94bbb3167f3a18d6b8a311557f228e2977249ea)
Günther Deschner [Tue, 14 Apr 2009 23:30:12 +0000 (01:30 +0200)]
s3-secdesc: move all winreg access bits to IDL.
Guenther
(cherry picked from commit
38264bb3b86a3c9da941070f29ec08227c471d2b)
Günther Deschner [Tue, 14 Apr 2009 23:19:30 +0000 (01:19 +0200)]
s3-secdesc: use SEC_FLAG_SYSTEM_SECURITY instead of SEC_RIGHT_SYSTEM_SECURITY.
Guenther
(cherry picked from commit
da92e54236293460e307edd52ca7f1e20c6f23ef)
Günther Deschner [Tue, 14 Apr 2009 23:16:41 +0000 (01:16 +0200)]
s3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHT_MAXIMUM_ALLOWED.
Guenther
(cherry picked from commit
1bb093aea9a4c5996514b10adc39a130cc6859ba)
Günther Deschner [Tue, 14 Apr 2009 23:12:13 +0000 (01:12 +0200)]
s3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHTS_MAXIMUM_ALLOWED.
Guenther
(cherry picked from commit
b5bec1a6d73f5939b306e157937d027a7286163c)
John H Terpstra [Mon, 20 Apr 2009 15:10:20 +0000 (10:10 -0500)]
Added ability to revert to old modules for make revert.
Volker Lendecke [Wed, 15 Apr 2009 11:01:09 +0000 (13:01 +0200)]
Do not use the file system GET_REAL_FILENAME for mangled names
Günther Deschner [Fri, 17 Apr 2009 22:58:12 +0000 (00:58 +0200)]
s3-printing: use ARRAY_SIZE() macro in forms functions.
Guenther
(cherry picked from commit
62480385c1e551448e40b01fff8e9dee318c29c1)
Günther Deschner [Sun, 19 Apr 2009 22:57:53 +0000 (00:57 +0200)]
s3-printing: use sec_initial_uid() instead "0" in print_access_check().
Another babystep in order to make us pass RPC-SPOOLSS.
Guenther
(cherry picked from commit
d9aaf3759ac7fd6ce07a347a0138bdfb27a6f929)
Günther Deschner [Mon, 13 Apr 2009 21:56:59 +0000 (23:56 +0200)]
s4-smbtorture: test all levels in test_GetJob().
Guenther
(cherry picked from commit
5f0c9c57f53f9b0026b4f58f68442a72103c0d7d)
Günther Deschner [Fri, 17 Apr 2009 21:18:24 +0000 (23:18 +0200)]
s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
Also add some become_root()/unbecome_root() pairs which were missing IMHO.
Guenther
(cherry picked from commit
81b18464be170528d5e1549868bcbddbbcd60e1e)
Günther Deschner [Mon, 13 Apr 2009 22:01:21 +0000 (00:01 +0200)]
s3-selftest: enable RPC-SPOOLSS.
Guenther
(cherry picked from commit
6f90cdaf63b5b584c96b9ffc388c9e8df172db67)
Günther Deschner [Fri, 17 Apr 2009 15:21:19 +0000 (17:21 +0200)]
s4-smbtorture: Skip Job pause and resume on paused printers for Samba 3 for now.
Guenther
(cherry picked from commit
fe2828c3536eac18902a059049dd12b9b103f731)
Günther Deschner [Fri, 17 Apr 2009 15:19:38 +0000 (17:19 +0200)]
s4-smbtorture: rework test_EnumPrinterDrivers() a little to succeed with s3.
Yes, I feel dirty for this but promise to come back and fix appropriately.
Guenther
(cherry picked from commit
cb9c0cefaf61cf2c03f92a212dbf6673caa755dd)
Günther Deschner [Fri, 17 Apr 2009 15:14:20 +0000 (17:14 +0200)]
s4-smbtorture: Fix RPC-SPOOLSS-WIN for printers with a lot of jobs in the queue.
Guenther
(cherry picked from commit
81253ec14623ed480905433e5bf5df7982cfbfa4)