Karolin Seeger [Mon, 4 May 2009 13:17:30 +0000 (15:17 +0200)]
s3/docs: Fix typo.
Karolin
(cherry picked from commit
c2eb0d87a2436614741119ebd14fda05b42a2ddd)
(cherry picked from commit
98c238a54dbe3e64262252a9fb38b382c53c1bcf)
Günther Deschner [Tue, 28 Apr 2009 23:55:09 +0000 (01:55 +0200)]
3.2 samr bug 6301: fix samr_ConnectVersion enum which is 32bit not 16bit.
Port of
67ca76c288eb095ae to 3.2
Signed-off-by: Volker Lendecke <vl@samba.org>
Karolin Seeger [Sun, 3 May 2009 07:55:46 +0000 (09:55 +0200)]
s3/docs: Fix typos.
That fixes bug #4247. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!
Karolin
(cherry picked from commit
eaf949947c2eb03363c4b6f588f87b70110d6ff7)
(cherry picked from commit
cea79d1fbf44b0d5bff5aa12962fb3d3cb61c367)
(cherry picked from commit
226620d0ed221da983b4f662fcef14906588f1bd)
Karolin Seeger [Sun, 3 May 2009 07:35:55 +0000 (09:35 +0200)]
s3/docs: Fix typo.
This fixes bug #4245. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!
Karolin
(cherry picked from commit
579c91581f5b6d5341a12923fe6cde377223caff)
(cherry picked from commit
49caab4044e47236594c6688f202aed555b9da61)
(cherry picked from commit
139f95c85f96e7ccba024283608f9ee5990f6676)
Karolin Seeger [Wed, 29 Apr 2009 12:12:01 +0000 (14:12 +0200)]
s3/docs: Fix serveral typos.
This fixes bug #4315.
Thanks to Felipe Augusto van de Wiel <faw [at] cathedrallabs [dot] org>!
Karolin
(cherry picked from commit
3422b9c546cdd262bd747e1e737c2b6479b4d21e)
(cherry picked from commit
3da62734fffa99cde1084beeb69e94a7bc623dde)
(cherry picked from commit
b487a48c876fcaf88ec3fb4b05bacdd9b0bd8cd0)
Günther Deschner [Wed, 22 Apr 2009 21:48:24 +0000 (23:48 +0200)]
s3-selftest: test wbinfo --allocate-uid/gid.
Guenther
(cherry picked from commit
c3843c40b5c426910a184dcef3b17283e6e224e9)
Simo Sorce [Wed, 22 Apr 2009 13:12:58 +0000 (09:12 -0400)]
Fix profile acls in some corner cases
Always add back the real original owner of the directory in the ACE List after
we steal its ACE for the Administrators group.
Simo Sorce [Wed, 22 Apr 2009 10:15:21 +0000 (06:15 -0400)]
Avoid duplicate aces
When adding arbitrary aces to an nt_ace_list we need to make sure we
are not actually adding a duplicate.
add_or_replace_ace() takes care of doing the right thing.
Jeremy Allison [Wed, 22 Apr 2009 10:04:22 +0000 (03:04 -0700)]
Add comment explaining the previous fix.
Jeremy.
Jeremy Allison [Wed, 22 Apr 2009 09:24:27 +0000 (02:24 -0700)]
Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but not returning a result.
Jeremy
Stefan Metzmacher [Fri, 3 Apr 2009 10:21:17 +0000 (12:21 +0200)]
s3:docs: document the --request-timeout option of net
metze
(cherry picked from commit
cdbbc81bad5d53397bf80898cf68d8867cf64cba)
(cherry picked from commit
1d1e859c4e08fed1775a170ccff459f3a18e13ba)
(cherry picked from commit
8775968526046f040a2e6ba8697d719b5e3bced8)
Stefan Metzmacher [Thu, 26 Mar 2009 19:32:55 +0000 (20:32 +0100)]
s3:net: add --request-timeout option
metze
(cherry picked from commit
257809558bfab3e45703cf8be76357596392a3ea)
(cherry picked from commit
e20b8706401d1a4eee0fe494825deef6ab23ab23)
(cherry picked from commit
d80e02de5714aaa650bef91767ce0775bd2392f5)
Stefan Metzmacher [Thu, 26 Mar 2009 19:29:24 +0000 (20:29 +0100)]
s3:net_rpc: don't shutdown a cli_state passed from the caller
This fixes a crash bug if we timeout in net rpc trustdom list.
metze
(cherry picked from commit
c0dfe0cf80ee50f395912b7d6aec0d87febd34c0)
(cherry picked from commit
d87563604ca7b1c18c5a84d76726c2a99dc454f8)
(cherry picked from commit
cba4214b963983730bedc792e391b5435889597a)
Michael Adam [Fri, 17 Apr 2009 09:40:17 +0000 (11:40 +0200)]
s3:registry: Prevent creation of keys containing the '/' character.
Even though "net conf setparm abc/def comment xyz" does not
create a broken registry we do not want such keys to be created.
Since we get problems accessing these with "net registry" since
the registry code treats the '/' sign as a separator as a lower
level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
Karolin Seeger [Fri, 17 Apr 2009 09:57:41 +0000 (11:57 +0200)]
WHATSNEW: Rewording.
Karolin
Karolin Seeger [Fri, 17 Apr 2009 09:52:02 +0000 (11:52 +0200)]
VERSION: Raise version number upt to 3.2.11.
Karolin
Karolin Seeger [Fri, 17 Apr 2009 08:42:31 +0000 (10:42 +0200)]
WHATSNEW: Update changes since 3.2.10.
Karolin
Jim McDonough [Fri, 17 Apr 2009 07:23:50 +0000 (09:23 +0200)]
Merge branch 'v3-2-test' of /home/jmcd/samba/git.samba.org/samba-master into 32-test
Jeremy Allison [Thu, 16 Apr 2009 22:14:37 +0000 (15:14 -0700)]
When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
Jeremy.
Jim McDonough [Thu, 16 Apr 2009 14:42:59 +0000 (16:42 +0200)]
Don't look up local user for remote changes, even when root.
Günther Deschner [Wed, 15 Apr 2009 23:42:35 +0000 (01:42 +0200)]
s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3.
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.
Guenther
(cherry picked from commit
597be402e40ff880b595ae49a8600b932365cbcb)
Jeremy Allison [Wed, 15 Apr 2009 21:09:32 +0000 (14:09 -0700)]
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
What a difference a name makes... :-). Just because something is missnamed
SA_RIGHT_SAM_OPEN_DOMAIN, when it should actually be SA_RIGHT_SAM_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
Michael Adam [Mon, 8 Sep 2008 13:51:57 +0000 (15:51 +0200)]
packaging(RHEL): add cifs.upcall binary and manpage to client package
Michael
(cherry picked from commit
f1b80bcb58b8aa5c586835dc201ce674b3417835)
(cherry picked from commit
b4c58d49902d62f25aa0c9289d1857aa2636c028)
Guenther Deschner [Mon, 13 Apr 2009 16:44:54 +0000 (09:44 -0700)]
s3-loadparm: Fix resume command typo for "printing = vlp".
Volker Lendecke [Sat, 11 Apr 2009 20:54:06 +0000 (13:54 -0700)]
Fix a memleak in an unlikely error path in change_notify_create()
Jeremy Allison [Fri, 10 Apr 2009 05:46:31 +0000 (22:46 -0700)]
Fix bug #6254 - PUT/GET produces an error in IPv6 to a smb-server(3.3)
has parameter "msdfs root = yes"
This was broken by the refactoring around create_file().
MSDFS pathname processing must be done FIRST.
MSDFS pathnames containing IPv6 addresses can
be confused with NTFS stream names (they contain
":" characters.
Jeremy.
Karolin Seeger [Tue, 7 Apr 2009 18:01:27 +0000 (20:01 +0200)]
s3/popt.h: Fix typo.
This used to be commit
8da2fa36 in master.
Karolin
(cherry picked from commit
3df28fce45ce552df2c0815597fc1808ea08b363)
Karolin Seeger [Tue, 7 Apr 2009 18:00:47 +0000 (20:00 +0200)]
s3/loadparm: Fiy typos.
This used to be commit
44588095 in master.
Karolin
(cherry picked from commit
7648c51afaf844e576935dadc0d66a94e2cad28b)
Karolin Seeger [Tue, 7 Apr 2009 17:58:47 +0000 (19:58 +0200)]
s3/gpo_ldap: Fix typo.
This used to be commit
a103222e in master.
Karolin
(cherry picked from commit
a33677c8a80925965a4023785fc3a221d2ed9585)
Karolin Seeger [Tue, 7 Apr 2009 17:58:14 +0000 (19:58 +0200)]
s3/smbconf_reg: Fix typo.
This used to be commit
6343cab3 in master.
Karolin
(cherry picked from commit
56e877662dd6da64b348803c24e85f60ee6b3d85)
Günther Deschner [Mon, 6 Apr 2009 10:45:46 +0000 (12:45 +0200)]
s3-examples: Fix Bug #6205. Correct sample smb.conf share configuration.
Thanks to Jeffrey Riaboy <dakusan@castledragmire.com>.
Guenther
(cherry picked from commit
2b1fe2c98f4e0013dee4cbae62dc36cdd4085c7d)
Volker Lendecke [Sat, 28 Mar 2009 18:58:45 +0000 (19:58 +0100)]
Fix smbd crash for close_on_completion
handle_trans() can talloc_free "conn" if the client requests
close_on_completion. "state" is a talloc_child of conn, so it will be gone when
we later free state->data et al.
Jeremy Allison [Thu, 2 Apr 2009 03:14:35 +0000 (20:14 -0700)]
Allow pdbedit to change a user rid/sid. Based on a fix from Alexander
Zagrebin <alexz@visp.ru>.
Jeremy.
Karolin Seeger [Wed, 1 Apr 2009 11:42:32 +0000 (13:42 +0200)]
WHATSNEW: Rewording.
Karolin
Karolin Seeger [Wed, 1 Apr 2009 11:32:07 +0000 (13:32 +0200)]
VERSION: Raise version number up to 3.2.10.
Karolin
Karolin Seeger [Wed, 1 Apr 2009 11:31:23 +0000 (13:31 +0200)]
WHATSNEW: Prepare WHATSNEW for 3.2.10.
A release a day... ;-)
Karolin
Michael Adam [Wed, 1 Apr 2009 10:23:07 +0000 (12:23 +0200)]
s3: fix the fix for bug #6195 - dont let smbd child processes panic
This patch makes sure the original and temporary TDBs are closed
_before_ the rename. Originally, the open TDB was renamed, and so
the name passdb.tdb.tmp stayed around in the db context. Hence
upon client connect, the smbd children died because reinit_after_fork()
calling tdb_reopen_all() would try to reopen passdb.tdb.tmp which
existed no longer...
Michael
Jeremy Allison [Wed, 1 Apr 2009 01:29:30 +0000 (18:29 -0700)]
Tidy up some convert_string_internal error cases, found by Andrew Bartlett.
Jeremy.
Karolin Seeger [Tue, 31 Mar 2009 14:12:30 +0000 (16:12 +0200)]
WHATSNEW: Fix announcement.
Karolin
Karolin Seeger [Tue, 31 Mar 2009 08:44:20 +0000 (10:44 +0200)]
VERSION: Raise version number up to 3.2.9.
Karolin
Karolin Seeger [Tue, 31 Mar 2009 08:43:47 +0000 (10:43 +0200)]
WHATSNEW: Update changes.
Karolin
Jeremy Allison [Mon, 30 Mar 2009 22:09:10 +0000 (15:09 -0700)]
Ensure files starting with multiple dots are hidden
if "hide dot files" is set. Thanks to Barry Kelly <bkelly.ie@gmail.com>
for pointing this one out.
Jeremy.
Karolin Seeger [Mon, 30 Mar 2009 10:43:17 +0000 (12:43 +0200)]
WHATSNEW: Update changes.
Karolin
Jeremy Allison [Sat, 28 Mar 2009 04:26:56 +0000 (21:26 -0700)]
Fix the problem of 3.0.x passdb databases being version
3 but using a different hash calculation than 3.2.x passwd
databases (also version 3). Introduces a minor version
number.
Jeremy.
Derrell Lipman [Fri, 27 Mar 2009 21:10:04 +0000 (17:10 -0400)]
[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errno
Fixed.
It turns out there were a number of places where cli_resolve_path() was called
and the error path upon that function failing did not set errno. There were a
couple of places the failure handling code did set errno to ENOENT, so I made
them all consistent, although I think better errno choices for this condition
exist, e.g. EHOSTUNREACH.
Derrell
Jeremy Allison [Fri, 27 Mar 2009 19:09:51 +0000 (12:09 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly. For the clustering case.
Clustered setups should have only ever used
the unsigned version of TDB_DATA in the
first place so they can't be in this mess :-).
Just do the normal upgrade in the clustered case.
Jeremy.
Karolin Seeger [Fri, 27 Mar 2009 13:04:38 +0000 (14:04 +0100)]
WHATSNEW: Update changes since 3.2.8.
Karolin
Jeremy Allison [Thu, 26 Mar 2009 22:33:39 +0000 (15:33 -0700)]
Try and fix the build farm RAW-STREAMS errors. Ordering of
modules shouldn't matter, so as vfs_streams_depot doesn't
implement get/setxattrs then call into the full VFS stack
at the top.
Jeremy
Jeremy Allison [Thu, 26 Mar 2009 19:13:28 +0000 (12:13 -0700)]
Fix bug #6224 - nmbd waits 5 minutes at startup before checking if it needs to run elections
Fix logic bug that causes nmbd to wait 5 minutes before
looking for a master browser. This one is *old* :-). Thanks
for Simo for bugging me on this.
Jeremy.
Tim Prouty [Thu, 26 Mar 2009 18:28:37 +0000 (11:28 -0700)]
s3: parse_packet can return NULL which is then dereferenced in match_mailslot_name
Volker Lendecke [Thu, 26 Mar 2009 11:24:50 +0000 (12:24 +0100)]
Fix a scary "fill_share_mode_lock failed" message
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.
Change the corresponding debug message to level 10 and explain more.
Günther Deschner [Thu, 26 Mar 2009 09:41:11 +0000 (10:41 +0100)]
s3-net: Fix Bug #6102. NetQueryDisplayInformation could return wrong information.
Guenther
Günther Deschner [Wed, 25 Mar 2009 16:06:57 +0000 (17:06 +0100)]
s3-net: Fix Bug #6193: avoid messing with sync_context in fetch_database_to_ldif().
We absolutely need to avoid messing with the sync_context as that breaks the
stream of replication data coming from the DC (only replicates ~350 instead of
~4000 groups).
Guenther
Volker Lendecke [Tue, 24 Mar 2009 22:34:13 +0000 (15:34 -0700)]
winbind_pam: fix gcc 4.4 compile warning
Volker Lendecke [Tue, 24 Mar 2009 22:29:35 +0000 (15:29 -0700)]
Fix two memleaks in the encryption code
ntlmssp_seal_packet creates its own signature data blob, which we then
have to free.
Jeremy, please check and merge appropriately (Yes, I'm asking you to do the
janitor work, I want you to *look* at this :-))
Volker
Stefan Metzmacher [Tue, 24 Mar 2009 18:50:49 +0000 (11:50 -0700)]
s3:smbd: if we allow trans2 on the IPC$ share, then we have to allow transs2 too.
Otherwise we'll confuse the client signing engine, when we reply an error to each transs2.
metze
Volker Lendecke [Tue, 24 Mar 2009 10:07:16 +0000 (11:07 +0100)]
Fix bug 6097
A client sent a SID with authority 0 and 0 sub-authorities. W2k3 replies with
NT_STATUS_INVALID_SID, even if other SIDs in the list are valid.
Thanks to Pavel <wylda@volny.cz> for the bug report!
Björn Jacke [Mon, 23 Mar 2009 11:26:03 +0000 (12:26 +0100)]
s3:dsgetdcname: use parentheses in if condition to make negation clear
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
87b428e424e2e3cca975ecd0efed327e72950a1d)
Günther Deschner [Fri, 20 Mar 2009 10:11:04 +0000 (11:11 +0100)]
s3-krb5: Fix Coverity #762 (REVERSE_INULL).
Guenther
(cherry picked from commit
97190ae184dff6450b1390c854f7426e2ee3f980)
(cherry picked from commit
0f7757e94bfa35d22a7349d78578685c0dba22d7)
Günther Deschner [Thu, 19 Mar 2009 15:42:54 +0000 (16:42 +0100)]
s3-krb5: Fix Coverity #722 (RESOURCE_LEAK).
Guenther
(cherry picked from commit
1524abd8bf12d82e1fb0063585fc9a465fc7bf9c)
(cherry picked from commit
3517388b5d5439ffe3f9629aaf826fa1dfbb4ba7)
Stefan Metzmacher [Wed, 18 Mar 2009 06:56:51 +0000 (07:56 +0100)]
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".
The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.
cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().
The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.
metze
(cherry picked from commit
880fbc4e8cd67de73c4bcda94489eb1e1422a04b)
(cherry picked from commit
70466990b4b7c68ae95dbbcf741cd3f41f2dd0b3)
(cherry picked from commit
d01cca5e3ddb925696d49a1ea728013ec1032372)
Björn Jacke [Mon, 16 Mar 2009 00:51:09 +0000 (01:51 +0100)]
fix build on old Heimdal based systems
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
011ad7245d53a716c4c766f5ef8d317bb3a53d0f)
Jeremy Allison [Thu, 19 Mar 2009 03:54:13 +0000 (20:54 -0700)]
Allow DFS client paths to work when POSIX pathnames have been
selected (we need to path in pathname /that/look/like/this).
Jeremy.
Jeremy Allison [Thu, 19 Mar 2009 02:58:01 +0000 (19:58 -0700)]
Fix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.
Jeremy Allison [Wed, 18 Mar 2009 21:31:01 +0000 (14:31 -0700)]
Fix bug 6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
This is a really nasty one to fix as in order to successfully update the
passdb.tdb we must do the equivalent of a tdbbackup to move to the new hash
values before we do the upgrade.
Jeremy.
Jeremy Allison [Tue, 17 Mar 2009 21:49:00 +0000 (14:49 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Volker Lendecke [Tue, 17 Mar 2009 10:22:41 +0000 (11:22 +0100)]
Fix a valgrind error
Found in "make test" -- if we can't connect at all, "cli" is uninitialized
Volker Lendecke [Mon, 16 Mar 2009 12:17:04 +0000 (13:17 +0100)]
Fix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members
Thanks to François Legal <devel@thom.fr.eu.org> for reporting this bug
Volker Lendecke [Sun, 15 Mar 2009 10:58:07 +0000 (11:58 +0100)]
Fix a malloc/talloc mismatch when cli_initialise() fails
Volker Lendecke [Sat, 14 Feb 2009 12:18:28 +0000 (13:18 +0100)]
Don't log NDR_PRINT_DEBUG at level 0, this always ends up in syslog
I think we eventually need to pass down the debuglevel here.
Andrew Tridgell [Tue, 10 Mar 2009 05:45:45 +0000 (16:45 +1100)]
fixed a bug in message handling for code the change notify code
The change notify code registered a separate message handler for each
tree connect. This registration uses the global messaging context.
The messaging code would consider a 2nd registration for the same
messaging type as being an 'update' of the handler, rather than a new
handler. It also would only call the first handler in the linked list
for a given message type when dispatching messages.
This patch changes the messaging code to allow for multiple
registrations of the same message type, and allow for multiple calls
to different messaging handler for one incoming message.
This fixes the problem with the test_notify_tcon() test that I
recently committed to the S4 smbtorture
(cherry picked from commit
89e340e09fbdc375c0aa85506add525b8ba5dcd0)
Volker Lendecke [Tue, 10 Mar 2009 15:08:38 +0000 (16:08 +0100)]
Revert "Revert "Fix a valgrind error / segfault in dns_register_smbd()""
This reverts commit
96c57d26ed790b3e94c935cc4faf5661ea43a80c.
Volker Lendecke [Tue, 10 Mar 2009 14:46:16 +0000 (15:46 +0100)]
Revert "Fix a valgrind error / segfault in dns_register_smbd()"
This reverts commit
e47d2091136c4d870bb91b8a84eb9f6fd78eb971.
No idea why, but this causes timeouts in the build farm all over the place
Volker Lendecke [Tue, 10 Mar 2009 13:06:05 +0000 (14:06 +0100)]
Fix a valgrind error / segfault in dns_register_smbd()
(cherry picked from commit
4624451b7b78695b3f84e7fff91018ee9df0e589)
Stefan Metzmacher [Mon, 9 Mar 2009 11:35:21 +0000 (12:35 +0100)]
s3:lib: interfaces.c isn't used in the configure tests anymore
libreplace always provides the getifaddr() function.
This fixes the build on sles8.
metze
(cherry picked from commit
1410490fe769bc79f98b4ab364685c7aed253e09)
(cherry picked from commit
bac96af2053996f28894458fce87e84c5c2356ff)
Jeremy Allison [Fri, 6 Mar 2009 05:46:38 +0000 (21:46 -0800)]
Get the sense of the integer wrap test the right way around. Sorry.
Jeremy.
Jeremy Allison [Fri, 6 Mar 2009 05:02:22 +0000 (21:02 -0800)]
Now we're allowing a lower bound for auth_len, ensure we
also check for an upper one (integer wrap).
Jeremy.
Jeremy Allison [Fri, 6 Mar 2009 01:16:54 +0000 (17:16 -0800)]
Fix bug #6161 - smbclient corrupts source path in tar mode
This was my fault. I broke the smbclient tar argument processing
in creating the string for chdir when removing pstrings.
Jeremy.
Volker Lendecke [Thu, 5 Mar 2009 23:12:55 +0000 (15:12 -0800)]
Complete the fix for bug 6100
According to [MS-RPCE].pdf, section 2.2.2.11:
----
A client or a server that (during composing of a PDU) has allocated more space
for the authentication token than the security provider fills in SHOULD fill in
the rest of the allocated space with zero octets. These zero octets are still
considered to belong to the authentication token part of the PDU.<36>
----
RPC implementations are allowed to send padding bytes at the end of an auth
footer. Windows 7 makes use of this.
Thanks to Nick Meier <nmeier@microsoft.com>
Volker
Volker Lendecke [Wed, 4 Mar 2009 13:00:03 +0000 (14:00 +0100)]
Fix an uninitialized variable warning
Karolin Seeger [Fri, 27 Feb 2009 10:09:59 +0000 (11:09 +0100)]
s3/docs: Add missing full stop.
Karolin
(cherry picked from commit
2ab9d365cfceb28c1280566b6fe8ec3767e18149)
(cherry picked from commit
aff67e24f3675ace3c69c210aa387bc008f1cbbc)
Bo Yang [Fri, 27 Feb 2009 19:37:19 +0000 (11:37 -0800)]
Initialize the id_map status in idmap_ldap to avoid surprise
Steven Danneman [Fri, 27 Feb 2009 16:35:18 +0000 (08:35 -0800)]
s3: fix guest auth when winbindd is running
This fix is very subtle. If a server is configured with "security = share"
and "guest ok = yes" and winbindd is running authorization will fail during
tree connect.
This is due to our inability to map the guest sid S-1-5-21-X-501 to a uid
through sid_to_uid(). Winbindd is unaware of the hard coded mapping
between this sid and whatever uid the name in lp_guestaccount() is assigned.
So sid_to_uid() fails and we exit create_token_from_username() without
ever calling pdb_getsampwsid() which IS aware of the hard coded mapping.
This patch just reorganizes the code, moving sid_to_uid() down to the
block of code in which it is needed, avoiding this early failure.
Jeremy Allison [Wed, 25 Feb 2009 22:55:19 +0000 (14:55 -0800)]
Fix more POSIX path lstat calls. Fix bug where close can return
failure if we have a pending modtime and the containing directory
of the file has been renamed (there is no POSIX "update time by
fd" call). This can't happen on Windows as the rename will fail
if there are open files beneath it. Will add a torture test
for this.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 21:48:30 +0000 (13:48 -0800)]
Fix use of streams modules with CIFSFS client.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 01:59:19 +0000 (17:59 -0800)]
Allow set attributes on a stream fnum to be redirected to the base filename.
Fixes the new RAW-STREAMS torture test.
Jeremy.
Steve French [Tue, 24 Feb 2009 23:10:19 +0000 (17:10 -0600)]
Fix guest mounts
guest session setup, login (user id) as anonymous.
This patch is for samba bugzilla bug 4640.
Signed-off-by: Shirish Pargaonkar <shirishp@us.ibm.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
Steve French [Tue, 24 Feb 2009 18:52:08 +0000 (12:52 -0600)]
cifs mount fix for handling -V parameter
also syncs with 3-3 mount.cifs
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
Björn Jacke [Sun, 22 Feb 2009 18:46:40 +0000 (19:46 +0100)]
prefer gssapi header files from subdirectory
this fixes some compile time noise on FreeBSD 7
(cherry picked from commit
1bfdbb093f7c5e434ea3e653d389e1ccec578af6)
Björn Jacke [Sat, 21 Feb 2009 23:43:38 +0000 (00:43 +0100)]
all BSDs use this evironment variable
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
cd6ae0de52164dd6f50b3614f2511acb3eb15993)
(cherry picked from commit
1ad5f50bdab761c7d3894e94f8fe3b171ec1b219)
Karolin Seeger [Mon, 23 Feb 2009 08:24:50 +0000 (09:24 +0100)]
s3/docs: Fix typo in man mount.cifs.
Thanks to Tobias Stoeckmann for reporting!
Karolin
(cherry picked from commit
09a7f93f6be66a8f2a124e49b4effe2b5863f01d)
(cherry picked from commit
fdb5c65fc51784b6a159748ec4df3953b7d2c1cb)
Jeremy Allison [Fri, 20 Feb 2009 16:25:29 +0000 (08:25 -0800)]
Fix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
As the NFSv4 ACL mapping code doesn't map write directory into the DELETE_CHILD
permission bit (which we require before allowing a delete) no one can delete
files without an explicit DELETE_CHILD bit set on the directory. Add this mapping.
Jeremy.
Karolin Seeger [Fri, 20 Feb 2009 08:20:16 +0000 (09:20 +0100)]
s3/docs: Fix several typos.
This fixes bug #6127.
Thanks to Justin T Pryzby <justinpryzby [at] users.sourceforge.net>
for the review!
Karolin
(cherry picked from commit
54dbb030e2c6fed0abd0a3a89d08dad9b8a201a1)
(cherry picked from commit
a4548e41c6f12e4703249c53ad3dc727d2839931)
Jeremy Allison [Thu, 19 Feb 2009 19:58:43 +0000 (11:58 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 19 Feb 2009 19:55:56 +0000 (11:55 -0800)]
Backport the semantics of when to delete alternate data streams on a file truncate.
Needed to fully support stream semantics.
Jeremy.
Volker Lendecke [Thu, 19 Feb 2009 19:03:06 +0000 (20:03 +0100)]
Fix a O(n^2) algorithm in regdb_fetch_keys()
Volker Lendecke [Thu, 19 Feb 2009 13:16:44 +0000 (14:16 +0100)]
Fix a buffer handling bug when adding lots of registry keys
This is *ancient*... From 2002, and nobody noticed until someone added lots of
shares using net conf... :-)
Jeremy Allison [Thu, 19 Feb 2009 00:02:15 +0000 (16:02 -0800)]
Gah, typo :-(. Sorry.
Jeremy Allison [Wed, 18 Feb 2009 23:42:31 +0000 (15:42 -0800)]
Fix coverity CID-602. Possible use of uninitialized var.
Jeremy.
Jeremy Allison [Tue, 17 Feb 2009 23:55:23 +0000 (15:55 -0800)]
Don't miss an absolute pathname as a kerberos keytab path. From Glenn Machin <gmachin@sandia.gov>.
Jeremy.