samba.git
15 years agoAfter technical consultation, add Steven Danneman's <steven.danneman@isilon.com>...
Jeremy Allison [Mon, 30 Jun 2008 18:23:05 +0000 (11:23 -0700)]
After technical consultation, add Steven Danneman's <steven.danneman@isilon.com> patch to make winbindd enum users and groups async.
We need this for 3.2.0 official.
Jeremy.

15 years agoFix from Atte Peltomäki - atte.peltomaki@f-secure.com to correctly check
Jeremy Allison [Mon, 30 Jun 2008 16:19:16 +0000 (09:19 -0700)]
Fix from Atte Peltomäki - atte.peltomaki@f-secure.com to correctly check
error code in winbindd group expansion.
Jeremy.

15 years agoWHATSNEW: Update changes since 3.2.0rc2.
Karolin Seeger [Sun, 29 Jun 2008 15:49:59 +0000 (17:49 +0200)]
WHATSNEW: Update changes since 3.2.0rc2.

Karolin

15 years agoFix a file descriptor leak in add_port_hook
Volker Lendecke [Sat, 28 Jun 2008 14:09:34 +0000 (16:09 +0200)]
Fix a file descriptor leak in add_port_hook

This was probably cut&paste from add_printer_hook which further down has the
unconditional close(fd). In add_port_hook() we're not interested in the output
of 'addport command', so don't create the out fd.

15 years agoReturn NULL in sitename_fetch() if gencache_init() fails. Not false
Gerald W. Carter [Sat, 28 Jun 2008 13:35:07 +0000 (09:35 -0400)]
Return NULL in sitename_fetch() if gencache_init() fails.  Not false
(cherry picked from commit 9e9bab2dd859c7bb8082b4c932f1a95adf1895c6)

15 years agoFix bug #5568 net rpc trustdom add broken !
Jeremy Allison [Sat, 28 Jun 2008 00:27:40 +0000 (17:27 -0700)]
Fix bug #5568 net rpc trustdom add broken !
net rpc trustdom add was broken. The default 10second timeout can be too short
to create an account on a Samba DC (calling out to a script), error message
reporting was poor, and more importantly the new marshalling code for
user_info23 was broken (maps onto a user_info21 but doesn't clear the
user_info23 struct before marshalling, leaving an uninitialized size field -
give "alloc failure").
Jeremy.

15 years agoFix usage message for net rpc trustdom add.
Jeremy Allison [Fri, 27 Jun 2008 22:28:03 +0000 (15:28 -0700)]
Fix usage message for net rpc trustdom add.
Jeremy.

15 years agoFix warnings on SuSE 9.0.
Karolin Seeger [Fri, 27 Jun 2008 13:51:35 +0000 (15:51 +0200)]
Fix warnings on SuSE 9.0.

The macros "[un]likely" are already defined on SuSE 9.0.
Patch from Volker.
(cherry picked from commit 30d181c92463aecd6e649330d3645d86d5a17e43)

15 years agoWHATSNEW: Update changes since 3.2.0rc2.
Karolin Seeger [Fri, 27 Jun 2008 08:14:40 +0000 (10:14 +0200)]
WHATSNEW: Update changes since 3.2.0rc2.

Karolin

15 years agoFix gcc warnings at -O3.
Jeremy Allison [Fri, 27 Jun 2008 02:20:51 +0000 (19:20 -0700)]
Fix gcc warnings at -O3.
Jeremy.

15 years agoFix valgrind errors in _spoolss_addprinterdriver
Volker Lendecke [Thu, 26 Jun 2008 14:51:45 +0000 (16:51 +0200)]
Fix valgrind errors in _spoolss_addprinterdriver

Jerry, this was dropped as part of your SVN r15309 (037f9f83). Can you please
check?

Thanks,

Volker

15 years agoWHATSNEW: Update changes since 3.2.0rc2.
Karolin Seeger [Thu, 26 Jun 2008 13:46:26 +0000 (15:46 +0200)]
WHATSNEW: Update changes since 3.2.0rc2.

Karolin

15 years agoFix a segfault in rpcclient adddriver
Volker Lendecke [Thu, 26 Jun 2008 13:32:27 +0000 (15:32 +0200)]
Fix a segfault in rpcclient adddriver

15 years agoWHATSNEW: Preparations for 3.2.0.
Karolin Seeger [Thu, 26 Jun 2008 12:47:27 +0000 (14:47 +0200)]
WHATSNEW: Preparations for 3.2.0.

Karolin

15 years agoVERSION: Update version.
Karolin Seeger [Thu, 26 Jun 2008 11:24:40 +0000 (13:24 +0200)]
VERSION: Update version.

Karolin

15 years agoPart of fix for #5551. Split out the group enumeration functions to a BUILTIN and...
Jeremy Allison [Wed, 25 Jun 2008 22:23:52 +0000 (15:23 -0700)]
Part of fix for #5551. Split out the group enumeration functions to a BUILTIN and a Domain
specific version. Stops the domain groups appearing twice.
Jeremy.

15 years agoFinal (hopefully :-) part of fix for bug #5551. Allow passdb backend to enumerate...
Jeremy Allison [Wed, 25 Jun 2008 19:44:27 +0000 (12:44 -0700)]
Final (hopefully :-) part of fix for bug #5551. Allow passdb backend to enumerate domain groups.
Jeremy

15 years agoFix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy Allison [Wed, 25 Jun 2008 01:04:37 +0000 (18:04 -0700)]
Fix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy.

15 years agoFix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account...
Jeremy Allison [Tue, 24 Jun 2008 23:42:30 +0000 (16:42 -0700)]
Fix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account logon.
Jeremy.

15 years agoAdd krb5 support for the testbrowse example.
Andreas Schneider [Mon, 23 Jun 2008 09:00:20 +0000 (11:00 +0200)]
Add krb5 support for the testbrowse example.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(cherry picked from commit 84b1ea39a4f27ebcf06a2bafed78396c7353df0e)
(cherry picked from commit c7d963191e1858000752ff57eac1501777f0ebda)

15 years agoAdd documentation for kerberos support in libsmbclient.
Andreas Schneider [Mon, 23 Jun 2008 14:29:40 +0000 (16:29 +0200)]
Add documentation for kerberos support in libsmbclient.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(cherry picked from commit fa803ce183376c938f92b0f31a7d89d522fd309f)
(cherry picked from commit 1cbae6583e04aa382c27d459f8d1c58488b3af7a)

15 years agoRemove prototype of unimplemented smbc_chown() function.
Derrell Lipman [Wed, 18 Jun 2008 15:00:46 +0000 (11:00 -0400)]
Remove prototype of unimplemented smbc_chown() function.
(cherry picked from commit 0e84e3bb800cec2b63df4692afbf9c40850b108f)
(cherry picked from commit 31a23b3fe4ca3cf7c65a6b3e079d10ef2956fae2)

15 years agoSorry volker, lost your original git-id due to proto.h conflicts.
Jeremy Allison [Mon, 23 Jun 2008 18:24:52 +0000 (11:24 -0700)]
Sorry volker, lost your original git-id due to proto.h conflicts.

Remove the "exists" parameter from create_msdfs_link

Jeremy, setting "exists" to True in _dfs_Add prevented the initial creation of
a new symlink for me, because the SMB_VFS_UNLINK failed. This also exists in
3.2. I only check it into 3.3 as I would like you to look at it first.

Thanks,

Volker

15 years agoCheck for sec_initial_uid() instead of uid==0 in dfs management
Volker Lendecke [Sun, 22 Jun 2008 18:27:20 +0000 (20:27 +0200)]
Check for sec_initial_uid() instead of uid==0 in dfs management

15 years agoReduce memory usage in form_junctions() a little bit
Volker Lendecke [Sun, 22 Jun 2008 09:28:57 +0000 (11:28 +0200)]
Reduce memory usage in form_junctions() a little bit

15 years agotestsuite: enable the testparm_s3 tests.
Michael Adam [Thu, 19 Jun 2008 15:19:21 +0000 (17:19 +0200)]
testsuite: enable the testparm_s3 tests.

Michael
(cherry picked from commit 0f5c13e5735990f4325f98156a7dc410276372fe)

15 years agotestsuite: add a testparm_s3 test script.
Michael Adam [Thu, 19 Jun 2008 15:14:39 +0000 (17:14 +0200)]
testsuite: add a testparm_s3 test script.

This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael
(cherry picked from commit eb28146d40b8a8bc2c20b8d222abf191ea178d5a)

15 years agotestsuite: update introductory comment to test_net_regsistry.sh
Michael Adam [Thu, 19 Jun 2008 11:52:49 +0000 (13:52 +0200)]
testsuite: update introductory comment to test_net_regsistry.sh

This is now used to test rpc and local access depending on
command line parameters.

Michael
(cherry picked from commit 73c17b630317b5019e5d5f2b989b8de081a73e07)

15 years agoFix typo
Volker Lendecke [Thu, 19 Jun 2008 09:59:55 +0000 (11:59 +0200)]
Fix typo
(cherry picked from commit 2eef2c682c18ad37b78214c755b9dd7c8b607cb8)

15 years agotestsuite: give admin rights to testuser only for the "net rpc registry" test.
Michael Adam [Tue, 17 Jun 2008 21:54:15 +0000 (23:54 +0200)]
testsuite: give admin rights to testuser only for the "net rpc registry" test.

Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael
(cherry picked from commit 1734f9305a38eff05f0147d9c7391ef34085e7b2)

15 years agotestsuite: don't give the testuser administrative rights globally.
Michael Adam [Tue, 17 Jun 2008 21:51:23 +0000 (23:51 +0200)]
testsuite: don't give the testuser administrative rights globally.

It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael
(cherry picked from commit 9fe99c69f35b005b66c1eacb5d999cc73f1bb521)

15 years agotests_all.sh: Do not execute $SMB4TORTURE --version if it is not available.
Karolin Seeger [Tue, 13 May 2008 12:01:52 +0000 (14:01 +0200)]
tests_all.sh: Do not execute $SMB4TORTURE --version if it is not available.

Improve error message if no SMB4TORTURE is available.

Karolin
(cherry picked from commit 443691eb2614919043406f94e9c71b49230612d5)

15 years agotestsuite: allow selection of posix_s3 subtests by env var POSIX_SUBTESTS.
Michael Adam [Tue, 6 May 2008 21:43:37 +0000 (23:43 +0200)]
testsuite: allow selection of posix_s3 subtests by env var POSIX_SUBTESTS.

This allows for calling e.g.

TESTS=posix_s3 POSIX_SUBTESTS="RPC-SAMBA3-GETUSERNAME" make test

Michael
(cherry picked from commit 7418d89b2941fff307e0980d1f71f106aed8cbce)

15 years agotestsuite: make structuring output of net_s3 tests stand out more.
Michael Adam [Tue, 6 May 2008 10:09:59 +0000 (12:09 +0200)]
testsuite: make structuring output of net_s3 tests stand out more.

say "RUNNING SUBTESTS ..." instead of "Running ... tests"

Michael
(cherry picked from commit 0b879817ba20861c7d0b239d7f7199b0a5ed2ca1)

15 years agotestsuite: make diagnostic output more appropriate in tests_all.sh
Michael Adam [Tue, 6 May 2008 10:08:27 +0000 (12:08 +0200)]
testsuite: make diagnostic output more appropriate in tests_all.sh

Say "RUNNING TESTS ..." instead of "RUNNING SUBTESTS ..."

Michael
(cherry picked from commit b73821c392a23c213e4b1ad25a8a2d0c845cee3a)

15 years agotestsuite: give the testuser administrative rights in selftest.sh
Michael Adam [Fri, 4 Apr 2008 16:29:44 +0000 (18:29 +0200)]
testsuite: give the testuser administrative rights in selftest.sh

(by adding him to builtin\administrators)

Michael
(cherry picked from commit baea0615003cc2db8b27872e87064364f2deb079)

15 years agotestsuite: run the net rpc registry tests from the net_s3 tests.
Michael Adam [Tue, 6 May 2008 10:01:49 +0000 (12:01 +0200)]
testsuite: run the net rpc registry tests from the net_s3 tests.

Michael
(cherry picked from commit dcf39078cf0524a7450db3f67c8e004eb42690c2)

15 years agotestsuite: add the ability to test "net rpc registry" with the net_registry tests
Michael Adam [Fri, 4 Apr 2008 16:26:34 +0000 (18:26 +0200)]
testsuite: add the ability to test "net rpc registry" with the net_registry tests

by specifying a parameter "rpc" on the commandline.

Michael
(cherry picked from commit 110c26374ef3e0bdefe2e54db2b8ffd4544780ef)

15 years agotestsuite: adapt informative message to say "Running _local_ registry tests".
Michael Adam [Tue, 6 May 2008 09:43:27 +0000 (11:43 +0200)]
testsuite: adapt informative message to say "Running _local_ registry tests".

The plan is to also test remote registry  with "net rpc registry".

Michael
(cherry picked from commit b5507f8a95399193099a0474fb8b8bc95ba04a48)

15 years agotestsuite: use domain==workgroup in wbinfo tests now that we are PDC.
Michael Adam [Tue, 6 May 2008 09:40:05 +0000 (11:40 +0200)]
testsuite: use domain==workgroup in wbinfo tests now that we are PDC.

Previously domain==netbios name was the right thing to use.

Michael
(cherry picked from commit a5fc47c2457ce370a4f6150b9f2a417dac7589bf)

15 years agotests: Add a net_misc test.
Kai Blin [Fri, 2 May 2008 23:50:20 +0000 (01:50 +0200)]
tests: Add a net_misc test.
(cherry picked from commit 026d701aff2c035359894786ec22b4ed829cfb31)

15 years agoselftest: Advertise as PDC and time server during make test
Kai Blin [Mon, 5 May 2008 13:26:11 +0000 (15:26 +0200)]
selftest: Advertise as PDC and time server during make test
(cherry picked from commit 65c619b36d08ac2f24b622c71b7e05d50bdeea50)

15 years agoselftest: Use TESTS env var to specify tests to run like Samba4 does.
Kai Blin [Fri, 2 May 2008 23:45:33 +0000 (01:45 +0200)]
selftest: Use TESTS env var to specify tests to run like Samba4 does.
(cherry picked from commit 6fb1fe803ccbd3af2946fcbe4586c11d394d5dc2)

15 years agoWHATSNEW: Fix typo.
Karolin Seeger [Mon, 23 Jun 2008 11:11:11 +0000 (13:11 +0200)]
WHATSNEW: Fix typo.

Karolin

15 years agoWHATSNEW: Update changes since 3.2.0rc2.
Karolin Seeger [Mon, 23 Jun 2008 10:10:18 +0000 (12:10 +0200)]
WHATSNEW: Update changes since 3.2.0rc2.

Karolin

15 years agoman pages: Correct version in man winbindd again.
Karolin Seeger [Mon, 23 Jun 2008 08:28:09 +0000 (10:28 +0200)]
man pages: Correct version in man winbindd again.

Karolin

15 years agoSamba3 HOWTO: Remove trailing whitespaces.
Karolin Seeger [Mon, 23 Jun 2008 08:15:53 +0000 (10:15 +0200)]
Samba3 HOWTO: Remove trailing whitespaces.

Karolin

15 years agoinit_shared_module -> init_samba_module
Volker Lendecke [Mon, 23 Jun 2008 05:14:46 +0000 (07:14 +0200)]
init_shared_module -> init_samba_module

15 years agoFix a crash in _dfs_Enum
Volker Lendecke [Sun, 22 Jun 2008 11:06:35 +0000 (13:06 +0200)]
Fix a crash in _dfs_Enum

15 years agoFix an uninitialized variable access in callers of parse_msdfs_symlink
Volker Lendecke [Sun, 22 Jun 2008 10:50:30 +0000 (12:50 +0200)]
Fix an uninitialized variable access in callers of parse_msdfs_symlink

At least form_junctions() does not initialize refcount, and I don't see it in
get_referred_path(). For the latters, the callers might initialize it. But even
if they did, I think parse_msdfs_symlink() should unconditionally return the
number of referrals it found. I don't think it makes sense to count them up
from somewhere else.

15 years agoFix a double-closedir() in form_junctions()
Volker Lendecke [Sat, 21 Jun 2008 14:48:07 +0000 (16:48 +0200)]
Fix a double-closedir() in form_junctions()

15 years agoAttempt to fix the darwin build
Volker Lendecke [Sat, 21 Jun 2008 14:15:02 +0000 (16:15 +0200)]
Attempt to fix the darwin build

15 years agoUse "init_shared_module" instead of "init_module" for initializing .so's
Volker Lendecke [Fri, 20 Jun 2008 12:30:02 +0000 (14:30 +0200)]
Use "init_shared_module" instead of "init_module" for initializing .so's

15 years agoFix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Jeremy Allison [Fri, 20 Jun 2008 20:23:31 +0000 (13:23 -0700)]
Fix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Fix from hkurma@datadomain.com.
Jeremy.

15 years agoFix bug #5533. Winbindd fails to cope correctly with a workgroup name containing...
Jeremy Allison [Fri, 20 Jun 2008 19:49:14 +0000 (12:49 -0700)]
Fix bug #5533. Winbindd fails to cope correctly with a workgroup name containing a '.'.
Jeremy.

15 years agoFix the build on FreeBSD 4.6.2
Volker Lendecke [Thu, 19 Jun 2008 07:50:34 +0000 (09:50 +0200)]
Fix the build on FreeBSD 4.6.2

15 years agoFixing net help info.
John H Terpstra [Thu, 19 Jun 2008 21:11:31 +0000 (16:11 -0500)]
Fixing net help info.

15 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
John H Terpstra [Thu, 19 Jun 2008 16:12:17 +0000 (11:12 -0500)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test

15 years agoRevert "Fix a memleak in svcctl_init_keys()"
Volker Lendecke [Wed, 18 Jun 2008 14:30:37 +0000 (16:30 +0200)]
Revert "Fix a memleak in svcctl_init_keys()"

This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.

15 years agoFix Bug #5548 (segfauls in handle_include with %m macro expansion).
Michael Adam [Wed, 18 Jun 2008 12:50:53 +0000 (14:50 +0200)]
Fix Bug #5548 (segfauls in handle_include with %m macro expansion).

In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael
(cherry picked from commit c65b456c6a145d15b7fd27a2a3440a0709fc3277)

15 years agoFix a brown paper bag segfault in clitar
Volker Lendecke [Tue, 17 Jun 2008 19:08:56 +0000 (21:08 +0200)]
Fix a brown paper bag segfault in clitar

Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker

15 years agoFix a memleak in svcctl_init_keys()
Volker Lendecke [Tue, 17 Jun 2008 14:06:42 +0000 (16:06 +0200)]
Fix a memleak in svcctl_init_keys()

15 years agoFix a segfault in wbcLookupRids
Volker Lendecke [Tue, 17 Jun 2008 13:17:22 +0000 (15:17 +0200)]
Fix a segfault in wbcLookupRids

The done: part could access uninitialized memory if intermediate
BAIL_ON_WBC_ERROR fire.

Jerry, please check!

Thanks,

Volker

15 years agoFix a segfault in wbcLookupSid
Volker Lendecke [Tue, 17 Jun 2008 12:53:07 +0000 (14:53 +0200)]
Fix a segfault in wbcLookupSid

If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain
and *name have not been initialized yet. So the cleanup routine in the done:
part of the routine (which did not check for domain!=NULL etc) would access
uninitialized memory.

Jerry, please check!

Thanks,

Volker

15 years agoReplace a very unusual variable declaration by a more conventional one
Volker Lendecke [Tue, 17 Jun 2008 12:31:07 +0000 (14:31 +0200)]
Replace a very unusual variable declaration by a more conventional one

15 years agoman pages: Move 'smbsh' man page to the examples directory.
Karolin Seeger [Tue, 17 Jun 2008 11:18:17 +0000 (13:18 +0200)]
man pages: Move 'smbsh' man page to the examples directory.

smbsh.c is located in the examples directory. It does not make sense
to install a man page without installing the tool itself.

This fixes bug #4724.

Karolin
(cherry picked from commit 797ed744b15c94fa4831d9796b40bb0ab5df55b7)

15 years agoFix a memleak in wbcAuthenticateUserEx()
Volker Lendecke [Tue, 17 Jun 2008 11:00:13 +0000 (13:00 +0200)]
Fix a memleak in wbcAuthenticateUserEx()

15 years agoMore correct fix (hopefully :-) for any memory leaks.
Jeremy Allison [Thu, 5 Jun 2008 21:28:28 +0000 (14:28 -0700)]
More correct fix (hopefully :-) for any memory leaks.
Jerry promised to check :-). Vl also please review.
Jeremy.

Okay -- I have to admit that this is the better fix. With my fixes I got a
double-free when using security=domain. Sorry...

Volker

15 years agoRevert "Fix a memleak caused by a crappy get_sorted_dc_list() API"
Volker Lendecke [Tue, 17 Jun 2008 10:15:05 +0000 (12:15 +0200)]
Revert "Fix a memleak caused by a crappy get_sorted_dc_list() API"

This reverts commit ba10b9c077272c521504b3a638bba73446efc61c.

15 years agoRevert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"
Volker Lendecke [Tue, 17 Jun 2008 10:14:49 +0000 (12:14 +0200)]
Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"

This reverts commit 6bcfa82ff15531c64e0db27dcc58e5847c513aa6.

15 years agonet_vampire: fix samsync_process_database(). Final fix for Bug #5542.
Günther Deschner [Tue, 17 Jun 2008 09:10:37 +0000 (11:10 +0200)]
net_vampire: fix samsync_process_database(). Final fix for Bug #5542.

Turns out the password hashes are not rid encrypted in the samsync reply.

Guenther

15 years agonet_vampire: fix build warning.
Günther Deschner [Tue, 17 Jun 2008 08:36:53 +0000 (10:36 +0200)]
net_vampire: fix build warning.

Guenther
(cherry picked from commit eb4232fec05cd87ea85a781b84a3fbe85f469703)

15 years agonetapi: Fix Bug #5545 (libnetapi_init without $USER)
Günther Deschner [Tue, 17 Jun 2008 08:31:44 +0000 (10:31 +0200)]
netapi: Fix Bug #5545 (libnetapi_init without $USER)

Based on patch from Erik van Pienbroek.

Guenther
(cherry picked from commit 71f4cf773022525ba617f09c495dbff97f8eb2d5)

15 years agoWHATSNEW: Updates changes since 3.2.0rc2.
Karolin Seeger [Mon, 16 Jun 2008 13:58:51 +0000 (15:58 +0200)]
WHATSNEW: Updates changes since 3.2.0rc2.

Karolin

15 years agoFix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
Volker Lendecke [Mon, 16 Jun 2008 11:27:16 +0000 (13:27 +0200)]
Fix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting

15 years agoFix an uninitialized variable found by the IBM checker
Volker Lendecke [Sat, 14 Jun 2008 22:22:47 +0000 (00:22 +0200)]
Fix an uninitialized variable found by the IBM checker

BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.

Stefan, please check!

Volker

15 years agoFix group parsing in libwbclient's copy_group_entry()
Volker Lendecke [Sat, 14 Jun 2008 22:14:27 +0000 (00:14 +0200)]
Fix group parsing in libwbclient's copy_group_entry()

This (also) fixes a flaw pointed out by the IBM checker. When verifying that I
found out that the parsing was not working as I would have expected it to.

Jerry, please check!

15 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
John H Terpstra [Fri, 13 Jun 2008 20:51:19 +0000 (15:51 -0500)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test

15 years agonet: Fix several typos in comments.
Karolin Seeger [Fri, 13 Jun 2008 19:31:34 +0000 (21:31 +0200)]
net: Fix several typos in comments.

-argc -> argv (where argv is meant)
-destoyed -> destroyed
-compleation -> completion
-aquired -> acquired
-Unify spelling of some words like rpc-server -> RPC server.
-Add missing punctuation marks.

Karolin

15 years agoFix a handle leak for error returns in ldb_try_load_dso
Volker Lendecke [Fri, 13 Jun 2008 14:05:31 +0000 (16:05 +0200)]
Fix a handle leak for error returns in ldb_try_load_dso

Coverity ID 464

15 years agoFix a crash in _winreg_QueryValue
Volker Lendecke [Fri, 13 Jun 2008 13:30:08 +0000 (15:30 +0200)]
Fix a crash in _winreg_QueryValue

Coverity ID 474, value_length and type are both unique, not ref pointers and
can thus be NULL.

Karolin, please merge this to -stable.

Thanks,

Volker

15 years agonet: Fix bug #5542 (samsync contains empty passwords).
Günther Deschner [Fri, 13 Jun 2008 10:20:01 +0000 (12:20 +0200)]
net: Fix bug #5542 (samsync contains empty passwords).

Guenther

15 years agosamsync: add samsync_fix_delta_array()
Günther Deschner [Fri, 13 Jun 2008 09:57:09 +0000 (11:57 +0200)]
samsync: add samsync_fix_delta_array()

This code is vastly based on samba4 code.

Guenther

15 years agoman pages: Fix indentation in smb.conf section about 'map readonly'.
Karolin Seeger [Thu, 12 Jun 2008 07:34:15 +0000 (09:34 +0200)]
man pages: Fix indentation in smb.conf section about 'map readonly'.
(cherry picked from commit 0f0d81a89ae2ebae7d031a3a8633c3a924ebcbae)

15 years agoman pages: Added improvements.
Christoph Zauner [Wed, 11 Jun 2008 13:15:22 +0000 (15:15 +0200)]
man pages: Added improvements.
(cherry picked from commit 7fecd548af0a21b9644bd70e22a38aaa28777aa0)

15 years agoman pages: Fix typo in smb.conf section about the 'deleteprinter command'.
Karolin Seeger [Thu, 12 Jun 2008 07:26:32 +0000 (09:26 +0200)]
man pages: Fix typo in smb.conf section about the 'deleteprinter command'.

Karolin
(cherry picked from commit 5fa77c216bc43c3558aff3373f74554efdb9210d)

15 years agoman pages: Fix typos.
Christoph Zauner [Wed, 11 Jun 2008 13:17:21 +0000 (15:17 +0200)]
man pages: Fix typos.
(cherry picked from commit 881eaa26e071a7fde9c6fc5eb42ae122d0ddd490)

15 years agoSamba3-HOWTO: Fix typos.
Christoph Zauner [Wed, 11 Jun 2008 12:49:30 +0000 (14:49 +0200)]
Samba3-HOWTO: Fix typos.
(cherry picked from commit 2391d999eb733bd8d12631478f4318608225cbb6)

15 years agoFix typos.
Christoph Zauner [Wed, 11 Jun 2008 12:05:47 +0000 (14:05 +0200)]
Fix typos.
(cherry picked from commit b2390aa738f6384016600dffb8065bd0bcda6ef1)

15 years agoAIX build fixes from William Jojo -- thanks
Volker Lendecke [Thu, 12 Jun 2008 10:36:15 +0000 (12:36 +0200)]
AIX build fixes from William Jojo -- thanks

15 years agoAdd -brtl to the AIX linker flags
Volker Lendecke [Thu, 12 Jun 2008 10:35:28 +0000 (12:35 +0200)]
Add -brtl to the AIX linker flags

Thanks to William Jojo

15 years agoFix max_fd calculation in event_loop_once
Volker Lendecke [Wed, 11 Jun 2008 16:56:20 +0000 (18:56 +0200)]
Fix max_fd calculation in event_loop_once

For some bugs I really wonder how they can go undetected for so long.

Fix a bug reported by Mathias Dietz. No samba bugzilla entry, but still 100%
needed for 3-2-stable.

Volker

15 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
John H Terpstra [Wed, 11 Jun 2008 15:36:37 +0000 (10:36 -0500)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test

15 years agopam_winbind: Update cached creds during password change.
Günther Deschner [Wed, 11 Jun 2008 07:52:56 +0000 (09:52 +0200)]
pam_winbind: Update cached creds during password change.

Fix is from Bo Yang @ Novell.

Thanks!
(cherry picked from commit e4eb9d347d14de8c9ba73b07f26fe8fd4f17eab5)

15 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
John H Terpstra [Tue, 10 Jun 2008 18:32:10 +0000 (13:32 -0500)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test

15 years agoCorrectly find a [u]int32_t replacement
Volker Lendecke [Tue, 10 Jun 2008 14:14:30 +0000 (16:14 +0200)]
Correctly find a [u]int32_t replacement

15 years agoFix some scary FC9 warnings
Volker Lendecke [Tue, 10 Jun 2008 12:15:01 +0000 (14:15 +0200)]
Fix some scary FC9 warnings

15 years agoman pages: Don't refer to numbered chapter of the HOWTO collection.
Karolin Seeger [Tue, 10 Jun 2008 13:30:19 +0000 (15:30 +0200)]
man pages: Don't refer to numbered chapter of the HOWTO collection.

This fixes bug #5527.
Thanks to the Debian package maintainers for reporting!

Karolin
(cherry picked from commit b6696f4fbfc6aaffceef71c6099b8eaea58c1172)

15 years agoman pages: Fix broken smb.conf section about the 'get quota command'.
Karolin Seeger [Tue, 10 Jun 2008 08:54:21 +0000 (10:54 +0200)]
man pages: Fix broken smb.conf section about the 'get quota command'.

This fixes bug #5422.
Thanks to the Debian package maintainers for reporting!

Karolin
(cherry picked from commit 04e2470e2eeef34362f2893ec062ae16f74c28ed)

15 years agoWHATSNEW: Update changes since 3.2.0rc1.
Karolin Seeger [Tue, 10 Jun 2008 08:17:14 +0000 (10:17 +0200)]
WHATSNEW: Update changes since 3.2.0rc1.

Karolin