From 0b5a556b76f0d05457c1c370b0f81fba124190a3 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Sun, 26 Sep 2010 12:34:58 +1000 Subject: [PATCH] s4-kerberos Don't segfault if the password isn't specified in keytab generation Andrew Bartlett Autobuild-User: Andrew Bartlett Autobuild-Date: Sun Sep 26 03:29:34 UTC 2010 on sn-devel-104 --- source4/auth/kerberos/kerberos_util.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/source4/auth/kerberos/kerberos_util.c b/source4/auth/kerberos/kerberos_util.c index 37a5ae6f390..76edf0d05aa 100644 --- a/source4/auth/kerberos/kerberos_util.c +++ b/source4/auth/kerberos/kerberos_util.c @@ -597,6 +597,13 @@ static krb5_error_code create_keytab(TALLOC_CTX *parent_ctx, /* Finally, do the dance to get the password to put in the entry */ password_s = ldb_msg_find_attr_as_string(msg, "secret", NULL); + + if (!password_s) { + /* There is no password here, so nothing to do */ + talloc_free(mem_ctx); + return 0; + } + if (add_old && kvno != 0) { old_secret = ldb_msg_find_attr_as_string(msg, "priorSecret", NULL); } else { -- 2.34.1