From 4fabb76106fc5224d48d380c9b1a6cb399dc3621 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Fri, 9 Nov 2012 08:55:40 +0100 Subject: [PATCH] source3/libaddns: remove pointless check for resp->num_additionals != 1 We never use resp->additionals, so there's no reason to check. This fixes dns updates against BIND9 (used in a Samba4 domain). Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett (cherry picked from commit b59c5db5f74f56c0536635a41ae51c389109ceb5) (cherry picked from commit 4bb99f454cea8a0c37422f1e64cabe96543ca6e8) --- source3/libaddns/dnsgss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source3/libaddns/dnsgss.c b/source3/libaddns/dnsgss.c index c9037417da9..fe7c6ca536e 100644 --- a/source3/libaddns/dnsgss.c +++ b/source3/libaddns/dnsgss.c @@ -175,8 +175,7 @@ static DNS_ERROR dns_negotiate_gss_ctx_int( TALLOC_CTX *mem_ctx, * TODO: Compare id and keyname */ - if ((resp->num_additionals != 1) || - (resp->num_answers == 0) || + if ((resp->num_answers == 0) || (resp->answers[0]->type != QTYPE_TKEY)) { err = ERROR_DNS_INVALID_MESSAGE; goto error; -- 2.34.1