x86/fpu: Keep xfd_state in sync with MSR_IA32_XFD
authorAdamos Ttofari <attofari@amazon.de>
Fri, 22 Mar 2024 23:04:39 +0000 (16:04 -0700)
committerIngo Molnar <mingo@kernel.org>
Sun, 24 Mar 2024 03:03:54 +0000 (04:03 +0100)
commit10e4b5166df9ff7a2d5316138ca668b42d004422
tree8b71e5347985c2afdce9a87644f42f27720efe61
parenta8ed59a3a8de2648e69dd5936f5771ac4c92d085
x86/fpu: Keep xfd_state in sync with MSR_IA32_XFD

Commit 672365477ae8 ("x86/fpu: Update XFD state where required") and
commit 8bf26758ca96 ("x86/fpu: Add XFD state to fpstate") introduced a
per CPU variable xfd_state to keep the MSR_IA32_XFD value cached, in
order to avoid unnecessary writes to the MSR.

On CPU hotplug MSR_IA32_XFD is reset to the init_fpstate.xfd, which
wipes out any stale state. But the per CPU cached xfd value is not
reset, which brings them out of sync.

As a consequence a subsequent xfd_update_state() might fail to update
the MSR which in turn can result in XRSTOR raising a #NM in kernel
space, which crashes the kernel.

To fix this, introduce xfd_set_state() to write xfd_state together
with MSR_IA32_XFD, and use it in all places that set MSR_IA32_XFD.

Fixes: 672365477ae8 ("x86/fpu: Update XFD state where required")
Signed-off-by: Adamos Ttofari <attofari@amazon.de>
Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240322230439.456571-1-chang.seok.bae@intel.com
Closes: https://lore.kernel.org/lkml/20230511152818.13839-1-attofari@amazon.de
arch/x86/kernel/fpu/xstate.c
arch/x86/kernel/fpu/xstate.h