smb3: lower default deferred close timeout to address perf regression
authorSteve French <stfrench@microsoft.com>
Thu, 23 Mar 2023 20:10:26 +0000 (15:10 -0500)
committerSteve French <stfrench@microsoft.com>
Thu, 1 Jun 2023 04:24:22 +0000 (23:24 -0500)
commit1401e545b2b86dc6d57fd70307ab55ca296c2b39
treea50a578dd3722ff00d3a65b2b557595045afad72
parent6d418aa111dff36118660641df019ed181d03e79
smb3: lower default deferred close timeout to address perf regression

Performance tests with large number of threads noted that the change
of the default closetimeo (deferred close timeout between when
close is done by application and when client has to send the close
to the server), to 5 seconds from 1 second, significantly degraded
perf in some cases like this (in the filebench example reported,
the stats show close requests on the wire taking twice as long,
and 50% regression in filebench perf). This is stil configurable
via mount parm closetimeo, but to be safe, decrease default back
to its previous value of 1 second.

Reported-by: Yin Fengwei <fengwei.yin@intel.com>
Reported-by: kernel test robot <yujie.liu@intel.com>
Link: https://lore.kernel.org/lkml/997614df-10d4-af53-9571-edec36b0e2f3@intel.com/
Fixes: 5efdd9122eff ("smb3: allow deferred close timeout to be configurable")
Cc: stable@vger.kernel.org # 6.0+
Tested-by: Yin Fengwei <fengwei.yin@intel.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/fs_context.h