netfilter: nf_tables: Fix potential data-race in __nft_flowtable_type_get()
authorZiyang Xuan <william.xuanziyang@huawei.com>
Wed, 3 Apr 2024 07:22:04 +0000 (15:22 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 4 Apr 2024 09:38:34 +0000 (11:38 +0200)
commit24225011d81b471acc0e1e315b7d9905459a6304
tree0b727c0505617447c54a84e1ddd5836b25796ad9
parent994209ddf4f430946f6247616b2e33d179243769
netfilter: nf_tables: Fix potential data-race in __nft_flowtable_type_get()

nft_unregister_flowtable_type() within nf_flow_inet_module_exit() can
concurrent with __nft_flowtable_type_get() within nf_tables_newflowtable().
And thhere is not any protection when iterate over nf_tables_flowtables
list in __nft_flowtable_type_get(). Therefore, there is pertential
data-race of nf_tables_flowtables list entry.

Use list_for_each_entry_rcu() to iterate over nf_tables_flowtables list
in __nft_flowtable_type_get(), and use rcu_read_lock() in the caller
nft_flowtable_type_get() to protect the entire type query process.

Fixes: 3b49e2e94e6e ("netfilter: nf_tables: add flow table netlink frontend")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c