mm/zswap: don't return LRU_SKIP if we have dropped lru lock
authorChengming Zhou <zhouchengming@bytedance.com>
Sun, 28 Jan 2024 13:28:49 +0000 (13:28 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 8 Feb 2024 05:20:36 +0000 (21:20 -0800)
commit27d3969b47cc38810b3fd65d72231940e8671e6c
tree0bbd29258415e4f39bc0c80fe2256ff6582adb7e
parent79d72c68c58784a3e1cd2378669d51bfd0cb7498
mm/zswap: don't return LRU_SKIP if we have dropped lru lock

LRU_SKIP can only be returned if we don't ever dropped lru lock, or we
need to return LRU_RETRY to restart from the head of lru list.

Otherwise, the iteration might continue from a cursor position that was
freed while the locks were dropped.

Actually we may need to introduce another LRU_STOP to really terminate the
ongoing shrinking scan process, when we encounter a warm page already in
the swap cache.  The current list_lru implementation doesn't have this
function to early break from __list_lru_walk_one.

Link: https://lkml.kernel.org/r/20240126-zswap-writeback-race-v2-1-b10479847099@bytedance.com
Fixes: b5ba474f3f51 ("zswap: shrink zswap pool based on memory pressure")
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Nhat Pham <nphamcs@gmail.com>
Cc: Chris Li <chriscli@google.com>
Cc: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/zswap.c