arm64: Revert "scs: Work around full LTO issue with dynamic SCS"
authorArd Biesheuvel <ardb@kernel.org>
Tue, 23 Jan 2024 13:30:54 +0000 (14:30 +0100)
committerWill Deacon <will@kernel.org>
Tue, 30 Jan 2024 11:52:46 +0000 (11:52 +0000)
commit2fa28abd1090562b4d9bc4aedd70abcca26561af
tree32a8dc4769e5743f61959578f994c1dd8e10b552
parent41bccc98fb7931d63d03f326a746ac4d429c1dd3
arm64: Revert "scs: Work around full LTO issue with dynamic SCS"

This reverts commit 8c5a19cb17a71e ("arm64: scs: Work around full LTO
issue with dynamic SCS"), which did not quite fix the issue as intended.
Apparently, -fno-unwind-tables is ignored for the final full LTO link
when it is set on any of the objects, resulting in an early boot crash
due to the SCS patching code patching itself, and attempting to pop the
return address from the shadow stack while the associated push was still
a PACIASP instruction when it executed.

Reported-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Tested-by: Sami Tolvanen <samitolvanen@google.com>
Link: https://lore.kernel.org/r/20240123133052.1417449-5-ardb+git@google.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/Makefile