s390/qeth: Fix potential loss of L3-IP@ in case of network issues
authorAlexandra Winter <wintera@linux.ibm.com>
Tue, 6 Feb 2024 08:58:49 +0000 (09:58 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 8 Feb 2024 11:10:09 +0000 (12:10 +0100)
commit2fe8a236436fe40d8d26a1af8d150fc80f04ee1a
treecbf394a87cb0b5553c29ba4278532adc53e4d985
parentdb010ff6700f24f96e91ed56ca29cb69335008ef
s390/qeth: Fix potential loss of L3-IP@ in case of network issues

Symptom:
In case of a bad cable connection (e.g. dirty optics) a fast sequence of
network DOWN-UP-DOWN-UP could happen. UP triggers recovery of the qeth
interface. In case of a second DOWN while recovery is still ongoing, it
can happen that the IP@ of a Layer3 qeth interface is lost and will not
be recovered by the second UP.

Problem:
When registration of IP addresses with Layer 3 qeth devices fails, (e.g.
because of bad address format) the respective IP address is deleted from
its hash-table in the driver. If registration fails because of a ENETDOWN
condition, the address should stay in the hashtable, so a subsequent
recovery can restore it.

3caa4af834df ("qeth: keep ip-address after LAN_OFFLINE failure")
fixes this for registration failures during normal operation, but not
during recovery.

Solution:
Keep L3-IP address in case of ENETDOWN in qeth_l3_recover_ip(). For
consistency with qeth_l3_add_ip() we also keep it in case of EADDRINUSE,
i.e. for some reason the card already/still has this address registered.

Fixes: 4a71df50047f ("qeth: new qeth device driver")
Cc: stable@vger.kernel.org
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Link: https://lore.kernel.org/r/20240206085849.2902775-1-wintera@linux.ibm.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/s390/net/qeth_l3_main.c