mptcp: really cope with fastopen race
authorPaolo Abeni <pabeni@redhat.com>
Thu, 8 Feb 2024 18:03:54 +0000 (19:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Feb 2024 10:08:13 +0000 (10:08 +0000)
commit337cebbd850f94147cee05252778f8f78b8c337f
treeb8285f6b5af2c0764e628f51630842e52aaf477e
parentf012d796a6de662692159c539689e47e662853a8
mptcp: really cope with fastopen race

Fastopen and PM-trigger subflow shutdown can race, as reported by
syzkaller.

In my first attempt to close such race, I missed the fact that
the subflow status can change again before the subflow_state_change
callback is invoked.

Address the issue additionally copying with all the states directly
reachable from TCP_FIN_WAIT1.

Fixes: 1e777f39b4d7 ("mptcp: add MSG_FASTOPEN sendmsg flag support")
Fixes: 4fd19a307016 ("mptcp: fix inconsistent state on fastopen race")
Cc: stable@vger.kernel.org
Reported-by: syzbot+c53d4d3ddb327e80bc51@syzkaller.appspotmail.com
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/458
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/protocol.h