netfilter: nf_tables: skip dead set elements in netlink dump
authorPablo Neira Ayuso <pablo@netfilter.org>
Sun, 14 Jan 2024 23:14:38 +0000 (00:14 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 17 Jan 2024 11:02:50 +0000 (12:02 +0100)
commit6b1ca88e4bb63673dc9f9c7f23c899f22c3cb17a
tree5a3fefda2eba9b810f1c5aab7c7360f35f80c2d1
parent3ce67e3793f48c1b9635beb9bb71116ca1e51b58
netfilter: nf_tables: skip dead set elements in netlink dump

Delete from packet path relies on the garbage collector to purge
elements with NFT_SET_ELEM_DEAD_BIT on.

Skip these dead elements from nf_tables_dump_setelem() path, I very
rarely see tests/shell/testcases/maps/typeof_maps_add_delete reports
[DUMP FAILED] showing a mismatch in the expected output with an element
that should not be there.

If the netlink dump happens before GC worker run, it might show dead
elements in the ruleset listing.

nft_rhash_get() already skips dead elements in nft_rhash_cmp(),
therefore, it already does not show the element when getting a single
element via netlink control plane.

Fixes: 5f68718b34a5 ("netfilter: nf_tables: GC transaction API to avoid race with control plane")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c