cifs: Fix duplicate fscache cookie warnings 6.9-rc1-smb3-client-fixes
authorDavid Howells <dhowells@redhat.com>
Wed, 27 Mar 2024 14:13:24 +0000 (14:13 +0000)
committerSteve French <stfrench@microsoft.com>
Wed, 27 Mar 2024 17:04:06 +0000 (12:04 -0500)
commit8876a37277cb832e1861c35f8c661825179f73f5
tree44125d56ff8f69cdfdb878edb4e1c963a59a583f
parente9e9fbeb83f65d3d487e0a0838c0867292c99fb2
cifs: Fix duplicate fscache cookie warnings

fscache emits a lot of duplicate cookie warnings with cifs because the
index key for the fscache cookies does not include everything that the
cifs_find_inode() function does.  The latter is used with iget5_locked() to
distinguish between inodes in the local inode cache.

Fix this by adding the creation time and file type to the fscache cookie
key.

Additionally, add a couple of comments to note that if one is changed the
other must be also.

Signed-off-by: David Howells <dhowells@redhat.com>
Fixes: 70431bfd825d ("cifs: Support fscache indexing rewrite")
cc: Shyam Prasad N <nspmangalore@gmail.com>
cc: Rohith Surabattula <rohiths.msft@gmail.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-cifs@vger.kernel.org
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/fscache.c
fs/smb/client/inode.c