qnx4: Use get_directory_fname() in qnx4_match()
authorKees Cook <keescook@chromium.org>
Thu, 30 Nov 2023 20:51:19 +0000 (12:51 -0800)
committerKees Cook <keescook@chromium.org>
Wed, 13 Dec 2023 19:19:18 +0000 (11:19 -0800)
commita75b3809dce2ad006ebf7fa641f49881fa0d79d7
treebd825eeba92af677f4c1d8d0a530b10640ea9bbc
parent53853995c6652e12b0aa0d15aecda4cbba5183ec
qnx4: Use get_directory_fname() in qnx4_match()

Use the new common directory entry name accessor helper to avoid
confusing the compiler about over-running the file name buffer. Avoids
false positive buffer overflow warning:

[ 4849.636861] detected buffer overflow in strlen
[ 4849.636897] ------------[ cut here ]------------
[ 4849.636902] kernel BUG at lib/string.c:1165!
...
[ 4849.637047] Call Trace:
...
[ 4849.637251]  qnx4_find_entry.cold+0xc/0x18 [qnx4]
[ 4849.637264]  qnx4_lookup+0x3c/0xa0 [qnx4]

Reported-by: Ronald Monthero <debug.penguin32@gmail.com>
Closes: https://lore.kernel.org/lkml/20231112095353.579855-1-debug.penguin32@gmail.com/
Acked-by: Anders Larsen <al@alarsen.net>
Link: https://lore.kernel.org/r/20231130205120.3642477-2-keescook@chromium.org
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/qnx4/namei.c