rpmsg: Replace deprecated strncpy with strscpy_pad
authorJustin Stitt <justinstitt@google.com>
Fri, 20 Oct 2023 23:18:59 +0000 (23:18 +0000)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Mon, 23 Oct 2023 17:57:57 +0000 (11:57 -0600)
commitec189da923fb06acb0ee38e2d0ee55239995e9d6
tree7e09ac33bf08bdb2e4da5d1162b1ed511be47c1e
parenta9580b9b36a88f8cc92ae52820a386f92c8d6065
rpmsg: Replace deprecated strncpy with strscpy_pad

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

We expect chinfo.name to be NUL-terminated based on its use with format
strings:
|       dev_err(&ctrldev->dev, "failed to create %s channel\n", chinfo.name);

Since chinfo is not default initialized, we should NUL-pad the `name`
field so that the behavior is consistent with what strncpy() provides:
|       struct rpmsg_channel_info chinfo;

Considering the above, a suitable replacement is `strscpy_pad` due to
the fact that it guarantees both NUL-termination and NUL-padding on the
destination buffer.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20231020-strncpy-drivers-rpmsg-rpmsg_ns-c-v1-1-99b16b00c36c@google.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/rpmsg/rpmsg_ns.c