misc: pci_endpoint_test: Re-init completion for every test
authorDamien Le Moal <dlemoal@kernel.org>
Sat, 15 Apr 2023 02:35:40 +0000 (11:35 +0900)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 23 Jun 2023 20:03:34 +0000 (15:03 -0500)
commitfb620ae73b70c2f57b9d3e911fc24c024ba2324f
treea2d3149033142ee827a006fcfe7b4222696135f7
parentf61b7634a3249d12b9daa36ffbdb9965b6f24c6c
misc: pci_endpoint_test: Re-init completion for every test

The irq_raised completion used to detect the end of a test case is
initialized when the test device is probed, but never reinitialized again
before a test case. As a result, the irq_raised completion synchronization
is effective only for the first ioctl test case executed. Any subsequent
call to wait_for_completion() by another ioctl() call will immediately
return, potentially too early, leading to false positive failures.

Fix this by reinitializing the irq_raised completion before starting a new
ioctl() test command.

Link: https://lore.kernel.org/r/20230415023542.77601-16-dlemoal@kernel.org
Fixes: 2c156ac71c6b ("misc: Add host side PCI driver for PCI test function device")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Cc: stable@vger.kernel.org
drivers/misc/pci_endpoint_test.c