Input: synaptics-rmi4 - fix UAF of IRQ domain on driver removal
authorMathias Krause <minipli@grsecurity.net>
Thu, 22 Feb 2024 14:26:54 +0000 (15:26 +0100)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 7 Mar 2024 23:29:52 +0000 (15:29 -0800)
commitfbf8d71742557abaf558d8efb96742d442720cc2
tree0e3abc2bdc680208091565c0546724b18edf2dfc
parent963465a33141d0d52338e77f80fe543d2c9dc053
Input: synaptics-rmi4 - fix UAF of IRQ domain on driver removal

Calling irq_domain_remove() will lead to freeing the IRQ domain
prematurely. The domain is still referenced and will be attempted to get
used via rmi_free_function_list() -> rmi_unregister_function() ->
irq_dispose_mapping() -> irq_get_irq_data()'s ->domain pointer.

With PaX's MEMORY_SANITIZE this will lead to an access fault when
attempting to dereference embedded pointers, as in Torsten's report that
was faulting on the 'domain->ops->unmap' test.

Fix this by releasing the IRQ domain only after all related IRQs have
been deactivated.

Fixes: 24d28e4f1271 ("Input: synaptics-rmi4 - convert irq distribution to irq_domain")
Reported-by: Torsten Hilbrich <torsten.hilbrich@secunet.com>
Signed-off-by: Mathias Krause <minipli@grsecurity.net>
Link: https://lore.kernel.org/r/20240222142654.856566-1-minipli@grsecurity.net
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_driver.c