From: Andreas Schneider Date: Thu, 21 Jul 2022 05:33:11 +0000 (+0200) Subject: tests: Fix compiler warning that arrays might not be initialized X-Git-Tag: socket_wrapper-1.3.4~6 X-Git-Url: http://git.samba.org/?p=socket_wrapper.git;a=commitdiff_plain;h=9c3113d2c30c65ac01f0a795e9e9b0df53abcce2 tests: Fix compiler warning that arrays might not be initialized tests/test_echo_tcp_sendmsg_recvmsg_fd.c: In function 'test_tcp_sendmsg_recvmsg_fd_mixed': tests/test_echo_tcp_sendmsg_recvmsg_fd.c:477:9: error: '' may be used uninitialized [-Werror=maybe-uninitialized] 477 | test_tcp_sendmsg_recvmsg_fd_array(fd_array, num_fds); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tests/test_echo_tcp_sendmsg_recvmsg_fd.c:103:13: note: by argument 1 of type 'const int *' to 'test_tcp_sendmsg_recvmsg_fd_array' declared here 103 | static void test_tcp_sendmsg_recvmsg_fd_array(const int *fds, size_t num_fds) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher --- diff --git a/tests/test_echo_tcp_sendmsg_recvmsg_fd.c b/tests/test_echo_tcp_sendmsg_recvmsg_fd.c index 215d5ff..e6892e6 100644 --- a/tests/test_echo_tcp_sendmsg_recvmsg_fd.c +++ b/tests/test_echo_tcp_sendmsg_recvmsg_fd.c @@ -320,6 +320,9 @@ static void test_tcp_sendmsg_recvmsg_fd_different(size_t num_fds) int fd_array[num_fds]; size_t idx; + assert_int_not_equal(num_fds, 0); + memset(fd_array, -1, sizeof(fd_array)); + for (idx = 0; idx < num_fds; idx++) { struct torture_address addr = { .sa_socklen = sizeof(struct sockaddr_in), @@ -388,10 +391,10 @@ static void test_tcp_sendmsg_recvmsg_fd_mixed(size_t num_fds) int close_array[num_fds]; size_t idx; - for (idx = 0; idx < num_fds; idx++) { - fd_array[idx] = -1; - close_array[idx] = -1; - } + assert_int_not_equal(num_fds, 0); + + memset(fd_array, -1, sizeof(fd_array)); + memset(close_array, -1, sizeof(fd_array)); /* * We send