From: Stefan Metzmacher <metze@samba.org>
Date: Wed, 10 Feb 2021 09:45:11 +0000 (+0100)
Subject: swrap: don't read the callers msg_control buffer in swrap_recvmsg_before_unix()
X-Git-Tag: socket_wrapper-1.3.2~1
X-Git-Url: http://git.samba.org/?p=socket_wrapper.git;a=commitdiff_plain;h=d610c8d5b32db5c3cc6e57b11d1d2e1505975832

swrap: don't read the callers msg_control buffer in swrap_recvmsg_before_unix()

For recvmsg() msg_control is a write only buffer, that is filled by the
kernel, but the kernel won't read from that buffer. So we shouldn't
read from (copy) it either.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/src/socket_wrapper.c b/src/socket_wrapper.c
index 59fb07d..a950a0a 100644
--- a/src/socket_wrapper.c
+++ b/src/socket_wrapper.c
@@ -5993,7 +5993,6 @@ static int swrap_recvmsg_before_unix(struct msghdr *msg_in,
 	if (cm_data == NULL) {
 		return -1;
 	}
-	memcpy(cm_data, msg_in->msg_control, msg_in->msg_controllen);
 
 	msg_tmp->msg_controllen = cm_data_space;
 	msg_tmp->msg_control = cm_data;