CVE-2022-32746 ldb: Make use of functions for appending to an ldb_message
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 21 Feb 2022 03:27:37 +0000 (16:27 +1300)
committerJule Anger <janger@samba.org>
Sun, 24 Jul 2022 09:41:53 +0000 (11:41 +0200)
commitf419753d1c7a373fb32ffe20930a6e084e44b44d
tree1d7c758c8dcb59705ca77a73ad0c736271c1e6ef
parent512a2617b1593bdc16caeeeda4312a581cbb34e9
CVE-2022-32746 ldb: Make use of functions for appending to an ldb_message

This aims to minimise usage of the error-prone pattern of searching for
a just-added message element in order to make modifications to it (and
potentially finding the wrong element).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15009

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
15 files changed:
lib/ldb/ldb_map/ldb_map.c
lib/ldb/ldb_map/ldb_map_inbound.c
lib/ldb/modules/rdn_name.c
source3/passdb/pdb_samba_dsdb.c
source4/dns_server/dnsserver_common.c
source4/dsdb/common/util.c
source4/dsdb/samdb/ldb_modules/descriptor.c
source4/dsdb/samdb/ldb_modules/objectguid.c
source4/dsdb/samdb/ldb_modules/partition_init.c
source4/dsdb/samdb/ldb_modules/repl_meta_data.c
source4/dsdb/samdb/ldb_modules/samldb.c
source4/dsdb/samdb/ldb_modules/tombstone_reanimate.c
source4/nbt_server/wins/winsdb.c
source4/rpc_server/lsa/dcesrv_lsa.c
source4/winbind/idmap.c