git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
420be02
)
s3: Fix Coverity ID 2290: Uninitialized read
author
Volker Lendecke
<vl@samba.org>
Tue, 15 Mar 2011 09:47:02 +0000
(10:47 +0100)
committer
Volker Lendecke
<vl@samba.org>
Tue, 15 Mar 2011 10:10:42 +0000
(11:10 +0100)
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteKey.
source3/utils/net_rpc_registry.c
patch
|
blob
|
history
diff --git
a/source3/utils/net_rpc_registry.c
b/source3/utils/net_rpc_registry.c
index c98fc076553a286b0d0efd09fcf58ce174f2d8a6..17c5d5a4b63be831c54915fe55a366e2ee1df301 100644
(file)
--- a/
source3/utils/net_rpc_registry.c
+++ b/
source3/utils/net_rpc_registry.c
@@
-1782,7
+1782,7
@@
static WERROR import_delete_key(struct import_ctx* ctx,
WERROR werr;
NTSTATUS status;
void* mem_ctx = talloc_new(ctx->mem_ctx);
- struct winreg_String keyname;
+ struct winreg_String keyname
= { 0, }
;
struct policy_handle hive;
struct dcerpc_binding_handle *b = ctx->pipe_hnd->binding_handle;