s3: Fix Coverity ID 2281: Uninitialized read
authorVolker Lendecke <vl@samba.org>
Tue, 15 Mar 2011 10:05:48 +0000 (11:05 +0100)
committerVolker Lendecke <vl@samba.org>
Tue, 15 Mar 2011 10:10:45 +0000 (11:10 +0100)
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.

source3/rpc_server/spoolss/srv_spoolss_util.c

index 6ed6f342b5fe8584a1a12ed598af934e0c2c461b..62c95c980df18c3fdcbc3d709f4812fdde536998 100644 (file)
@@ -2228,7 +2228,7 @@ WERROR winreg_set_printer_dataex(TALLOC_CTX *mem_ctx,
        uint32_t access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
        struct dcerpc_binding_handle *winreg_handle = NULL;
        struct policy_handle hive_hnd, key_hnd;
-       struct winreg_String wvalue;
+       struct winreg_String wvalue = { 0, };
        char *path;
        WERROR result = WERR_OK;
        NTSTATUS status;