s3:gse: avoid prompting for a password that we don't use in the end
authorStefan Metzmacher <metze@samba.org>
Thu, 14 Apr 2022 12:23:23 +0000 (14:23 +0200)
committerStefan Metzmacher <metze@samba.org>
Tue, 7 May 2024 11:30:33 +0000 (11:30 +0000)
Currently we rely on a valid default credential cache being available
and don't make use of the password.

In future we'll do a kinit on demand, but that's for another day.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/librpc/crypto/gse.c

index 2b803dc8f0ce3db30d93ceb97ed74d15fe2b55b1..f89b40eba0c398dde80e50278bcd302b7f074460 100644 (file)
@@ -281,9 +281,6 @@ err_out:
 static NTSTATUS gse_init_client(struct gensec_security *gensec_security,
                                bool do_sign, bool do_seal,
                                const char *ccache_name,
-                               const char *realm,
-                               const char *username,
-                               const char *password,
                                uint32_t add_gss_c_flags,
                                struct gse_context **_gse_ctx)
 {
@@ -865,9 +862,6 @@ static NTSTATUS gensec_gse_client_start(struct gensec_security *gensec_security)
        NTSTATUS nt_status;
        OM_uint32 want_flags = 0;
        bool do_sign = false, do_seal = false;
-       const char *username = cli_credentials_get_username(creds);
-       const char *password = cli_credentials_get_password(creds);
-       const char *realm = cli_credentials_get_realm(creds);
 
        nt_status = gensec_kerberos_possible(gensec_security);
        if (!NT_STATUS_IS_OK(nt_status)) {
@@ -915,7 +909,6 @@ static NTSTATUS gensec_gse_client_start(struct gensec_security *gensec_security)
 #endif
 
        nt_status = gse_init_client(gensec_security, do_sign, do_seal, NULL,
-                                   realm, username, password,
                                    want_flags, &gse_ctx);
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;