s4-schema_syntax: Log error message when _dsdb_syntax_OID_oid_drsuapi_to_ldb() fails
authorKamen Mazdrashki <kamenim@samba.org>
Fri, 10 Dec 2010 02:22:58 +0000 (04:22 +0200)
committerKamen Mazdrashki <kamenim@samba.org>
Mon, 13 Dec 2010 19:32:31 +0000 (21:32 +0200)
I haven't found a way to test this function during replication so far,
but when I do, it will be useful to notice this error in the log file

source4/dsdb/schema/schema_syntax.c

index 713edbb54621b4d3aeb454dc205fa5d55088cad2..3f2d3bb62dfd1bb2df539c8bb3cd4198fdf50852 100644 (file)
@@ -1094,7 +1094,11 @@ static WERROR _dsdb_syntax_OID_oid_drsuapi_to_ldb(const struct dsdb_syntax_ctx *
 
                status = dsdb_schema_pfm_oid_from_attid(ctx->pfm_remote, attid,
                                                        out->values, &oid);
-               W_ERROR_NOT_OK_RETURN(status);
+               if (!W_ERROR_IS_OK(status)) {
+                       DEBUG(0,(__location__ ": Error: Unknown ATTID 0x%08X\n",
+                                attid));
+                       return status;
+               }
 
                out->values[i] = data_blob_string_const(oid);
        }