s3: Fix Coverity ID 2234: REVERSE_INULL
authorVolker Lendecke <vl@samba.org>
Wed, 16 Mar 2011 20:47:10 +0000 (21:47 +0100)
committerVolker Lendecke <vl@samba.org>
Wed, 16 Mar 2011 21:07:24 +0000 (22:07 +0100)
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521

source3/rpc_server/netlogon/srv_netlog_nt.c

index 8e766328f586e96d979be0a30a28524f25a09978..bfa3bb25e8b4f177f4eb5931eecca2b92c71f062 100644 (file)
@@ -617,10 +617,10 @@ static NTSTATUS samr_find_machine_account(TALLOC_CTX *mem_ctx,
        }
 
  out:
-       if (b && is_valid_policy_hnd(&domain_handle)) {
+       if (is_valid_policy_hnd(&domain_handle)) {
                dcerpc_samr_Close(b, mem_ctx, &domain_handle, &result);
        }
-       if (b && is_valid_policy_hnd(&connect_handle)) {
+       if (is_valid_policy_hnd(&connect_handle)) {
                dcerpc_samr_Close(b, mem_ctx, &connect_handle, &result);
        }