s4:dns_server: less noisy, more informative debug messages
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 10 Apr 2024 23:52:14 +0000 (11:52 +1200)
committerJule Anger <janger@samba.org>
Tue, 16 Apr 2024 11:24:15 +0000 (11:24 +0000)
This shouldn't have been DBG_ERR, and it might as well say something
about the tombstone.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15630

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Apr 12 15:18:05 UTC 2024 on atb-devel-224

(cherry picked from commit dde973d170e479632d1a411279f4f0fad6608539)

source4/dns_server/dnsserver_common.c

index fbe39d99bf01b94addacab6a3ef095989757cee9..aba7f4128b24993b72b2b2448c8dd4a87210612b 100644 (file)
@@ -1034,10 +1034,11 @@ WERROR dns_common_replace(struct ldb_context *samdb,
                         * record.
                         */
                        if (records[i].data.EntombedTime != 0) {
-                               if (rec_count != 1) {
-                                       DBG_ERR("tombstone record has %u neighbour "
-                                               "records.\n",
-                                               rec_count - 1);
+                               if (rec_count != 1 && DEBUGLVL(DBGLVL_NOTICE)) {
+                                       DBG_NOTICE("tombstone record [%u] has "
+                                                  "%u neighbour records.\n",
+                                                  i, rec_count - 1);
+                                       NDR_PRINT_DEBUG(dnsp_DnssrvRpcRecord, &records[i]);
                                }
                                was_tombstoned = true;
                        }