From: David Mulder <dmulder@suse.com>
Date: Fri, 1 Dec 2017 18:18:55 +0000 (-0700)
Subject: gpo: Only commit the earliest change to the log
X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;ds=sidebyside;h=ac56f870182054942aff462bf226d52edd927468;p=mdw%2Fsamba.git

gpo: Only commit the earliest change to the log

Otherwise we overwrite the original value,
leaving the setting tattooed on unapplied

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/python/samba/gpclass.py b/python/samba/gpclass.py
index 780ef558b9..00330eb5ec 100644
--- a/python/samba/gpclass.py
+++ b/python/samba/gpclass.py
@@ -180,7 +180,7 @@ class gp_log:
         if attr is None:
             attr = etree.SubElement(ext, 'attribute')
             attr.attrib['name'] = attribute
-        attr.text = old_val
+            attr.text = old_val
 
     def retrieve(self, gp_ext_name, attribute):
         ''' Retrieve a stored attribute from the gp_log