From: Andrew Bartlett <abartlet@samba.org>
Date: Thu, 9 Feb 2012 21:07:21 +0000 (+1100)
Subject: Revert "gensec: Fix a memory corruption in gensec_use_kerberos_mechs"
X-Git-Tag: samba-4.0.0alpha18~220
X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;h=901e3b7246de9bdc07e2b3d88f55917bf2a37377;p=samba.git

Revert "gensec: Fix a memory corruption in gensec_use_kerberos_mechs"

This reverts commit 744ed53a62037a659133ccd4de2065491208ae7d.

The real bug here is that the second half of the outer loop should not
have been run once we found spnego.

Andrew Bartlett
---

diff --git a/auth/gensec/gensec_start.c b/auth/gensec/gensec_start.c
index ab092a7bb17..08b2fb68cb1 100644
--- a/auth/gensec/gensec_start.c
+++ b/auth/gensec/gensec_start.c
@@ -75,8 +75,7 @@ _PUBLIC_ struct gensec_security_ops **gensec_use_kerberos_mechs(TALLOC_CTX *mem_
 		/* noop */
 	}
 
-	new_gensec_list = talloc_array(mem_ctx, struct gensec_security_ops *,
-				       num_mechs_in*2 + 1);
+	new_gensec_list = talloc_array(mem_ctx, struct gensec_security_ops *, num_mechs_in + 1);
 	if (!new_gensec_list) {
 		return NULL;
 	}